Skip to content

Commit 6660a7d

Browse files
Fixed static test failures
1 parent a15916c commit 6660a7d

File tree

14 files changed

+34
-18
lines changed

14 files changed

+34
-18
lines changed

app/code/Magento/Multishipping/Block/Checkout/State.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ public function __construct(
3131
}
3232

3333
/**
34+
* Retrieve available checkout steps
35+
*
3436
* @return array
3537
*/
3638
public function getSteps()

app/code/Magento/Multishipping/Block/Checkout/Success.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ public function __construct(
3030
}
3131

3232
/**
33+
* Get Order Ids
34+
*
3335
* @return array|bool|string
3436
*/
3537
public function getOrderIds()
@@ -42,6 +44,8 @@ public function getOrderIds()
4244
}
4345

4446
/**
47+
* Get order Url
48+
*
4549
* @param int $orderId
4650
* @return string
4751
*/
@@ -51,6 +55,8 @@ public function getViewOrderUrl($orderId)
5155
}
5256

5357
/**
58+
* Get continue Url
59+
*
5460
* @return string
5561
*/
5662
public function getContinueUrl()

app/code/Magento/Multishipping/Model/Checkout/Type/Multishipping/State.php

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,17 @@
1313
*/
1414
class State extends \Magento\Framework\DataObject
1515
{
16-
const STEP_SELECT_ADDRESSES = 'multishipping_addresses';
16+
public const STEP_SELECT_ADDRESSES = 'multishipping_addresses';
1717

18-
const STEP_SHIPPING = 'multishipping_shipping';
18+
public const STEP_SHIPPING = 'multishipping_shipping';
1919

20-
const STEP_BILLING = 'multishipping_billing';
20+
public const STEP_BILLING = 'multishipping_billing';
2121

22-
const STEP_OVERVIEW = 'multishipping_overview';
22+
public const STEP_OVERVIEW = 'multishipping_overview';
2323

24-
const STEP_SUCCESS = 'multishipping_success';
24+
public const STEP_SUCCESS = 'multishipping_success';
2525

26-
const STEP_RESULTS = 'multishipping_results';
26+
public const STEP_RESULTS = 'multishipping_results';
2727

2828
/**
2929
* Allow steps array
@@ -105,6 +105,8 @@ public function getActiveStep()
105105
}
106106

107107
/**
108+
* Setup Checkout step
109+
*
108110
* @param string $step
109111
* @return $this
110112
*/
@@ -169,7 +171,9 @@ public function unsCompleteStep($step)
169171
return $this;
170172
}
171173

174+
// phpcs:disable
172175
/**
176+
*
173177
* @return bool
174178
*/
175179
public function canSelectAddresses()
@@ -197,6 +201,7 @@ public function canSuccess()
197201
{
198202
}
199203

204+
// phpcs:enable
200205
/**
201206
* Retrieve checkout session
202207
*

app/code/Magento/Newsletter/Block/Adminhtml/Subscriber.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
class Subscriber extends Template
2424
{
2525
/**
26-
* Queue collection
26+
* Queue collection property
2727
*
2828
* @var Collection
2929
*/

app/code/Magento/Newsletter/Block/Adminhtml/Template.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ class Template extends \Magento\Backend\Block\Template
1717
protected $_template = 'Magento_Newsletter::template/list.phtml';
1818

1919
/**
20+
* Prepare the layout
21+
*
2022
* @return $this
2123
*/
2224
protected function _prepareLayout()

app/code/Magento/Newsletter/Block/Adminhtml/Template/Grid/Renderer/Sender.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
namespace Magento\Newsletter\Block\Adminhtml\Template\Grid\Renderer;
1111

1212
/**
13-
* Class Sender
13+
* Class Newsletter Grid Renderer Sender
1414
*/
1515
class Sender extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\AbstractRenderer
1616
{
@@ -32,7 +32,7 @@ public function render(\Magento\Framework\DataObject $row)
3232
if ($str == '') {
3333
$str .= '---';
3434
}
35-
35+
3636
return $str;
3737
}
3838
}

app/code/Magento/Newsletter/Block/Subscribe.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@
1616
class Subscribe extends \Magento\Framework\View\Element\Template
1717
{
1818
/**
19-
* Retrieve form action url and set "secure" param to avoid confirm
20-
* message when we submit form from secure page to unsecure
19+
* Get form action url & set secure param to avoid confirm message when we submit form from secure page to unsecure
2120
*
2221
* @return string
2322
*/

app/code/Magento/Newsletter/Controller/Adminhtml/Queue.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@ abstract class Queue extends \Magento\Backend\App\Action
1616
*
1717
* @see _isAllowed()
1818
*/
19-
const ADMIN_RESOURCE = 'Magento_Newsletter::queue';
19+
public const ADMIN_RESOURCE = 'Magento_Newsletter::queue';
2020
}

app/code/Magento/Newsletter/Controller/Adminhtml/Template.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ abstract class Template extends \Magento\Backend\App\Action
1515
*
1616
* @see _isAllowed()
1717
*/
18-
const ADMIN_RESOURCE = 'Magento_Newsletter::template';
18+
public const ADMIN_RESOURCE = 'Magento_Newsletter::template';
1919
}

app/code/Magento/Newsletter/Model/Problem.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class Problem extends \Magento\Framework\Model\AbstractModel
3030
protected $_subscriber = null;
3131

3232
/**
33-
* Subscriber factory
33+
* Subscriber factory variable
3434
*
3535
* @var \Magento\Newsletter\Model\SubscriberFactory
3636
*/

0 commit comments

Comments
 (0)