mark indexer as invalid if there were children categories

Author: engcom-Charlie

app/code/Magento/Catalog/Model/Category.php

@@ -1159,9 +1159,10 @@ public function reindex()
      */
     public function afterDeleteCommit()
     {
-        if ($this->getIsActive()) {
+        if ($this->getIsActive() || $this->getDeletedChildrenIds()) {
             $this->reindex();
         }
+
         return parent::afterDeleteCommit();
     }
 

app/code/Magento/Catalog/Model/ResourceModel/Category.php

@@ -232,9 +232,10 @@ protected function _beforeDelete(\Magento\Framework\DataObject $object)
      */
     protected function _afterDelete(DataObject $object)
     {
-        if ($object->getIsActive()) {
+        if ($object->getIsActive() || $object->getDeletedChildrenIds()) {
             $this->indexerProcessor->markIndexerAsInvalid();
         }
+
         return parent::_afterDelete($object);
     }
 

app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Model/Plugin/Category.php

@@ -40,7 +40,7 @@ public function __construct(Processor $fulltextIndexerProcessor)
      */
     public function afterDelete(Resource $subjectCategory, Resource $resultCategory, DataObject $object) : Resource
     {
-        if ($object->getIsActive()) {
+        if ($object->getIsActive() || $object->getDeletedChildrenIds()) {
             $this->fulltextIndexerProcessor->markIndexerAsInvalid();
         }
 

dev/tests/integration/testsuite/Magento/Catalog/Model/Indexer/Category/ProductTest.php

@@ -196,15 +196,15 @@ public function testCategoryDelete()
     public function testDeleteInactiveCategory(): void
     {
         $this->indexer->reindexAll();
-        $indexerShouldBeValid = $this->indexer->isInvalid();
+        $isInvalidIndexer = $this->indexer->isInvalid();
 
         $this->categoryRepository->deleteByIdentifier(4);
 
         $state = $this->indexer->getState();
         $state->loadByIndexer($this->indexer->getId());
         $status = $state->getStatus();
 
-        $this->assertFalse($indexerShouldBeValid);
+        $this->assertFalse($isInvalidIndexer);
         $this->assertEquals(StateInterface::STATUS_VALID, $status);
     }