MAGETWO-56206: API - inconsistency in the Magento response data types

- Remove magic toArray method for comparison of customer objects
- Move test objects to more appropriate location
- Fix multi-line array style

Author: tjwiebell

dev/tests/integration/testsuite/Magento/Customer/Block/Adminhtml/Edit/Tab/View/PersonalInfoTest.php

@@ -99,7 +99,11 @@ public function tearDown()
      */
     public function testGetCustomer()
     {
-        $expectedCustomerData = $this->_loadCustomer()->__toArray();
+        $expectedCustomer = $this->_loadCustomer();
+        $expectedCustomerData = $this->_dataObjectProcessor->buildOutputDataArray(
+            $expectedCustomer,
+            \Magento\Customer\Api\Data\CustomerInterface::class
+        );
         $actualCustomerData = $this->_block->getCustomer()->__toArray();
         foreach ($expectedCustomerData as $property => $value) {
             $expectedValue = is_numeric($value) ? intval($value) : $value;

lib/internal/Magento/Framework/Reflection/Test/Unit/DataObjectProcessorTest.php

@@ -67,19 +67,22 @@ protected function setUp()
     public function testBuildOutputDataArray($extensionAttributes, $expectedOutputDataArray)
     {
         $objectManager =  new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
-        /** @var \Magento\Framework\Reflection\Test\Unit\_files\TestDataObject $testDataObject */
-        $testDataObject = $objectManager->getObject(_files\TestDataObject::class, [
-            'extensionAttributes' => $this->getMockForAbstractClass(
-                \Magento\Framework\Api\ExtensionAttributesInterface::class
-            )
-        ]);
+        /** @var \Magento\Framework\Reflection\Test\Unit\TestDataObject $testDataObject */
+        $testDataObject = $objectManager->getObject(
+            \Magento\Framework\Reflection\Test\Unit\TestDataObject::class,
+            [
+                'extensionAttributes' => $this->getMockForAbstractClass(
+                    \Magento\Framework\Api\ExtensionAttributesInterface::class
+                )
+            ]
+        );
 
         $this->extensionAttributesProcessorMock->expects($this->once())
             ->method('buildOutputDataArray')
             ->willReturn($extensionAttributes);
 
         $outputData = $this->dataObjectProcessor
-            ->buildOutputDataArray($testDataObject, _files\TestDataInterface::class);
+            ->buildOutputDataArray($testDataObject, \Magento\Framework\Reflection\Test\Unit\TestDataInterface::class);
         $this->assertEquals($expectedOutputDataArray, $outputData);
     }
 
@@ -100,9 +103,10 @@ public function buildOutputDataArrayDataProvider()
             'No Attributes' => [[], $expectedOutputDataArray],
             'With Attributes' => [
                 $extensionAttributeArray,
-                array_merge($expectedOutputDataArray, [
-                    'extension_attributes' => $extensionAttributeArray
-                ])
+                array_merge(
+                    $expectedOutputDataArray,
+                    ['extension_attributes' => $extensionAttributeArray]
+                )
             ]
         ];
     }

lib/internal/Magento/Framework/Reflection/Test/Unit/_files/TestDataInterface.php renamed to lib/internal/Magento/Framework/Reflection/Test/Unit/TestDataInterface.php

@@ -3,7 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-namespace Magento\Framework\Reflection\Test\Unit\_files;
+namespace Magento\Framework\Reflection\Test\Unit;
 
 interface TestDataInterface
 {

lib/internal/Magento/Framework/Reflection/Test/Unit/_files/TestDataObject.php renamed to lib/internal/Magento/Framework/Reflection/Test/Unit/TestDataObject.php

@@ -3,7 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-namespace Magento\Framework\Reflection\Test\Unit\_files;
+namespace Magento\Framework\Reflection\Test\Unit;
 
 class TestDataObject implements TestDataInterface
 {