magento2-login-as-customer/issues/29: Static tests fix.

Author: engcom-Foxtrot

app/code/Magento/LoginAsCustomerUi/Controller/Adminhtml/Login/Login.php

@@ -31,6 +31,8 @@
  * Generate secret key and forward to the storefront action
  *
  * This action can be executed via GET request when "Store View To Login In" is disabled, and POST when it is enabled
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class Login extends Action implements HttpGetActionInterface, HttpPostActionInterface
 {

app/code/Magento/LoginAsCustomerUi/Plugin/AdminLogoutPlugin.php

@@ -8,13 +8,16 @@
 namespace Magento\LoginAsCustomerUi\Plugin;
 
 use Magento\Backend\Model\Auth;
-use Magento\LoginAsCustomer\Model\Config;
+use Magento\LoginAsCustomerApi\Api\ConfigInterface;
 use Magento\LoginAsCustomerApi\Api\DeleteExpiredAuthenticationDataInterface;
 
+/**
+ * Delete all Login as Customer sessions for logging out admin.
+ */
 class AdminLogoutPlugin
 {
     /**
-     * @var Config
+     * @var ConfigInterface
      */
     private $config;
 
@@ -24,18 +27,20 @@ class AdminLogoutPlugin
     private $deleteExpiredAuthenticationData;
 
     /**
-     * @param Config $config
+     * @param ConfigInterface $config
      * @param DeleteExpiredAuthenticationDataInterface $deleteExpiredAuthenticationData
      */
     public function __construct(
-        Config $config,
+        ConfigInterface $config,
         DeleteExpiredAuthenticationDataInterface $deleteExpiredAuthenticationData
     ) {
         $this->config = $config;
         $this->deleteExpiredAuthenticationData = $deleteExpiredAuthenticationData;
     }
 
     /**
+     * Delete all Login as Customer sessions for logging out admin.
+     *
      * @param Auth $subject
      */
     public function beforeLogout(Auth $subject): void

app/code/Magento/LoginAsCustomerUi/Plugin/InvalidateExpiredSessionPlugin.php

@@ -8,17 +8,16 @@
 
 use Magento\Customer\Model\Session;
 use Magento\Framework\App\ActionInterface;
-use Magento\LoginAsCustomer\Model\Config;
+use Magento\LoginAsCustomerApi\Api\ConfigInterface;
 use Magento\LoginAsCustomerApi\Api\IsLoginAsCustomerSessionActiveInterface;
-use Magento\Security\Model\AdminSessionInfoFactory;
 
 /**
  * Invalidate expired and not active Login as Customer sessions.
  */
 class InvalidateExpiredSessionPlugin
 {
     /**
-     * @var Config
+     * @var ConfigInterface
      */
     private $config;
 
@@ -33,24 +32,16 @@ class InvalidateExpiredSessionPlugin
     private $isLoginAsCustomerSessionActive;
 
     /**
-     * @var AdminSessionInfoFactory
-     */
-    private $adminSessionInfoFactory;
-
-    /**
-     * @param Config $config
+     * @param ConfigInterface $config
      * @param Session $session
-     * @param AdminSessionInfoFactory $adminSessionInfoFactory
      * @param IsLoginAsCustomerSessionActiveInterface $isLoginAsCustomerSessionActive
      */
     public function __construct(
-        Config $config,
+        ConfigInterface $config,
         Session $session,
-        AdminSessionInfoFactory $adminSessionInfoFactory,
         IsLoginAsCustomerSessionActiveInterface $isLoginAsCustomerSessionActive
     ) {
         $this->session = $session;
-        $this->adminSessionInfoFactory = $adminSessionInfoFactory;
         $this->isLoginAsCustomerSessionActive = $isLoginAsCustomerSessionActive;
         $this->config = $config;
     }
@@ -61,6 +52,7 @@ public function __construct(
      * @param ActionInterface $subject
      * @throws \Magento\Framework\Exception\LocalizedException
      * @throws \Magento\Framework\Exception\NoSuchEntityException
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function beforeExecute(ActionInterface $subject)
     {