Merge branch '2.4-develop' into ACP2E-4011

Author: katmoon

app/bootstrap.php

@@ -13,9 +13,8 @@
 }
 #ini_set('display_errors', 1);
 
-/* PHP version validation */
-if (!defined('PHP_VERSION_ID') || PHP_VERSION_ID < 80100) {
-    if (PHP_SAPI == 'cli') {
+if (PHP_VERSION_ID < 80100) {
+    if (PHP_SAPI === 'cli') {
         echo 'Magento supports PHP 8.1.0 or later. ' .
             'Please read https://experienceleague.adobe.com/docs/commerce-operations/installation-guide/system-requirements.html';
     } else {
@@ -31,16 +30,6 @@
     exit(1);
 }
 
-// PHP 8 compatibility. Define constants that are not present in PHP < 8.0
-if (!defined('PHP_VERSION_ID') || PHP_VERSION_ID < 80000) {
-    if (!defined('T_NAME_QUALIFIED')) {
-        define('T_NAME_QUALIFIED', 24001);
-    }
-    if (!defined('T_NAME_FULLY_QUALIFIED')) {
-        define('T_NAME_FULLY_QUALIFIED', 24002);
-    }
-}
-
 require_once __DIR__ . '/autoload.php';
 // Sets default autoload mappings, may be overridden in Bootstrap::create
 \Magento\Framework\App\Bootstrap::populateAutoloader(BP, []);

app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/Index.php

@@ -6,6 +6,7 @@
 namespace Magento\AdminNotification\Controller\Adminhtml\Notification;
 
 use Magento\Framework\App\Action\HttpGetActionInterface as HttpGetActionInterface;
+use Magento\Framework\View\Result\Page;
 
 class Index extends \Magento\AdminNotification\Controller\Adminhtml\Notification implements HttpGetActionInterface
 {
@@ -14,14 +15,14 @@ class Index extends \Magento\AdminNotification\Controller\Adminhtml\Notification
      */
     public function execute()
     {
-        $this->_view->loadLayout();
-        $this->_setActiveMenu(
-            'Magento_AdminNotification::system_adminnotification'
-        )->_addBreadcrumb(
+        /** @var Page $resultPage */
+        $resultPage = $this->resultFactory->create(\Magento\Framework\Controller\ResultFactory::TYPE_PAGE);
+        $resultPage->setActiveMenu('Magento_AdminNotification::system_adminnotification');
+        $resultPage->addBreadcrumb(
             __('Messages Inbox'),
             __('Messages Inbox')
         );
-        $this->_view->getPage()->getConfig()->getTitle()->prepend(__('Notifications'));
-        return $this->_view->renderLayout();
+        $resultPage->getConfig()->getTitle()->prepend(__('Notifications'));
+        return $resultPage;
     }
 }

app/code/Magento/AdvancedSearch/Model/Client/ClientException.php

@@ -0,0 +1,13 @@
+<?php
+/**
+ * Copyright 2025 Adobe
+ * All Rights Reserved.
+ */
+declare(strict_types=1);
+
+namespace Magento\AdvancedSearch\Model\Client;
+
+class ClientException extends \Exception
+{
+
+}

app/code/Magento/Backend/Block/Template.php

@@ -80,7 +80,9 @@ public function __construct(
         $this->formKey = $context->getFormKey();
         $this->nameBuilder = $context->getNameBuilder();
         $data['jsonHelper'] = $jsonHelper ?? ObjectManager::getInstance()->get(JsonHelper::class);
-        $data['directoryHelper']= $directoryHelper ?? ObjectManager::getInstance()->get(DirectoryHelper::class);
+        if (empty($data['directoryHelper'])) {
+            $data['directoryHelper'] = $directoryHelper ?? ObjectManager::getInstance()->get(DirectoryHelper::class);
+        }
         parent::__construct($context, $data);
     }
 
@@ -107,6 +109,7 @@ public function getFormKey()
      * not be used in future development. Module design should explicitly state dependencies to avoid requiring output
      * disabling. This functionality will temporarily be kept in Magento core, as there are unresolved modularity
      * issues that will be addressed in future releases.
+     * @see no alternatives
      */
     public function isOutputEnabled($moduleName = null)
     {

app/code/Magento/Backend/Controller/Adminhtml/System/Store/Save.php

@@ -5,6 +5,12 @@
  */
 namespace Magento\Backend\Controller\Adminhtml\System\Store;
 
+use Magento\Backend\App\Action\Context;
+use Magento\Backend\Model\View\Result\ForwardFactory;
+use Magento\Framework\App\Cache\TypeListInterface;
+use Magento\Framework\Filter\FilterManager;
+use Magento\Framework\Registry;
+use Magento\Framework\View\Result\PageFactory;
 use Magento\Framework\App\Action\HttpPostActionInterface as HttpPostActionInterface;
 use Magento\Store\Model\Group as StoreGroup;
 use Magento\Store\Model\Store;
@@ -17,6 +23,32 @@
  */
 class Save extends \Magento\Backend\Controller\Adminhtml\System\Store implements HttpPostActionInterface
 {
+    /**
+     * @var TypeListInterface
+     */
+    private $cacheTypeList;
+
+    /**
+     * Constructor
+     *
+     * @param Context $context
+     * @param Registry $coreRegistry
+     * @param FilterManager $filterManager
+     * @param ForwardFactory $resultForwardFactory
+     * @param PageFactory $resultPageFactory
+     * @param TypeListInterface $cacheTypeList
+     */
+    public function __construct(
+        Context $context,
+        Registry $coreRegistry,
+        FilterManager $filterManager,
+        ForwardFactory $resultForwardFactory,
+        PageFactory $resultPageFactory,
+        TypeListInterface $cacheTypeList,
+    ) {
+        parent::__construct($context, $coreRegistry, $filterManager, $resultForwardFactory, $resultPageFactory);
+        $this->cacheTypeList = $cacheTypeList;
+    }
     /**
      * Process Website model save
      *
@@ -67,6 +99,8 @@ private function processStoreSave($postData)
         if ($postData['store']['store_id']) {
             $storeModel->load($postData['store']['store_id']);
         }
+        $originalCode = $storeModel->getCode();
+        $newCode = $postData['store']['code'] ?? null;
         $storeModel->setData($postData['store']);
         if ($postData['store']['store_id'] == '') {
             $storeModel->setId(null);
@@ -84,7 +118,9 @@ private function processStoreSave($postData)
         }
         $storeModel->save();
         $this->messageManager->addSuccessMessage(__('You saved the store view.'));
-
+        if ($originalCode !== $newCode) {
+            $this->cacheTypeList->cleanType('config');
+        }
         return $postData;
     }
 
@@ -120,7 +156,10 @@ private function processGroupSave($postData)
     }
 
     /**
+     * Saving edited store information
+     *
      * @return \Magento\Backend\Model\View\Result\Redirect
+     *
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
     public function execute()