Skip to content

Commit 7026e95

Browse files
committed
Merge remote-tracking branch 'origin/2.4-develop' into order-convert
2 parents 290f5a6 + ba0b59c commit 7026e95

File tree

11 files changed

+72
-100
lines changed

11 files changed

+72
-100
lines changed

app/code/Magento/Catalog/Test/Mftf/Section/StorefrontCategoryFilterSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@
1010
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
1111
<section name="StorefrontCategoryFilterSection">
1212
<element name="CategoryFilter" type="button" selector="//main//div[contains(@class,'filter-options')]//div[contains(text(), 'Category')]"/>
13-
<element name="CategoryByName" type="button" selector="//main//div[@class='filter-options']//li[@class='item']//a[contains(text(), '{{var1}}')]" parameterized="true"/>
13+
<element name="CategoryByName" type="button" selector="//main//div[contains(@class,'filter-options')]//li[@class='item']//a[contains(text(), '{{var1}}')]" parameterized="true"/>
1414
</section>
1515
</sections>

app/code/Magento/CatalogRule/etc/adminhtml/events.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,7 @@
1212
<event name="catalogrule_dirty_notice">
1313
<observer name="catalogrule" instance="Magento\CatalogRule\Observer\AddDirtyRulesNotice" />
1414
</event>
15+
<event name="prepare_catalog_product_collection_prices">
16+
<observer name="catalogrule" disabled="true" />
17+
</event>
1518
</config>

app/code/Magento/CatalogRule/etc/crontab/events.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,7 @@
99
<event name="catalog_product_get_final_price">
1010
<observer name="catalogrule" instance="Magento\CatalogRule\Observer\ProcessAdminFinalPriceObserver" />
1111
</event>
12+
<event name="prepare_catalog_product_collection_prices">
13+
<observer name="catalogrule" disabled="true" />
14+
</event>
1215
</config>

app/code/Magento/CatalogRule/etc/events.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,10 @@
2121
<event name="magento_catalogrule_api_data_ruleinterface_load_after">
2222
<observer name="legacy_model_load" instance="Magento\Framework\EntityManager\Observer\AfterEntityLoad" />
2323
</event>
24+
<event name="catalog_product_get_final_price">
25+
<observer name="catalogrule" instance="Magento\CatalogRule\Observer\ProcessFrontFinalPriceObserver" />
26+
</event>
27+
<event name="prepare_catalog_product_collection_prices">
28+
<observer name="catalogrule" instance="Magento\CatalogRule\Observer\PrepareCatalogProductCollectionPricesObserver" />
29+
</event>
2430
</config>

app/code/Magento/CatalogRule/etc/frontend/events.xml

Lines changed: 0 additions & 15 deletions
This file was deleted.

app/code/Magento/CatalogRule/etc/webapi_rest/events.xml

Lines changed: 0 additions & 15 deletions
This file was deleted.

app/code/Magento/CatalogRule/etc/webapi_soap/events.xml

Lines changed: 0 additions & 15 deletions
This file was deleted.

app/code/Magento/CatalogRuleGraphQl/etc/graphql/events.xml

Lines changed: 0 additions & 15 deletions
This file was deleted.

app/code/Magento/Ui/view/base/web/js/modal/modal.js

Lines changed: 9 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ define([
1616
'Magento_Ui/js/lib/key-codes',
1717
'jquery-ui-modules/widget',
1818
'jquery-ui-modules/core',
19-
'mage/translate'
19+
'mage/translate',
20+
'jquery/z-index'
2021
], function ($, _, template, popupTpl, slideTpl, customTpl, keyCodes) {
2122
'use strict';
2223

@@ -39,39 +40,7 @@ define([
3940
return transitions[transition];
4041
}
4142
}
42-
})(),
43-
44-
/**
45-
* Implementation of zIndex used from jQuery UI
46-
* @param {Element} elem
47-
* @private
48-
*/
49-
getZIndex = function (elem) {
50-
var position, zIndex;
51-
52-
/* eslint-disable max-depth */
53-
while (elem.length && elem[ 0 ] !== document) {
54-
// Ignore z-index if position is set to a value where z-index is ignored by the browser
55-
// This makes behavior of this function consistent across browsers
56-
// WebKit always returns auto if the element is positioned
57-
position = elem.css('position');
58-
59-
if (position === 'absolute' || position === 'relative' || position === 'fixed') {
60-
// IE returns 0 when zIndex is not specified
61-
// other browsers return a string
62-
// we ignore the case of nested elements with an explicit value of 0
63-
zIndex = parseInt(elem.css('zIndex'), 10);
64-
65-
if (!isNaN(zIndex) && zIndex !== 0) {
66-
return zIndex;
67-
}
68-
}
69-
elem = elem.parent();
70-
}
71-
72-
return 0;
73-
/* eslint-enable max-depth */
74-
};
43+
})();
7544

7645
/**
7746
* Modal Window Widget
@@ -373,17 +342,18 @@ define([
373342
* Set z-index and margin for modal and overlay.
374343
*/
375344
_setActive: function () {
376-
var zIndex = getZIndex(this.modal),
345+
var zIndex = this.modal.zIndex(),
377346
baseIndex = zIndex + this._getVisibleCount();
378347

379348
if (this.modal.data('active')) {
380349
return;
381350
}
351+
382352
this.modal.data('active', true);
383353

384-
this.overlay.css('z-index', ++baseIndex);
385-
this.prevOverlayIndex = baseIndex;
386-
this.modal.css('z-index', baseIndex + 1);
354+
this.overlay.zIndex(++baseIndex);
355+
this.prevOverlayIndex = this.overlay.zIndex();
356+
this.modal.zIndex(this.overlay.zIndex() + 1);
387357

388358
if (this._getVisibleSlideCount()) {
389359
this.modal.css('marginLeft', this.options.modalLeftMargin * this._getVisibleSlideCount());
@@ -398,7 +368,7 @@ define([
398368
this.modal.data('active', false);
399369

400370
if (this.overlay) {
401-
this.overlay.css('z-index', this.prevOverlayIndex - 1);
371+
this.overlay.zIndex(this.prevOverlayIndex - 1);
402372
}
403373
},
404374

dev/tests/unit/phpunit.xml.dist

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@
2828
<testsuite name="Magento_Unit_Tests_App_Code">
2929
<directory>../../../app/code/*/*/Test/Unit</directory>
3030
<directory>../../../vendor/magento/module-*/Test/Unit</directory>
31+
<exclude>../../../app/code/Magento/Indexer/Test/Unit</exclude>
32+
</testsuite>
33+
<testsuite name="Magento_Unit_Tests_App_Code_Indexer">
34+
<directory>../../../app/code/Magento/Indexer/Test/Unit</directory>
3135
</testsuite>
3236
<testsuite name="Magento_Unit_Tests_Other">
3337
<directory>../../../lib/internal/*/*/Test/Unit</directory>

0 commit comments

Comments
 (0)