magento2-login-as-customer/issues/90: Tests stabilization

Author: naydav

app/code/Magento/LoginAsCustomerUi/view/adminhtml/web/css/source/_module.less

@@ -7,7 +7,8 @@
 //  Variables
 //  ---------------------------------------------
 
-@lac-confirm-background-color: #ccc;
+@lac-confirm-popup-title-background-color: #ccc;
+@lac-confirm-popup-content-color: #514943;
 
 //
 //  Common
@@ -19,7 +20,7 @@
             max-width: 55rem;
         }
         .modal-title {
-            border-bottom: 1px solid @lac-confirm-background-color;
+            border-bottom: 1px solid @lac-confirm-popup-title-background-color;
             padding-bottom: 15px;
             width: 100%;
         }
@@ -32,7 +33,7 @@
             .message-warning {
                 padding-left: 4.5rem;
                 &:before {
-                    color: #514943;
+                    color: @lac-confirm-popup-content-color;
                     left: 5px;
                 }
             }

app/code/Magento/LoginAsCustomerUi/view/adminhtml/web/js/confirmation-popup.js

@@ -3,91 +3,90 @@
  * See COPYING.txt for license details.
  */
 
-'use strict';
+define([
+    'uiComponent',
+    'Magento_Ui/js/modal/confirm',
+    'jquery',
+    'ko',
+    'mage/translate',
+    'mage/template',
+    'text!Magento_LoginAsCustomerUi/template/confirmation-popup/store-view-ptions.html'
+], function (Component, confirm, $, ko, $t, template, selectTpl) {
 
-define(
-    [
-        'uiComponent',
-        'Magento_Ui/js/modal/confirm',
-        'jquery',
-        'ko',
-        'mage/translate',
-        'mage/template',
-        'text!Magento_LoginAsCustomerUi/template/confirmation-popup/store-view-ptions.html'
-    ],
-    function (Component, confirm, $, ko, $t, template, selectTpl, undefined) {
+    'use strict';
 
-        return Component.extend({
-            /**
-             * Initialize Component
-             */
-            initialize: function () {
-                this._super();
-                var self = this,
-                    content = '<div class="message message-warning">' + self.content + '</div>';
+    return Component.extend({
+        /**
+         * Initialize Component
+         */
+        initialize: function () {
+            var self = this,
+                content = '<div class="message message-warning">' + self.content + '</div>';
 
-                if (self.showStoreViewOptions) {
-                    content = template(
-                        selectTpl,
-                        {
-                            data: {
-                                showStoreViewOptions: self.showStoreViewOptions,
-                                storeViewOptions: self.storeViewOptions,
-                                label: $t('Store View')
-                            }
-                        }) + content;
-                }
+            this._super();
 
-                /**
-                 * Confirmation popup
-                 *
-                 * @param {String} url
-                 * @returns {Boolean}
-                 */
-                window.lacConfirmationPopup = function (url) {
-                    confirm({
-                        title: self.title,
-                        content: content,
-                        modalClass: 'confirm lac-confirm',
-                        actions: {
-                            /**
-                             * Confirm action.
-                             */
-                            confirm: function () {
-                                var storeId = $('#lac-confirmation-popup-store-id').val();
+            if (self.showStoreViewOptions) {
+                content = template(
+                    selectTpl,
+                    {
+                        data: {
+                            showStoreViewOptions: self.showStoreViewOptions,
+                            storeViewOptions: self.storeViewOptions,
+                            label: $t('Store View')
+                        }
+                    }) + content;
+            }
 
-                                if (storeId) {
-                                    url += ((url.indexOf('?') == -1) ? '?' : '&') + 'store_id=' + storeId;
-                                }
-                                window.open(url);
-                            }
-                        },
-                        buttons: [{
-                            text: $t('Cancel'),
-                            class: 'action-secondary action-dismiss',
+            /**
+             * Confirmation popup
+             *
+             * @param {String} url
+             * @returns {Boolean}
+             */
+            window.lacConfirmationPopup = function (url) {
+                confirm({
+                    title: self.title,
+                    content: content,
+                    modalClass: 'confirm lac-confirm',
+                    actions: {
+                        /**
+                         * Confirm action.
+                         */
+                        confirm: function () {
+                            var storeId = $('#lac-confirmation-popup-store-id').val();
 
-                            /**
-                             * Click handler.
-                             */
-                            click: function (event) {
-                                this.closeModal(event);
+                            if (storeId) {
+                                url += url.indexOf('?') === -1 ? '?' : '&';
+                                url += 'store_id=' + storeId;
                             }
-                        }, {
-                            text: $t('Login as Customer'),
-                            class: 'action-primary action-accept',
+                            window.open(url);
+                        }
+                    },
+                    buttons: [{
+                        text: $t('Cancel'),
+                        class: 'action-secondary action-dismiss',
 
-                            /**
-                             * Click handler.
-                             */
-                            click: function (event) {
-                                this.closeModal(event, true);
-                            }
-                        }]
-                    });
+                        /**
+                         * Click handler.
+                         */
+                        click: function (event) {
+                            this.closeModal(event);
+                        }
+                    }, {
+                        text: $t('Login as Customer'),
+                        class: 'action-primary action-accept',
 
-                    return false;
-                };
-            }
-        });
-    }
-);
+                        /**
+                         * Click handler.
+                         */
+                        click: function (event) {
+                            this.closeModal(event, true);
+                        }
+                    }]
+                });
+
+                return false;
+            };
+        }
+    });
+});