MAGETWO-91589: Slow query delete on sub SELECT query

- Fix static tests

Author: vprohorov

app/code/Magento/CatalogUrlRewrite/Model/ResourceModel/Category/Product.php

@@ -3,6 +3,9 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
+declare(strict_types=1);
+
 namespace Magento\CatalogUrlRewrite\Model\ResourceModel\Category;
 
 use Magento\Framework\Model\ResourceModel\Db\AbstractDb;
@@ -49,7 +52,7 @@ protected function _construct()
     public function saveMultiple(array $insertData)
     {
         $connection = $this->getConnection();
-        if (sizeof($insertData) <= self::CHUNK_SIZE) {
+        if (count($insertData) <= self::CHUNK_SIZE) {
             return $connection->insertMultiple($this->getTable(self::TABLE_NAME), $insertData);
         }
         $data = array_chunk($insertData, self::CHUNK_SIZE);
@@ -86,7 +89,7 @@ public function removeMultiple(array $removeData)
      */
     public function removeMultipleByProductCategory(array $filter)
     {
-        return $this->getConnection()->deleteFromSelect($this->prepareJoin($filter), self::TABLE_NAME);
+        return $this->getConnection()->deleteFromSelect($this->prepareSelect($filter), self::TABLE_NAME);
     }
 
     /**
@@ -95,7 +98,7 @@ public function removeMultipleByProductCategory(array $filter)
      * @param array $data
      * @return \Magento\Framework\DB\Select
      */
-    private function prepareJoin($data)
+    private function prepareSelect($data)
     {
         $select = $this->getConnection()->select();
         $select->from(DbStorage::TABLE_NAME);
@@ -108,21 +111,4 @@ private function prepareJoin($data)
         }
         return $select;
     }
-
-    /**
-     * Prepare select statement for specific filter
-     *
-     * @param array $data
-     * @return \Magento\Framework\DB\Select
-     */
-    private function prepareSelect($data)
-    {
-        $select = $this->getConnection()->select();
-        $select->from($this->getTable(DbStorage::TABLE_NAME), 'url_rewrite_id');
-
-        foreach ($data as $column => $value) {
-            $select->where($this->getConnection()->quoteIdentifier($column) . ' IN (?)', $value);
-        }
-        return $select;
-    }
 }