ENGCOM-8814: catalog_product_entity_media_gallery not cleared when related products deleted. #32273

Author: gabrieldagama

app/code/Magento/Catalog/Plugin/RemoveImagesFromGalleryAfterRemovingProduct.php

@@ -0,0 +1,66 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+declare(strict_types=1);
+
+namespace Magento\Catalog\Plugin;
+
+use Magento\Catalog\Api\Data\ProductInterface;
+use Magento\Catalog\Api\ProductRepositoryInterface;
+use Magento\Catalog\Model\Product\Gallery\ReadHandler;
+use Magento\Catalog\Model\ResourceModel\Product\Gallery;
+
+/**
+ * Responsible for deleting images from media gallery after deleting product
+ */
+class RemoveImagesFromGalleryAfterRemovingProduct
+{
+    /**
+     * @var Gallery
+     */
+    private $galleryResource;
+
+    /**
+     * @var ReadHandler
+     */
+    private $mediaGalleryReadHandler;
+
+    /**
+     * @param Gallery $galleryResource
+     * @param ReadHandler $mediaGalleryReadHandler
+     */
+    public function __construct(Gallery $galleryResource, ReadHandler $mediaGalleryReadHandler)
+    {
+        $this->galleryResource = $galleryResource;
+        $this->mediaGalleryReadHandler = $mediaGalleryReadHandler;
+    }
+
+    /**
+     * Delete media gallery after deleting product
+     *
+     * @param ProductRepositoryInterface $subject
+     * @param callable $proceed
+     * @param ProductInterface $product
+     * @return bool
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
+    public function aroundDelete(
+        ProductRepositoryInterface $subject,
+        callable $proceed,
+        ProductInterface $product
+    ): bool {
+        $mediaGalleryAttributeId = $this->mediaGalleryReadHandler->getAttribute()->getAttributeId();
+        $mediaGallery = $this->galleryResource->loadProductGalleryByAttributeId($product, $mediaGalleryAttributeId);
+
+        $result = $proceed($product);
+
+        if ($mediaGallery) {
+            $this->galleryResource->deleteGallery(array_column($mediaGallery, 'value_id'));
+        }
+
+        return $result;
+    }
+}

app/code/Magento/Catalog/etc/di.xml

@@ -1319,4 +1319,8 @@
             </argument>
         </arguments>
     </type>
+    <type name="Magento\Catalog\Api\ProductRepositoryInterface">
+        <plugin name="remove_images_from_gallery_after_removing_product"
+                type="Magento\Catalog\Plugin\RemoveImagesFromGalleryAfterRemovingProduct"/>
+    </type>
 </config>

dev/tests/integration/testsuite/Magento/Catalog/Model/ResourceModel/Product/GalleryTest.php

@@ -0,0 +1,93 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\Catalog\Model\ResourceModel\Product;
+
+use Magento\Catalog\Api\ProductRepositoryInterface;
+use Magento\Catalog\Model\Product\Gallery\ReadHandler;
+use Magento\TestFramework\Helper\Bootstrap;
+use PHPUnit\Framework\TestCase;
+use Magento\Framework\App\ResourceConnection;
+
+/**
+ * Test for \Magento\Catalog\Model\ResourceModel\Product\Gallery.
+ *
+ * @magentoAppArea adminhtml
+ */
+class GalleryTest extends TestCase
+{
+    /**
+     * @var Gallery
+     */
+    private $galleryResource;
+
+    /**
+     * @var ProductRepositoryInterface
+     */
+    private $productRepository;
+
+    /**
+     * @var ResourceConnection
+     */
+    private $resource;
+
+    /**
+     * @var ReadHandler
+     */
+    private $readHandler;
+
+    /**
+     * @inheritDoc
+     */
+    protected function setUp(): void
+    {
+        $objectManager = Bootstrap::getObjectManager();
+
+        $this->productRepository = $objectManager->create(ProductRepositoryInterface::class);
+        $this->galleryResource = $objectManager->create(Gallery::class);
+        $this->resource = $objectManager->create(ResourceConnection::class);
+        $this->readHandler = $objectManager->create(ReadHandler::class);
+    }
+
+    /**
+     * Verify catalog_product_entity_media_gallery table will not have data after deleting the product
+     *
+     * @magentoDataFixture Magento/Catalog/_files/product_with_image.php
+     * @magentoDbIsolation disabled
+     *
+     * @return void
+     */
+    public function testDeleteProductWithImage(): void
+    {
+        $product = $this->productRepository->get('simple');
+
+        $attributeId = $this->readHandler->getAttribute()->getAttributeId();
+        $mediaGalleryData = $this->galleryResource->loadProductGalleryByAttributeId($product, $attributeId);
+        $values = array_column($mediaGalleryData, 'value_id');
+        $this->assertNotEmpty($this->getMediaGalleryDataByValues($values));
+
+        $this->productRepository->delete($product);
+
+        $this->assertEmpty($this->getMediaGalleryDataByValues($values));
+    }
+
+    /**
+     * Return data from catalog_product_entity_media_gallery_values table
+     *
+     * @param array $values
+     * @return array
+     */
+    private function getMediaGalleryDataByValues(array $values): array
+    {
+        $connection = $this->resource->getConnection();
+        $select = $connection->select()
+            ->from($this->resource->getTableName(Gallery::GALLERY_TABLE))
+            ->where('value_id IN (?)', $values);
+
+        return $connection->fetchAll($select);
+    }
+}