Skip to content

Commit 758fac9

Browse files
committed
AC-8379: Functional test fixes
1 parent a0d39c5 commit 758fac9

8 files changed

+17
-15
lines changed

app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminCreateCatalogProductWidgetActionGroup.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
<click selector="{{AdminNewWidgetSection.selectCategory}}" stepKey="clickOnSelectCategory"/>
2121
<waitForPageLoad stepKey="waitForCategoryTreeLoaded"/>
2222
<click selector="{{AdminCategorySidebarTreeSection.expandRootCategoryByName(DefaultCategory.name)}}" stepKey="clickToExpandDefaultCategory"/>
23-
<waitForElementVisible selector="{{AdminCategorySidebarTreeSection.categoryInTree(categoryName)}}" stepKey="waitForCategoryVisible"/>
24-
<click selector="{{AdminCategorySidebarTreeSection.categoryInTree(categoryName)}}" stepKey="selectCategory"/>
23+
<waitForElementVisible selector="{{WidgetSection.PreSelectCategory(categoryName)}}" stepKey="waitForCategoryVisible"/>
24+
<click selector="{{WidgetSection.PreSelectCategory(categoryName)}}" stepKey="selectCategory"/>
2525
<waitForPageLoad stepKey="waitForWidgetPageLoaded"/>
2626
<click selector="{{AdminMainActionsSection.save}}" stepKey="clickSaveButton"/>
2727
<waitForElementVisible selector="{{AdminMessagesSection.success}}" stepKey="waitForSuccessMessage"/>

app/code/Magento/Catalog/Test/Mftf/Section/AdminCategorySidebarTreeSection.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@
2020
<element name="lastCreatedCategory" type="block" selector=".x-tree-root-ct li li:last-child" />
2121
<element name="treeContainer" type="block" selector=".tree-holder" />
2222
<element name="expandRootCategory" type="text" selector="img.x-tree-elbow-end-plus"/>
23-
<element name="expandRootCategoryByName" type="button" selector="//div[@class='x-tree-root-node']/li/div/a/span[contains(., '{{categoryName}}')]/../../img[contains(@class, 'x-tree-elbow-end-plus')]" parameterized="true" timeout="30"/>
23+
<element name="expandRootCategoryByName" type="button" selector="//a[contains(text(),'{{categoryName}}')]/ancestor::li[contains(@class,'jstree-node')]//i[contains(@class,'jstree-ocl')]" parameterized="true" timeout="30"/>
2424
<element name="categoryByName" type="text" selector="//div[contains(@class, 'categories-side-col')]//a/span[contains(text(), '{{categoryName}}')]" parameterized="true" timeout="30"/>
25-
<element name="expandCategoryByName" type="text" selector="//span[contains(text(),'{{categoryName}}')]/ancestor::div[contains(@class,'x-tree-node-el')]//img[contains(@class,'x-tree-elbow-end-plus') or contains(@class,'x-tree-elbow-plus')]" parameterized="true" timeout="30"/>
25+
<element name="expandCategoryByName" type="text" selector="//a[contains(text(),'{{categoryName}}')]/ancestor::li[contains(@class,'jstree-node')]//i[contains(@class,'jstree-ocl')]" parameterized="true" timeout="30"/>
2626
<element name="subCategoryProductCount" type="text" selector="//div[@class='tree-holder']//span[contains(text(),'SubCat') and contains(text(),'({{productCount}})')]" parameterized="true"/>
2727
<element name="defaultCategoryProductCount" type="text" selector="//div[@class='tree-holder']//span[contains(text(),'Default Category') and contains(text(),'({{productCount}})')]" parameterized="true"/>
2828
</section>

app/code/Magento/Cms/Test/Mftf/ActionGroup/AdminUpdateWidgetsOfCatalogCategoryLinkActionGroup.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
<click selector="{{CmsNewWidgetOptionsSection.SelectCategory}}" stepKey="clickSelectCategoryButton1"/>
2323
<waitForPageLoad stepKey="waitToLoadRootCategory"/>
2424
<click selector="{{CmsNewWidgetOptionsSection.ExpandRootCategory}}" stepKey="clickToExpandRootCat"/>
25+
<waitForPageLoad stepKey="waitToExpandRootCategory"/>
2526
<click selector="{{CmsNewWidgetOptionsSection.SecondCategory}}" stepKey="clickSecondCategoryToSelect"/>
2627
<waitForPageLoad stepKey="waitToSelectSecondCategory"/>
2728
<click selector="{{CmsNewWidgetOptionsSection.SaveWidget}}" stepKey="clickSaveWidgetButton"/>

app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection/CmsNewWidgetOptionsSection.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
<element name="SecondProduct" type="text" selector="//div[@class='admin__data-grid-wrap admin__data-grid-wrap-static']//tbody/tr[2]"/>
1717
<element name="SaveWidget" type="button" selector="//button[@id='save']"/>
1818
<element name="FirstWidget" type="text" selector="//tbody/tr[1]/td[3]"/>
19-
<element name="ExpandRootCategory" type="button" selector="//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']"/>
20-
<element name="FirstCategory" type="text" selector="//Span[contains(text(),'simpleCategory')]"/>
21-
<element name="SecondCategory" type="text" selector="//Span[contains(text(),'CategoryB')]"/>
19+
<element name="ExpandRootCategory" type="button" selector="//li[contains(@class,'jstree-node jstree-closed')]//i[contains(@class,'jstree-icon jstree-ocl')]"/>
20+
<element name="FirstCategory" type="text" selector="//a[contains(text(),'simpleCategory')]/../..//a"/>
21+
<element name="SecondCategory" type="text" selector="//a[contains(text(),'CategoryB')]"/>
2222
</section>
2323
</sections>
2424

app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection/CmsNewWidgetUpdateLayoutSection.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<element name="Template" type="button" selector="#all_pages_0 > table > tbody > tr > td:nth-child(2) > div > div > select"/>
1515
<element name="SpecificCategories" type="button" selector="//input[@id='specific_anchor_categories_0']"/>
1616
<element name="CategoryChooserButton" type="button" selector="//*[@id='anchor_categories_ids_0']/p/a[1]/img"/>
17-
<element name="BranchCat" type="button" selector="//a/span[contains(text(),'{{var}}')]/../..//img[@class='x-tree-ec-icon x-tree-elbow-end-plus']" parameterized="true"/>
18-
<element name="CountAllNestedCat" type="button" selector="//*[@class='x-tree-ec-icon x-tree-elbow-end-minus' or @class='x-tree-ec-icon x-tree-elbow-end']"/>
17+
<element name="BranchCat" type="button" selector="//a[contains(text(),'{{var}}')]/..//i[contains(@class,'jstree-ocl')]" parameterized="true"/>
18+
<element name="CountAllNestedCat" type="button" selector="//*[@class='jstree-node jstree-last jstree-open' or @class='jstree-node jstree-leaf jstree-last']//*[@class='jstree-icon jstree-ocl']"/>
1919
</section>
2020
</sections>

app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection/WidgetSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
<element name="CMSPage" type="text" selector="//td[contains(text(),'Home page')]"/>
2626
<element name="BlockPage" type="text" selector="//td[contains(text(),'{{var1}}')]" parameterized="true"/>
2727
<element name="PreCreateCategory" type="text" selector=" //span[contains(text(),'{{var1}}')]" parameterized="true"/>
28+
<element name="PreSelectCategory" type="text" selector=" //a[contains(text(),'{{var1}}')]" parameterized="true"/>
2829
<element name="PreCreateProduct" type="text" selector="//td[contains(text(),'{{var1}}')]" parameterized="true"/>
2930
<element name="NoOfProductToDisplay" type="input" selector="input[data-ui-id='wysiwyg-widget-options-fieldset-element-text-parameters-products-count']"/>
3031
<element name="AddParam" type="button" selector=".rule-param-add"/>

app/code/Magento/Cms/Test/Mftf/Test/AdminAddWidgetToWYSIWYGWithCatalogCategoryLinkTypeTest.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@
4646
<click selector="{{WidgetSection.BtnChooser}}" stepKey="clickSelectCategoryBtn" />
4747
<waitForPageLoad stepKey="wait3"/>
4848
<waitForElementVisible selector="{{AdminCategorySidebarTreeSection.expandCategoryByName('Default Category')}}" stepKey="waitForDefaultCategory"/>
49-
<conditionalClick selector="{{AdminCategorySidebarTreeSection.expandCategoryByName('Default Category')}}" dependentSelector="{{WidgetSection.PreCreateCategory('$$createPreReqCategory.name$$')}}" visible="false" stepKey="expandRootCategory"/>
50-
<waitForElementVisible selector="{{WidgetSection.PreCreateCategory('$$createPreReqCategory.name$$')}}" stepKey="expandWait" />
51-
<click selector="{{WidgetSection.PreCreateCategory('$$createPreReqCategory.name$$')}}" stepKey="selectPreCreateCategory" />
49+
<conditionalClick selector="{{AdminCategorySidebarTreeSection.expandCategoryByName('Default Category')}}" dependentSelector="{{WidgetSection.PreSelectCategory('$$createPreReqCategory.name$$')}}" visible="false" stepKey="expandRootCategory"/>
50+
<waitForElementVisible selector="{{WidgetSection.PreSelectCategory('$$createPreReqCategory.name$$')}}" stepKey="expandWait" />
51+
<click selector="{{WidgetSection.PreSelectCategory('$$createPreReqCategory.name$$')}}" stepKey="selectPreCreateCategory" />
5252
<waitForElementNotVisible selector="{{WidgetSection.SelectCategoryTitle}}" stepKey="waitForSlideoutCloses1" />
5353
<actionGroup ref="AdminClickInsertWidgetActionGroup" stepKey="clickInsertWidget"/>
5454
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForSlideOutCloses2"/>

app/code/Magento/Cms/Test/Mftf/Test/AdminAddWidgetToWYSIWYGWithCatalogProductLinkTypeTest.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@
5050
<click selector="{{WidgetSection.BtnChooser}}" stepKey="clickSelectPageBtn" />
5151
<waitForPageLoad stepKey="wait4"/>
5252
<waitForElementVisible selector="{{AdminCategorySidebarTreeSection.expandCategoryByName('Default Category')}}" stepKey="waitForDefaultCategory"/>
53-
<conditionalClick selector="{{AdminCategorySidebarTreeSection.expandCategoryByName('Default Category')}}" dependentSelector="{{WidgetSection.PreCreateCategory('$$createPreReqCategory.name$$')}}" visible="false" stepKey="expandRootCategory"/>
54-
<waitForElementVisible selector="{{WidgetSection.PreCreateCategory('$$createPreReqCategory.name$$')}}" stepKey="expandWait" />
55-
<click selector="{{WidgetSection.PreCreateCategory('$$createPreReqCategory.name$$')}}" stepKey="selectPreCategory" />
53+
<conditionalClick selector="{{AdminCategorySidebarTreeSection.expandCategoryByName('Default Category')}}" dependentSelector="{{WidgetSection.PreSelectCategory('$$createPreReqCategory.name$$')}}" visible="false" stepKey="expandRootCategory"/>
54+
<waitForElementVisible selector="{{WidgetSection.PreSelectCategory('$$createPreReqCategory.name$$')}}" stepKey="expandWait" />
55+
<click selector="{{WidgetSection.PreSelectCategory('$$createPreReqCategory.name$$')}}" stepKey="selectPreCategory" />
5656
<waitForLoadingMaskToDisappear stepKey="waitLoadingMask" />
5757
<click selector="{{WidgetSection.PreCreateProduct('$$createPreReqProduct.name$$')}}" stepKey="selectPreProduct" />
5858
<waitForElementNotVisible selector="{{WidgetSection.SelectProductTitle}}" stepKey="waitForSlideOutCloses" />

0 commit comments

Comments
 (0)