Skip to content

Commit 771d908

Browse files
author
Vadim Zubovich
committed
Merge branch 'develop' into PR2
# Conflicts: # dev/tests/integration/testsuite/Magento/Customer/Controller/Adminhtml/IndexTest.php
2 parents 02c0bf8 + 22cbf56 commit 771d908

File tree

546 files changed

+20674
-4475
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

546 files changed

+20674
-4475
lines changed

.htaccess

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -243,10 +243,6 @@
243243
order allow,deny
244244
deny from all
245245
</Files>
246-
<Files CONTRIBUTOR_LICENSE_AGREEMENT.html>
247-
order allow,deny
248-
deny from all
249-
</Files>
250246
<Files COPYING.txt>
251247
order allow,deny
252248
deny from all

.htaccess.sample

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -209,10 +209,6 @@
209209
order allow,deny
210210
deny from all
211211
</Files>
212-
<Files CONTRIBUTOR_LICENSE_AGREEMENT.html>
213-
order allow,deny
214-
deny from all
215-
</Files>
216212
<Files COPYING.txt>
217213
order allow,deny
218214
deny from all

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ The Magento 2 development team will review all issues and contributions submitte
1010

1111
## Contribution requirements
1212

13-
1. Contributions must adhere to [Magento coding standards](http://devdocs.magento.com/guides/v1.0/coding-standards/bk-coding-standards.html).
13+
1. Contributions must adhere to [Magento coding standards](http://devdocs.magento.com/guides/v2.0/coding-standards/bk-coding-standards.html).
1414
2. Pull requests (PRs) must be accompanied by a meaningful description of their purpose. Comprehensive descriptions increase the chances of a pull request to be merged quickly and without additional clarification requests.
1515
3. Commits must be accompanied by meaningful commit messages.
1616
4. PRs which include bug fixing, must be accompanied with step-by-step description of how to reproduce the bug.
@@ -25,7 +25,7 @@ The Magento 2 development team will review all issues and contributions submitte
2525
If you are a new GitHub user, we recommend that you create your own [free github account](https://github.com/signup/free). By doing that, you will be able to collaborate with the Magento 2 development team, “fork” the Magento 2 project and be able to easily send “pull requests”.
2626

2727
1. Search current [listed issues](https://github.com/magento/magento2/issues) (open or closed) for similar proposals of intended contribution before starting work on a new contribution.
28-
2. Review the [Contributor License Agreement](https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html) if this is your first time contributing.
28+
2. Review the [Contributor License Agreement](https://magento.com/legaldocuments/mca) if this is your first time contributing.
2929
3. Create and test your work.
30-
4. Fork the Magento 2 repository according to [Fork a repository instructions](http://devdocs.magento.com/guides/v1.0/contributor-guide/CONTRIBUTING.html#fork) and when you are ready to send us a pull request – follow [Create a pull request instructions](http://devdocs.magento.com/guides/v1.0/contributor-guide/CONTRIBUTING.html#pull_request).
30+
4. Fork the Magento 2 repository according to [Fork a repository instructions](http://devdocs.magento.com/guides/v2.0/contributor-guide/contributing.html#fork) and when you are ready to send us a pull request – follow [Create a pull request instructions](http://devdocs.magento.com/guides/v2.0/contributor-guide/contributing.html#pull_request).
3131
5. Once your contribution is received, Magento 2 development team will review the contribution and collaborate with you as needed to improve the quality of the contribution.

CONTRIBUTOR_LICENSE_AGREEMENT.html

Lines changed: 0 additions & 137 deletions
This file was deleted.

app/code/Magento/Authorizenet/view/adminhtml/web/js/direct-post.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ directPost.prototype = {
2020
var prepare = function (event, method) {
2121
if (method === 'authorizenet_directpost') {
2222
this.preparePayment();
23+
} else {
24+
jQuery('#edit_form')
25+
.off('submitOrder.authorizenet');
2326
}
2427
};
2528
this.iframeId = iframeId;
@@ -76,7 +79,7 @@ directPost.prototype = {
7679
this.changeInputOptions('autocomplete', 'off');
7780
jQuery('#edit_form')
7881
.off('submitOrder')
79-
.on('submitOrder', this.submitAdminOrder.bind(this));
82+
.on('submitOrder.authorizenet', this.submitAdminOrder.bind(this));
8083
if ($(this.iframeId)) {
8184
// Temporary solution will be removed after refactoring Authorize.Net (sales) functionality
8285
jQuery('.scalable.save:not(disabled)').removeAttr('onclick');

app/code/Magento/Backend/App/AbstractAction.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ public function __construct(Action\Context $context)
102102
*/
103103
protected function _isAllowed()
104104
{
105-
return $this->_authorization->isAllowed(self::ADMIN_RESOURCE);
105+
return $this->_authorization->isAllowed(static::ADMIN_RESOURCE);
106106
}
107107

108108
/**

app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Longtext.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public function render(\Magento\Framework\DataObject $row)
3030
$truncateLength = $this->getColumn()->getTruncate();
3131
}
3232
$text = $this->filterManager->truncate(parent::_getValue($row), ['length' => $truncateLength]);
33-
if ($this->getColumn()->getEscape()) {
33+
if (!$this->getColumn()->hasEscape() || $this->getColumn()->getEscape()) {
3434
$text = $this->escapeHtml($text);
3535
}
3636
if ($this->getColumn()->getNl2br()) {

app/code/Magento/BraintreeTwo/Block/Adminhtml/Form/Field/Cctypes.php renamed to app/code/Magento/BraintreeTwo/Block/Adminhtml/Form/Field/CcTypes.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,25 +5,25 @@
55
*/
66
namespace Magento\BraintreeTwo\Block\Adminhtml\Form\Field;
77

8+
use Magento\BraintreeTwo\Helper\CcType;
89
use Magento\Framework\View\Element\Context;
910
use Magento\Framework\View\Element\Html\Select;
10-
use Magento\BraintreeTwo\Helper\CcType;
1111

1212
/**
13-
* Class Cctypes
13+
* Class CcTypes
1414
*/
15-
class Cctypes extends Select
15+
class CcTypes extends Select
1616
{
1717
/**
18-
* @var \
18+
* @var CcType
1919
*/
2020
private $ccTypeHelper;
2121

2222
/**
2323
* Constructor
2424
*
25-
* @param \Magento\Framework\View\Element\Context $context
26-
* @param \Magento\BraintreeTwo\Helper\CcType $ccTypeHelper
25+
* @param Context $context
26+
* @param CcType $ccTypeHelper
2727
* @param array $data
2828
*/
2929
public function __construct(

app/code/Magento/BraintreeTwo/Block/Adminhtml/Form/Field/Countries.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@
1515
class Countries extends Select
1616
{
1717
/**
18-
* @var \Magento\BraintreeTwo\Helper\Country
18+
* @var Country
1919
*/
2020
private $countryHelper;
2121

2222
/**
2323
* Constructor
2424
*
25-
* @param \Magento\Framework\View\Element\Context $context
26-
* @param \Magento\BraintreeTwo\Helper\Country $countryHelper
25+
* @param Context $context
26+
* @param Country $countryHelper
2727
* @param array $data
2828
*/
2929
public function __construct(Context $context, Country $countryHelper, array $data = [])

app/code/Magento/BraintreeTwo/Block/Adminhtml/Form/Field/CountryCreditCard.php

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,28 +5,28 @@
55
*/
66
namespace Magento\BraintreeTwo\Block\Adminhtml\Form\Field;
77

8-
use Magento\Config\Block\System\Config\Form\Field\FieldArray\AbstractFieldArray;
98
use Magento\Framework\DataObject;
9+
use Magento\Config\Block\System\Config\Form\Field\FieldArray\AbstractFieldArray;
1010

1111
/**
1212
* Class CountryCreditCard
1313
*/
1414
class CountryCreditCard extends AbstractFieldArray
1515
{
1616
/**
17-
* @var \Magento\BraintreeTwo\Block\Adminhtml\Form\Field\Countries
17+
* @var Countries
1818
*/
1919
protected $countryRenderer = null;
2020

2121
/**
22-
* @var \Magento\BraintreeTwo\Block\Adminhtml\Form\Field\CcTypes
22+
* @var CcTypes
2323
*/
2424
protected $ccTypesRenderer = null;
2525

2626
/**
2727
* Returns renderer for country element
2828
*
29-
* @return \Magento\BraintreeTwo\Block\Adminhtml\Form\Field\Countries
29+
* @return Countries
3030
*/
3131
protected function getCountryRenderer()
3232
{
@@ -43,13 +43,13 @@ protected function getCountryRenderer()
4343
/**
4444
* Returns renderer for country element
4545
*
46-
* @return \Magento\BraintreeTwo\Block\Adminhtml\Form\Field\Cctypes
46+
* @return CcTypes
4747
*/
4848
protected function getCcTypesRenderer()
4949
{
5050
if (!$this->ccTypesRenderer) {
5151
$this->ccTypesRenderer = $this->getLayout()->createBlock(
52-
Cctypes::class,
52+
CcTypes::class,
5353
'',
5454
['data' => ['is_render_to_js_template' => true]]
5555
);
@@ -84,7 +84,7 @@ protected function _prepareToRender()
8484
/**
8585
* Prepare existing row data object
8686
*
87-
* @param \Magento\Framework\DataObject $row
87+
* @param DataObject $row
8888
* @return void
8989
*/
9090
protected function _prepareArrayRow(DataObject $row)
@@ -102,6 +102,5 @@ protected function _prepareArrayRow(DataObject $row)
102102
}
103103
}
104104
$row->setData('option_extra_attrs', $options);
105-
return;
106105
}
107106
}

0 commit comments

Comments
 (0)