ACP2E-1650:Create Shipment API

- added validation for create shipment API call when order contains bundle products

Author: aplapana

app/code/Magento/Bundle/Model/Sales/Order/BundleOrderTypeValidator.php

@@ -1,11 +1,19 @@
 <?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
 
 namespace Magento\Bundle\Model\Sales\Order;
 
 use Magento\Bundle\Model\Sales\Order\Shipment\BundleShipmentTypeValidator;
 use \Laminas\Validator\ValidatorInterface;
 use Magento\Sales\Model\Order\Shipment;
 
+/**
+ * Validate if requested order items can be shipped according to bundle product shipment type
+ */
 class BundleOrderTypeValidator extends BundleShipmentTypeValidator implements ValidatorInterface
 {
     /**
@@ -14,6 +22,8 @@ class BundleOrderTypeValidator extends BundleShipmentTypeValidator implements Va
     private array $messages = [];
 
     /**
+     * Validates shipment items based on order item properties
+     *
      * @param Shipment $value
      * @return bool
      * @throws \Magento\Framework\Exception\NoSuchEntityException
@@ -24,7 +34,9 @@ public function isValid($value): bool
         foreach ($value->getOrder()->getAllItems() as $orderItem) {
             foreach ($value->getItems() as $shipmentItem) {
                 if ($orderItem->getItemId() == $shipmentItem->getOrderItemId()) {
-                    $this->messages = array_merge($this->messages, $this->validate($orderItem));
+                    if ($result = $this->validate($orderItem)) {
+                        $this->messages[] = $result;
+                    }
                 }
             }
         }
@@ -33,6 +45,8 @@ public function isValid($value): bool
     }
 
     /**
+     * Returns validation messages
+     *
      * @return array|string[]
      */
     public function getMessages(): array

lib/internal/Magento/Framework/Model/AbstractModel.php

@@ -779,7 +779,7 @@ protected function _createValidatorBeforeSave()
     /**
      * @return ValidatorChain
      */
-    protected function getValidator(): ValidatorChain
+    private function getValidator(): ValidatorChain
     {
         return \Magento\Framework\App\ObjectManager::getInstance()->create(ValidatorChain::class);
     }