return changes and add additional interface for CategoryLinkRepository

Author: sarron93

app/code/Magento/Catalog/Api/CategoryLinkRepositoryInterface.php

@@ -37,10 +37,10 @@ public function save(\Magento\Catalog\Api\Data\CategoryProductLinkInterface $pro
     public function delete(\Magento\Catalog\Api\Data\CategoryProductLinkInterface $productLink);
 
     /**
-     * Remove the product assignment from the category by category id and array or string of sku
+     * Remove the product assignment from the category by category id and sku
      *
      * @param int $categoryId
-     * @param string|array $sku
+     * @param string $sku
      * @return bool will returned True if products successfully deleted
      *
      * @throws \Magento\Framework\Exception\CouldNotSaveException

app/code/Magento/Catalog/Api/CategoryListRepositoryAdditionalInterface.php

@@ -0,0 +1,26 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Catalog\Api;
+
+/**
+ * @api
+ * @since 100.0.2
+ */
+interface CategoryListRepositoryAdditionalInterface
+{
+    /**
+     * delete by skus list
+     *
+     * @param int   $categoryId
+     * @param array $productSkuList
+     * @return bool
+     *
+     * @throws \Magento\Framework\Exception\CouldNotSaveException
+     * @throws \Magento\Framework\Exception\InputException
+     */
+    public function deleteBySkus($categoryId, array $productSkuList);
+}

app/code/Magento/Catalog/Model/CategoryLinkRepository.php

@@ -9,7 +9,8 @@
 use Magento\Framework\Exception\InputException;
 use Magento\Framework\Exception\CouldNotSaveException;
 
-class CategoryLinkRepository implements \Magento\Catalog\Api\CategoryLinkRepositoryInterface
+class CategoryLinkRepository implements \Magento\Catalog\Api\CategoryLinkRepositoryInterface,
+    \Magento\Catalog\Api\CategoryListRepositoryAdditionalInterface
 {
     /**
      * @var CategoryRepository
@@ -80,11 +81,43 @@ public function delete(\Magento\Catalog\Api\Data\CategoryProductLinkInterface $p
      */
     public function deleteByIds($categoryId, $sku)
     {
-        if (!is_array($sku)) {
-            $sku = [$sku];
+        $category = $this->categoryRepository->get($categoryId);
+        $product = $this->productRepository->get($sku);
+        $productPositions = $category->getProductsPosition();
+
+        $productID = $product->getId();
+        if (!isset($productPositions[$productID])) {
+            throw new InputException(__("The category doesn't contain the specified product."));
         }
+        $backupPosition = $productPositions[$productID];
+        unset($productPositions[$productID]);
+
+        $category->setPostedProducts($productPositions);
+        try {
+            $category->save();
+        } catch (\Exception $e) {
+            throw new CouldNotSaveException(
+                __(
+                    'Could not save product "%product" with position %position to category %category',
+                    [
+                        "product" => $product->getId(),
+                        "position" => $backupPosition,
+                        "category" => $category->getId()
+                    ]
+                ),
+                $e
+            );
+        }
+        return true;
+    }
+
+    /**
+     * {@inheritDoc}
+     */
+    public function deleteBySkus($categoryId, array $productSkuList)
+    {
         $category = $this->categoryRepository->get($categoryId);
-        $products = $this->productResource->getProductsIdsBySkus($sku);
+        $products = $this->productResource->getProductsIdsBySkus($productSkuList);
 
         if (!$products) {
             throw new InputException(__("The category doesn't contain the specified products."));
@@ -99,20 +132,22 @@ public function deleteByIds($categoryId, $sku)
         }
 
         $category->setPostedProducts($productPositions);
+
         try {
             $category->save();
         } catch (\Exception $e) {
             throw new CouldNotSaveException(
                 __(
                     'Could not save products "%products" to category %category',
                     [
-                        "products" => implode(',', $sku),
+                        "products" => implode(',', $productSkuList),
                         "category" => $category->getId()
                     ]
                 ),
                 $e
             );
         }
+
         return true;
     }
 }