Skip to content

Commit 7954f5d

Browse files
LYNX-699 Apply suggestions from code review
Co-authored-by: Deepak Soni <[email protected]>
1 parent fc20c9d commit 7954f5d

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

app/code/Magento/SalesGraphQl/Model/Resolver/OrderTotal.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,8 @@ private function getAppliedTaxesDetails(OrderInterface $order): array
118118
'title' => $appliedTaxes['title'] ?? null,
119119
'amount' => [
120120
'value' => $appliedTaxes['amount'] ?? 0,
121-
'currency' => $order->getOrderCurrencyCode(),
122-
],
121+
'currency' => $order->getOrderCurrencyCode()
122+
]
123123
],
124124
$this->getAllAppliedTaxesOnOrders($order)
125125
);

dev/tests/api-functional/testsuite/Magento/GraphQl/Sales/PlaceOrderTaxTitleTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ protected function setUp(): void
7878
DataFixture(CustomerFixture::class, as: 'customer'),
7979
DataFixture(CustomerCartFixture::class, ['customer_id' => '$customer.id$'], as: 'quote'),
8080
DataFixture(AddProductToCartFixture::class, ['cart_id' => '$quote.id$', 'product_id' => '$product.id$']),
81-
DataFixture(QuoteIdMask::class, ['cart_id' => '$quote.id$'], 'quoteIdMask'),
81+
DataFixture(QuoteIdMask::class, ['cart_id' => '$quote.id$'], 'quoteIdMask')
8282
]
8383
public function testTaxTitleOnPlaceOrder(): void
8484
{
@@ -114,7 +114,7 @@ public function testTaxTitleOnPlaceOrder(): void
114114
* @param string $maskedQuoteId
115115
* @return string
116116
*/
117-
private function getSetShippingAddressOnCartMutation(string $maskedQuoteId)
117+
private function getSetShippingAddressOnCartMutation(string $maskedQuoteId): string
118118
{
119119
return <<<MUTATION
120120
mutation {

0 commit comments

Comments
 (0)