Skip to content

Commit 7a04784

Browse files
AC-7886::Subtotal (Excl. Tax) condition for Cart rule is not working for FREE Shipping - changes updated to fix integration tests
1 parent bd86897 commit 7a04784

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

app/code/Magento/SalesRule/Model/Quote/Discount.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,8 @@ public function collect(
222222
$total->setBaseSubtotalWithDiscount($total->getBaseSubtotal() + $total->getBaseDiscountAmount());
223223
$address->setDiscountAmount($total->getDiscountAmount());
224224
$address->setBaseDiscountAmount($total->getBaseDiscountAmount());
225+
$address->setBaseSubtotalWithDiscount($total->getBaseSubtotal() + $total->getBaseDiscountAmount());
226+
$address->setSubtotalWithDiscount($total->getSubtotal() + $total->getDiscountAmount());
225227
return $this;
226228
}
227229

app/code/Magento/SalesRule/Model/Validator.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -274,8 +274,8 @@ public function canApplyRules(AbstractItem $item)
274274
public function reset(Address $address)
275275
{
276276
$this->validatorUtility->resetRoundingDeltas();
277-
$address->setBaseSubtotalWithDiscount($address->getBaseSubtotalWithDiscount());
278-
$address->setSubtotalWithDiscount($address->getSubtotalWithDiscount());
277+
$address->setBaseSubtotalWithDiscount($address->getBaseSubtotal());
278+
$address->setSubtotalWithDiscount($address->getSubtotal());
279279
$this->rulesApplier->resetDiscountAggregator();
280280
if ($this->_isFirstTimeResetRun) {
281281
$address->setAppliedRuleIds('');

0 commit comments

Comments
 (0)