ACPT-1219: Fix Static Tests failures for application-Server PR

Author: aa-kashk

app/code/Magento/GiftMessage/Model/OrderItemRepository.php

@@ -53,8 +53,6 @@ class OrderItemRepository implements \Magento\GiftMessage\Api\OrderItemRepositor
     protected $helper;
 
     /**
-     * Message factory.
-     *
      * @var \Magento\GiftMessage\Model\MessageFactory
      */
     protected $messageFactory;

app/code/Magento/Indexer/Console/Command/IndexerSetDimensionsModeCommand.php

@@ -70,7 +70,6 @@ protected function configure()
     }
 
     /**
-     *
      * @inheritdoc
      * @param InputInterface $input
      * @param OutputInterface $output

lib/internal/Magento/Framework/Cache/Core.php

@@ -55,14 +55,11 @@ protected function _tags($tags)
     /**
      * Save some data in a cache
      *
-     * @param  mixed $data Data to put in cache (can be another type than string if
-     * automatic_serialization is on)
-     * @param  null|string $cacheId Cache id (if not set, the last cache id will be used)
-     * @param  string[] $tags Cache tags
-     * @param  bool|int $specificLifetime   If != false, set a specific lifetime for this cache record
-     * (null => infinite lifetime)
-     * @param  int $priority integer between 0 (very low priority) and 10 (maximum priority) used by
-     * some particular backends
+     * @param mixed $data Data to put in cache (can be another type than string if automatic_serialization is on)
+     * @param null|string $cacheId Cache id (if not set, the last cache id will be used)
+     * @param string[] $tags Cache tags
+     * @param bool|int $specificLifetime   If != false, set a specific lifetime for this cache record (null => infinite lifetime)
+     * @param int $priority integer between 0 (very low priority) and 10 (maximum priority) used by some particular backends
      * @return bool True if no problem
      */
     public function save($data, $cacheId = null, $tags = [], $specificLifetime = false, $priority = 8)

lib/internal/Magento/Framework/Model/ActionValidator/RemoveAction.php

@@ -53,8 +53,8 @@ public function isAllowed(AbstractModel $model)
     }
 
     /**
-     *
      * Get clean model name without Interceptor and Proxy part and slashes
+     *
      * @param object $object
      * @return mixed
      */

lib/internal/Magento/Framework/ObjectManager/ObjectManager.php

@@ -34,11 +34,12 @@ class ObjectManager implements \Magento\Framework\ObjectManagerInterface
     protected $_config;
 
     /**
+     *
      * @param FactoryInterface $factory
      * @param ConfigInterface $config
      * @param array &$sharedInstances
      */
-    public function __construct(FactoryInterface $factory, ConfigInterface $config, &$sharedInstances = [])
+    public function __construct(FactoryInterface $factory, ConfigInterface $config, array &$sharedInstances = [])
     {
         $this->_config = $config;
         $this->_factory = $factory;

lib/internal/Magento/Framework/Registry.php

@@ -15,6 +15,7 @@
  *
  * @api
  * @deprecated 102.0.0
+ * @see Nothing
  * @since 100.0.2
  */
 class Registry implements ResetAfterRequestInterface
@@ -31,8 +32,8 @@ class Registry implements ResetAfterRequestInterface
      *
      * @param string $key
      * @return mixed
-     *
      * @deprecated 102.0.0
+     * @see Nothing
      */
     public function registry($key)
     {
@@ -50,8 +51,8 @@ public function registry($key)
      * @param bool $graceful
      * @return void
      * @throws \RuntimeException
-     *
      * @deprecated 102.0.0
+     * @see Nothing
      */
     public function register($key, $value, $graceful = false)
     {
@@ -69,8 +70,8 @@ public function register($key, $value, $graceful = false)
      *
      * @param string $key
      * @return void
-     *
      * @deprecated 102.0.0
+     * @see Nothing
      */
     public function unregister($key)
     {
@@ -94,7 +95,6 @@ public function __destruct()
         array_walk($keys, [$this, 'unregister']);
     }
 
-
     /**
      * @inheritDoc
      */

lib/internal/Magento/Framework/Session/SessionManager.php

@@ -208,6 +208,7 @@ public function start()
     }
 
     /**
+     *
      * @return void
      */
     public function registerShutdown() {

lib/internal/Magento/Framework/Session/Storage.php

@@ -1,14 +1,15 @@
 <?php
 /**
- * Default session storage
- *
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
 namespace Magento\Framework\Session;
 
 use Magento\Framework\ObjectManager\ResetAfterRequestInterface;
 
+/**
+ * Default session storage
+ */
 class Storage extends \Magento\Framework\DataObject implements StorageInterface, ResetAfterRequestInterface
 {
     /**

lib/internal/Magento/Framework/Webapi/ErrorProcessor.php

@@ -28,24 +28,24 @@
  */
 class ErrorProcessor
 {
-    const DEFAULT_SHUTDOWN_FUNCTION = 'apiShutdownFunction';
+    public const DEFAULT_SHUTDOWN_FUNCTION = 'apiShutdownFunction';
 
-    const DEFAULT_ERROR_HTTP_CODE = 500;
+    public const DEFAULT_ERROR_HTTP_CODE = 500;
 
-    const DEFAULT_RESPONSE_CHARSET = 'UTF-8';
+    public const DEFAULT_RESPONSE_CHARSET = 'UTF-8';
 
-    const INTERNAL_SERVER_ERROR_MSG = 'Internal Error. Details are available in Magento log file. Report ID: %s';
+    public const INTERNAL_SERVER_ERROR_MSG = 'Internal Error. Details are available in Magento log file. Report ID: %s';
 
-    /**#@+
+    /**
      * Error data representation formats.
      */
-    const DATA_FORMAT_JSON = 'json';
-
-    const DATA_FORMAT_XML = 'xml';
+    public const DATA_FORMAT_JSON = 'json';
 
-    /**#@-*/
+    public const DATA_FORMAT_XML = 'xml';
 
-    /**#@-*/
+    /**
+     * @var \Magento\Framework\Json\Encoder $encoder
+     */
     protected $encoder;
 
     /**

lib/internal/Magento/Framework/Webapi/Request.php

@@ -1,7 +1,5 @@
 <?php
 /**
- * Web API request.
- *
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
@@ -16,19 +14,21 @@
 use Magento\Framework\Stdlib\StringUtils;
 
 /**
+ * Web API request.
+ *
  * @SuppressWarnings(PHPMD.CookieAndSessionMisuse)
  */
 class Request extends HttpRequest implements RequestInterface
 {
     /**
      * Name of query parameter to specify services for which to generate schema
      */
-    const REQUEST_PARAM_SERVICES = 'services';
+    public const REQUEST_PARAM_SERVICES = 'services';
 
     /**
      * services parameter value to indicate that a schema for all services should be generated
      */
-    const ALL_SERVICES = 'all';
+    public const ALL_SERVICES = 'all';
 
     /**
      * Modify pathInfo: strip down the front name and query parameters.