Skip to content

Commit 7c49551

Browse files
RaghavendraTirumalasettiManjusha.S
authored andcommitted
BUG#AC-2242:Error:Cart Price rule forces Free Shipping to "No" even if "-- Please Select --" was saved
1 parent f395dff commit 7c49551

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

app/code/Magento/OfflineShipping/etc/db_schema.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
</constraint>
3939
</table>
4040
<table name="salesrule" resource="default" comment="Salesrule">
41-
<column xsi:type="smallint" name="simple_free_shipping" unsigned="true" nullable="false"
41+
<column xsi:type="smallint" name="simple_free_shipping" unsigned="true" nullable="true"
4242
identity="false" default="0" comment="Simple Free Shipping"/>
4343
</table>
4444
<table name="sales_order_item" resource="sales" comment="Sales Flat Order Item">

app/code/Magento/SalesRule/Controller/Adminhtml/Promo/Quote/Save.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,9 @@ public function __construct(
6363
public function execute()
6464
{
6565
$data = $this->getRequest()->getPostValue();
66+
if ($data['simple_free_shipping']==="") {
67+
$data['simple_free_shipping']=null;
68+
}
6669
if ($data) {
6770
try {
6871
/** @var $model \Magento\SalesRule\Model\Rule */

0 commit comments

Comments
 (0)