Added filter nfinset in product search

- Deprecate "finset" and "nfinset" fields.

Author: VladimirZaets

app/code/Magento/GraphQl/etc/schema.graphqls

@@ -9,8 +9,8 @@ type Mutation {
 
 input FilterTypeInput @doc(description: "FilterTypeInput specifies which action will be performed in a query ") {
     eq: String @doc(description: "Equals")
-    finset: [String] @doc(description: "Find in set. The value can contain a set of comma-separated values")
-    nfinset: [String] @doc(description: "Not find in set. The value can contain a set of comma-separated values")
+    finset: [String] @deprecated (reason: "The finset filter is deprecated. Magento doesn't recomend to store comma separated values, therefore finset filter is redundant.")
+    nfinset: [String] @deprecated (reason: "The finset filter is deprecated. Magento doesn't recomend to store comma separated values, therefore finset filter is redundant.")
     from: String @doc(description: "From. Must be used with 'to'")
     gt: String @doc(description: "Greater than")
     gteq: String @doc(description: "Greater than or equal to")

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductViewTest.php

@@ -670,30 +670,6 @@ public function testProductPrices()
         $this->assertBaseFields($secondProduct, $response['products']['items'][1]);
     }
 
-    /**
-     * @magentoApiDataFixture Magento/Catalog/_files/products_for_search.php
-     */
-    public function testProductFilterNfinset()
-    {
-        $productSku = 'search_product_1';
-
-        $query = <<<QUERY
-       {
-           products(filter: {sku: {nfinset: ["$productSku"]}})
-           {
-               items {
-                   id
-                  name
-                  sku
-               }
-           }
-       }
-QUERY;
-
-        $response = $this->graphQlQuery($query);
-        $this->assertNotContains($productSku, array_column($response['products']['items'], 'sku'));
-    }
-
     /**
      * @param ProductInterface $product
      * @param array $actualResponse

dev/tests/integration/testsuite/Magento/Framework/GraphQl/_files/schemaA.graphqls

@@ -8,8 +8,6 @@ type Mutation {
 
 input FilterTypeInput @doc(description:"Comment for FilterTypeInput") {
     eq: String @doc(description:"Equal")
-    finset: [String]
-    nfinset: [String]
     from: String
     gt: String
     gteq: String

dev/tests/integration/testsuite/Magento/Framework/GraphQl/_files/schemaC.graphqls

@@ -19,8 +19,6 @@ type Attribute @doc(description: "Attribute contains the attribute_type of the s
 }
 input FilterTypeInput @doc(description:"Comment for FilterTypeInput") {
     eq: String @doc(description:"Equal")
-    finset: [String]
-    nfinset: [String]
     from: String
     gt: String
     gteq: String

dev/tests/integration/testsuite/Magento/Framework/GraphQl/_files/schema_response_sdl_description.php

@@ -505,34 +505,6 @@
                 ],
                 'defaultValue' =>  null
             ],
-            [
-                'name' =>  'finset',
-                'description' =>  '',
-                'type' =>  [
-                    'kind' =>  'LIST',
-                    'name' =>  null,
-                    'ofType' =>  [
-                        'kind' =>  'SCALAR',
-                        'name' =>  'String',
-                        'ofType' =>  null
-                    ]
-                ],
-                'defaultValue' =>  null
-            ],
-            [
-                'name' =>  'nfinset',
-                'description' =>  '',
-                'type' =>  [
-                    'kind' =>  'LIST',
-                    'name' =>  null,
-                    'ofType' =>  [
-                        'kind' =>  'SCALAR',
-                        'name' =>  'String',
-                        'ofType' =>  null
-                    ]
-                ],
-                'defaultValue' =>  null
-            ],
             [
                 'name' =>  'from',
                 'description' =>  '',

dev/tests/integration/testsuite/Magento/Framework/GraphQl/_files/schema_with_description_sdl.php

@@ -505,34 +505,6 @@
                 ],
                 'defaultValue' =>  null
             ],
-            [
-                'name' =>  'finset',
-                'description' =>  '',
-                'type' =>  [
-                    'kind' =>  'LIST',
-                    'name' =>  null,
-                    'ofType' =>  [
-                        'kind' =>  'SCALAR',
-                        'name' =>  'String',
-                        'ofType' =>  null
-                    ]
-                ],
-                'defaultValue' =>  null
-            ],
-            [
-                'name' =>  'nfinset',
-                'description' =>  '',
-                'type' =>  [
-                    'kind' =>  'LIST',
-                    'name' =>  null,
-                    'ofType' =>  [
-                        'kind' =>  'SCALAR',
-                        'name' =>  'String',
-                        'ofType' =>  null
-                    ]
-                ],
-                'defaultValue' =>  null
-            ],
             [
                 'name' =>  'from',
                 'description' =>  '',

lib/internal/Magento/Framework/DB/Adapter/Pdo/Mysql.php

@@ -2976,9 +2976,6 @@ public function prepareSqlCondition($fieldName, $condition)
                 if (($key == 'in' || $key == 'nin') && is_string($value)) {
                     $value = explode(',', $value);
                 }
-                if (($key == 'finset' || $key == 'nfinset') && is_array($value)) {
-                    $value = implode(',', $value);
-                }
                 $query = $this->_prepareQuotedSqlCondition($conditionKeyMap[$key], $value, $fieldName);
             } else {
                 $queries = [];