Merge remote-tracking branch 'origin/ENGCOM-5290-magento-graphql-ce-701' into graphql-develop-prs

# Conflicts:
#	app/code/Magento/QuoteGraphQl/Model/Resolver/SetPaymentMethodOnCart.php

Author: naydav

app/code/Magento/QuoteGraphQl/Model/Cart/CheckCartCheckoutAllowance.php

@@ -0,0 +1,56 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\QuoteGraphQl\Model\Cart;
+
+use Magento\Checkout\Helper\Data as CheckoutHelper;
+use Magento\Framework\GraphQl\Exception\GraphQlAuthorizationException;
+use Magento\Quote\Model\Quote;
+
+/**
+ * Checks if guest checkout is allowed.
+ */
+class CheckCartCheckoutAllowance
+{
+    /**
+     * @var CheckoutHelper
+     */
+    private $checkoutHelper;
+
+    /**
+     * @param CheckoutHelper $checkoutHelper
+     */
+    public function __construct(
+        CheckoutHelper $checkoutHelper
+    ) {
+        $this->checkoutHelper = $checkoutHelper;
+    }
+
+    /**
+     * Check if User is allowed to checkout
+     *
+     * @param Quote $quote
+     * @return void
+     * @throws GraphQlAuthorizationException
+     */
+    public function execute(Quote $quote): void
+    {
+        if (false === $quote->getCustomerIsGuest()) {
+            return;
+        }
+
+        $isAllowedGuestCheckout = (bool)$this->checkoutHelper->isAllowedGuestCheckout($quote);
+        if (false === $isAllowedGuestCheckout) {
+            throw new GraphQlAuthorizationException(
+                __(
+                    'Guest checkout is not allowed. ' .
+                    'Register a customer account or login with existing one.'
+                )
+            );
+        }
+    }
+}

app/code/Magento/QuoteGraphQl/Model/Resolver/PlaceOrder.php

@@ -17,6 +17,7 @@
 use Magento\Quote\Api\CartManagementInterface;
 use Magento\QuoteGraphQl\Model\Cart\GetCartForUser;
 use Magento\Sales\Api\OrderRepositoryInterface;
+use Magento\QuoteGraphQl\Model\Cart\CheckCartCheckoutAllowance;
 
 /**
  * @inheritdoc
@@ -38,19 +39,27 @@ class PlaceOrder implements ResolverInterface
      */
     private $orderRepository;
 
+    /**
+     * @var CheckCartCheckoutAllowance
+     */
+    private $checkCartCheckoutAllowance;
+
     /**
      * @param GetCartForUser $getCartForUser
      * @param CartManagementInterface $cartManagement
      * @param OrderRepositoryInterface $orderRepository
+     * @param CheckCartCheckoutAllowance $checkCartCheckoutAllowance
      */
     public function __construct(
         GetCartForUser $getCartForUser,
         CartManagementInterface $cartManagement,
-        OrderRepositoryInterface $orderRepository
+        OrderRepositoryInterface $orderRepository,
+        CheckCartCheckoutAllowance $checkCartCheckoutAllowance
     ) {
         $this->getCartForUser = $getCartForUser;
         $this->cartManagement = $cartManagement;
         $this->orderRepository = $orderRepository;
+        $this->checkCartCheckoutAllowance = $checkCartCheckoutAllowance;
     }
 
     /**
@@ -64,6 +73,7 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
         $maskedCartId = $args['input']['cart_id'];
 
         $cart = $this->getCartForUser->execute($maskedCartId, $context->getUserId());
+        $this->checkCartCheckoutAllowance->execute($cart);
 
         if ((int)$context->getUserId() === 0) {
             if (!$cart->getCustomerEmail()) {

app/code/Magento/QuoteGraphQl/Model/Resolver/SetBillingAddressOnCart.php

@@ -13,6 +13,7 @@
 use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
 use Magento\QuoteGraphQl\Model\Cart\GetCartForUser;
 use Magento\QuoteGraphQl\Model\Cart\SetBillingAddressOnCart as SetBillingAddressOnCartModel;
+use Magento\QuoteGraphQl\Model\Cart\CheckCartCheckoutAllowance;
 
 /**
  * Mutation resolver for setting billing address for shopping cart
@@ -29,16 +30,24 @@ class SetBillingAddressOnCart implements ResolverInterface
      */
     private $setBillingAddressOnCart;
 
+    /**
+     * @var CheckCartCheckoutAllowance
+     */
+    private $checkCartCheckoutAllowance;
+
     /**
      * @param GetCartForUser $getCartForUser
      * @param SetBillingAddressOnCartModel $setBillingAddressOnCart
+     * @param CheckCartCheckoutAllowance $checkCartCheckoutAllowance
      */
     public function __construct(
         GetCartForUser $getCartForUser,
-        SetBillingAddressOnCartModel $setBillingAddressOnCart
+        SetBillingAddressOnCartModel $setBillingAddressOnCart,
+        CheckCartCheckoutAllowance $checkCartCheckoutAllowance
     ) {
         $this->getCartForUser = $getCartForUser;
         $this->setBillingAddressOnCart = $setBillingAddressOnCart;
+        $this->checkCartCheckoutAllowance = $checkCartCheckoutAllowance;
     }
 
     /**
@@ -57,6 +66,7 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
         $billingAddress = $args['input']['billing_address'];
 
         $cart = $this->getCartForUser->execute($maskedCartId, $context->getUserId());
+        $this->checkCartCheckoutAllowance->execute($cart);
         $this->setBillingAddressOnCart->execute($context, $cart, $billingAddress);
 
         return [

app/code/Magento/QuoteGraphQl/Model/Resolver/SetGuestEmailOnCart.php

@@ -16,6 +16,7 @@
 use Magento\Framework\Validator\EmailAddress as EmailAddressValidator;
 use Magento\Quote\Api\CartRepositoryInterface;
 use Magento\QuoteGraphQl\Model\Cart\GetCartForUser;
+use Magento\QuoteGraphQl\Model\Cart\CheckCartCheckoutAllowance;
 
 /**
  * @inheritdoc
@@ -37,19 +38,27 @@ class SetGuestEmailOnCart implements ResolverInterface
      */
     private $emailValidator;
 
+    /**
+     * @var CheckCartCheckoutAllowance
+     */
+    private $checkCartCheckoutAllowance;
+
     /**
      * @param GetCartForUser $getCartForUser
      * @param CartRepositoryInterface $cartRepository
      * @param EmailAddressValidator $emailValidator
+     * @param CheckCartCheckoutAllowance $checkCartCheckoutAllowance
      */
     public function __construct(
         GetCartForUser $getCartForUser,
         CartRepositoryInterface $cartRepository,
-        EmailAddressValidator $emailValidator
+        EmailAddressValidator $emailValidator,
+        CheckCartCheckoutAllowance $checkCartCheckoutAllowance
     ) {
         $this->getCartForUser = $getCartForUser;
         $this->cartRepository = $cartRepository;
         $this->emailValidator = $emailValidator;
+        $this->checkCartCheckoutAllowance = $checkCartCheckoutAllowance;
     }
 
     /**
@@ -78,6 +87,7 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
         }
 
         $cart = $this->getCartForUser->execute($maskedCartId, $currentUserId);
+        $this->checkCartCheckoutAllowance->execute($cart);
         $cart->setCustomerEmail($email);
 
         try {

app/code/Magento/QuoteGraphQl/Model/Resolver/SetPaymentMethodOnCart.php

@@ -11,6 +11,7 @@
 use Magento\Framework\GraphQl\Exception\GraphQlInputException;
 use Magento\Framework\GraphQl\Query\ResolverInterface;
 use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
+use Magento\QuoteGraphQl\Model\Cart\CheckCartCheckoutAllowance;
 use Magento\QuoteGraphQl\Model\Cart\GetCartForUser;
 use Magento\QuoteGraphQl\Model\Cart\SetPaymentMethodOnCart as SetPaymentMethodOnCartModel;
 
@@ -29,16 +30,24 @@ class SetPaymentMethodOnCart implements ResolverInterface
      */
     private $setPaymentMethodOnCart;
 
+    /**
+     * @var CheckCartCheckoutAllowance
+     */
+    private $checkCartCheckoutAllowance;
+
     /**
      * @param GetCartForUser $getCartForUser
      * @param SetPaymentMethodOnCartModel $setPaymentMethodOnCart
+     * @param CheckCartCheckoutAllowance $checkCartCheckoutAllowance
      */
     public function __construct(
         GetCartForUser $getCartForUser,
-        SetPaymentMethodOnCartModel $setPaymentMethodOnCart
+        SetPaymentMethodOnCartModel $setPaymentMethodOnCart,
+        CheckCartCheckoutAllowance $checkCartCheckoutAllowance
     ) {
         $this->getCartForUser = $getCartForUser;
         $this->setPaymentMethodOnCart = $setPaymentMethodOnCart;
+        $this->checkCartCheckoutAllowance = $checkCartCheckoutAllowance;
     }
 
     /**
@@ -57,6 +66,7 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
         $paymentData = $args['input']['payment_method'];
 
         $cart = $this->getCartForUser->execute($maskedCartId, $context->getUserId());
+        $this->checkCartCheckoutAllowance->execute($cart);
         $this->setPaymentMethodOnCart->execute($cart, $paymentData);
 
         return [

app/code/Magento/QuoteGraphQl/Model/Resolver/SetShippingAddressesOnCart.php

@@ -13,6 +13,7 @@
 use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
 use Magento\QuoteGraphQl\Model\Cart\GetCartForUser;
 use Magento\QuoteGraphQl\Model\Cart\SetShippingAddressesOnCartInterface;
+use Magento\QuoteGraphQl\Model\Cart\CheckCartCheckoutAllowance;
 
 /**
  * Mutation resolver for setting shipping addresses for shopping cart
@@ -29,16 +30,24 @@ class SetShippingAddressesOnCart implements ResolverInterface
      */
     private $setShippingAddressesOnCart;
 
+    /**
+     * @var CheckCartCheckoutAllowance
+     */
+    private $checkCartCheckoutAllowance;
+
     /**
      * @param GetCartForUser $getCartForUser
      * @param SetShippingAddressesOnCartInterface $setShippingAddressesOnCart
+     * @param CheckCartCheckoutAllowance $checkCartCheckoutAllowance
      */
     public function __construct(
         GetCartForUser $getCartForUser,
-        SetShippingAddressesOnCartInterface $setShippingAddressesOnCart
+        SetShippingAddressesOnCartInterface $setShippingAddressesOnCart,
+        CheckCartCheckoutAllowance $checkCartCheckoutAllowance
     ) {
         $this->getCartForUser = $getCartForUser;
         $this->setShippingAddressesOnCart = $setShippingAddressesOnCart;
+        $this->checkCartCheckoutAllowance = $checkCartCheckoutAllowance;
     }
 
     /**
@@ -57,6 +66,7 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
         $shippingAddresses = $args['input']['shipping_addresses'];
 
         $cart = $this->getCartForUser->execute($maskedCartId, $context->getUserId());
+        $this->checkCartCheckoutAllowance->execute($cart);
         $this->setShippingAddressesOnCart->execute($context, $cart, $shippingAddresses);
 
         return [

app/code/Magento/QuoteGraphQl/Model/Resolver/SetShippingMethodsOnCart.php

@@ -13,6 +13,7 @@
 use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
 use Magento\QuoteGraphQl\Model\Cart\GetCartForUser;
 use Magento\QuoteGraphQl\Model\Cart\SetShippingMethodsOnCartInterface;
+use Magento\QuoteGraphQl\Model\Cart\CheckCartCheckoutAllowance;
 
 /**
  * Mutation resolver for setting shipping methods for shopping cart
@@ -29,16 +30,24 @@ class SetShippingMethodsOnCart implements ResolverInterface
      */
     private $setShippingMethodsOnCart;
 
+    /**
+     * @var CheckCartCheckoutAllowance
+     */
+    private $checkCartCheckoutAllowance;
+
     /**
      * @param GetCartForUser $getCartForUser
      * @param SetShippingMethodsOnCartInterface $setShippingMethodsOnCart
+     * @param CheckCartCheckoutAllowance $checkCartCheckoutAllowance
      */
     public function __construct(
         GetCartForUser $getCartForUser,
-        SetShippingMethodsOnCartInterface $setShippingMethodsOnCart
+        SetShippingMethodsOnCartInterface $setShippingMethodsOnCart,
+        CheckCartCheckoutAllowance $checkCartCheckoutAllowance
     ) {
         $this->getCartForUser = $getCartForUser;
         $this->setShippingMethodsOnCart = $setShippingMethodsOnCart;
+        $this->checkCartCheckoutAllowance = $checkCartCheckoutAllowance;
     }
 
     /**
@@ -57,6 +66,7 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value
         $shippingMethods = $args['input']['shipping_methods'];
 
         $cart = $this->getCartForUser->execute($maskedCartId, $context->getUserId());
+        $this->checkCartCheckoutAllowance->execute($cart);
         $this->setShippingMethodsOnCart->execute($context, $cart, $shippingMethods);
 
         return [

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/ApplyCouponToCartTest.php

@@ -239,7 +239,7 @@ public function dataProviderUpdateWithMissedRequiredParameters(): array
                 'Required parameter "cart_id" is missing'
             ],
             'missed_coupon_code' => [
-                'cart_id: "test"',
+                'cart_id: "test_quote"',
                 'Required parameter "coupon_code" is missing'
             ],
         ];

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/RemoveItemFromCartTest.php

@@ -128,7 +128,7 @@ public function dataProviderUpdateWithMissedRequiredParameters(): array
                 'Required parameter "cart_id" is missing.'
             ],
             'missed_cart_item_id' => [
-                'cart_id: "test"',
+                'cart_id: "test_quote"',
                 'Required parameter "cart_item_id" is missing.'
             ],
         ];

dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetPaymentMethodOnCartTest.php

@@ -187,6 +187,9 @@ public function testSetPaymentMethodToAnotherCustomerCart()
      */
     public function testSetPaymentMethodWithoutRequiredParameters(string $input, string $message)
     {
+        $maskedQuoteId = $this->getMaskedQuoteIdByReservedOrderId->execute('test_quote');
+        $input = str_replace('cart_id_value', $maskedQuoteId, $input);
+
         $query = <<<QUERY
 mutation {
   setPaymentMethodOnCart(
@@ -235,11 +238,11 @@ public function dataProviderSetPaymentMethodWithoutRequiredParameters(): array
                 'Required parameter "cart_id" is missing.'
             ],
             'missed_payment_method' => [
-                'cart_id: "test"',
+                'cart_id: "cart_id_value"',
                 'Required parameter "code" for "payment_method" is missing.'
             ],
             'missed_payment_method_code' => [
-                'cart_id: "test", payment_method: {code: ""}',
+                'cart_id: "cart_id_value", payment_method: {code: ""}',
                 'Required parameter "code" for "payment_method" is missing.'
             ],
         ];