MAGETWO-93057: [2.3] salesShipmentRepositoryV1 throws error when adding tracking

Author: serhii-balko

app/code/Magento/Sales/Model/Order/Shipment.php

@@ -522,7 +522,7 @@ public function getPackages()
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      * @codeCoverageIgnore
      */
     public function setPackages(array $packages = null)
@@ -619,7 +619,7 @@ public function getCreatedAt()
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setCreatedAt($createdAt)
     {
@@ -751,95 +751,95 @@ public function setComments($comments = null)
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setStoreId($id)
     {
         return $this->setData(ShipmentInterface::STORE_ID, $id);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setTotalWeight($totalWeight)
     {
         return $this->setData(ShipmentInterface::TOTAL_WEIGHT, $totalWeight);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setTotalQty($qty)
     {
         return $this->setData(ShipmentInterface::TOTAL_QTY, $qty);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setEmailSent($emailSent)
     {
         return $this->setData(ShipmentInterface::EMAIL_SENT, $emailSent);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setOrderId($id)
     {
         return $this->setData(ShipmentInterface::ORDER_ID, $id);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setCustomerId($id)
     {
         return $this->setData(ShipmentInterface::CUSTOMER_ID, $id);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setShippingAddressId($id)
     {
         return $this->setData(ShipmentInterface::SHIPPING_ADDRESS_ID, $id);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setBillingAddressId($id)
     {
         return $this->setData(ShipmentInterface::BILLING_ADDRESS_ID, $id);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setShipmentStatus($shipmentStatus)
     {
         return $this->setData(ShipmentInterface::SHIPMENT_STATUS, $shipmentStatus);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setIncrementId($id)
     {
         return $this->setData(ShipmentInterface::INCREMENT_ID, $id);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function setUpdatedAt($timestamp)
     {
         return $this->setData(ShipmentInterface::UPDATED_AT, $timestamp);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      *
      * @return \Magento\Sales\Api\Data\ShipmentExtensionInterface|null
      */
@@ -849,7 +849,7 @@ public function getExtensionAttributes()
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      *
      * @param \Magento\Sales\Api\Data\ShipmentExtensionInterface $extensionAttributes
      * @return $this

app/code/Magento/Sales/Test/Unit/Model/Order/ShipmentTest.php

@@ -29,6 +29,9 @@ class ShipmentTest extends \PHPUnit\Framework\TestCase
      */
     private $shipmentModel;
 
+    /**
+     * @return void
+     */
     protected function setUp()
     {
         $helperManager = new ObjectManager($this);
@@ -40,12 +43,23 @@ protected function setUp()
         ]);
     }
 
+    /**
+     * Test to Returns increment id
+     *
+     * @return void
+     */
     public function testGetIncrementId()
     {
         $this->shipmentModel->setIncrementId('test_increment_id');
         $this->assertEquals('test_increment_id', $this->shipmentModel->getIncrementId());
     }
 
+    /**
+     * Test to Retrieves comments collection
+     *
+     * @return void
+     * @throws \ReflectionException
+     */
     public function testGetCommentsCollection()
     {
         $shipmentId = 1;
@@ -78,6 +92,12 @@ public function testGetCommentsCollection()
         self::assertEquals($this->commentCollection, $actual);
     }
 
+    /**
+     * Test to Returns comments
+     *
+     * @return void
+     * @throws \ReflectionException
+     */
     public function testGetComments()
     {
         $shipmentId = 1;

dev/tests/integration/testsuite/Magento/Sales/Model/Order/ShipmentTest.php

@@ -79,9 +79,6 @@ public function testAddTrack()
     {
         $order = $this->getOrder('100000001');
 
-        /** @var ShipmentInterface $shipment */
-        $shipment = $this->objectManager->create(ShipmentInterface::class);
-
         /** @var ShipmentTrackInterface $track */
         $track = $this->objectManager->create(ShipmentTrackInterface::class);
         $track->setNumber('Test Number')