Skip to content

Commit 8102ba4

Browse files
committed
MAGETWO-60602: [Github] Combine widget rule #7274
1 parent e151e0f commit 8102ba4

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

app/code/Magento/CatalogWidget/Model/Rule/Condition/Combine.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public function getNewChildSelectOptions()
8282
public function collectValidatedAttributes($productCollection)
8383
{
8484
foreach ($this->getConditions() as $condition) {
85-
$condition->addToCollection($productCollection);
85+
$condition->collectValidatedAttributes($productCollection);
8686
}
8787
return $this;
8888
}

app/code/Magento/CatalogWidget/Model/Rule/Condition/Product.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,4 +223,12 @@ public function getMappedSqlField()
223223

224224
return $result;
225225
}
226+
227+
/**
228+
* {@inheritdoc}
229+
*/
230+
public function collectValidatedAttributes($productCollection)
231+
{
232+
return $this->addToCollection($productCollection);
233+
}
226234
}

app/code/Magento/CatalogWidget/Test/Unit/Model/Rule/Condition/CombineTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,9 @@ public function testCollectValidatedAttributes()
8080
->disableOriginalConstructor()
8181
->getMock();
8282
$condition = $this->getMockBuilder(\Magento\CatalogWidget\Model\Rule\Condition\Combine::class)
83-
->disableOriginalConstructor()->setMethods(['addToCollection'])
83+
->disableOriginalConstructor()->setMethods(['collectValidatedAttributes'])
8484
->getMock();
85-
$condition->expects($this->any())->method('addToCollection')->with($collection)
85+
$condition->expects($this->any())->method('collectValidatedAttributes')->with($collection)
8686
->will($this->returnSelf());
8787

8888
$this->condition->setConditions([$condition]);

0 commit comments

Comments
 (0)