MC-16922: Create an end-to-end test SetPaymentMethodOnCart for the authorize.net payment method

- review comments

Author: dthampy

dev/tests/integration/testsuite/Magento/AuthorizenetGraphQl/Model/Resolver/Customer/PlaceOrderWithAuthorizeNetTest.php

@@ -41,9 +41,6 @@ class PlaceOrderWithAuthorizeNetTest extends TestCase
     /** @var  GetMaskedQuoteIdByReservedOrderId */
     private $getMaskedQuoteIdByReservedOrderId;
 
-    /** @var GraphQl */
-    private $graphql;
-
     /** @var SerializerInterface */
     private $jsonSerializer;
 
@@ -65,7 +62,6 @@ class PlaceOrderWithAuthorizeNetTest extends TestCase
     protected function setUp() : void
     {
         $this->objectManager = Bootstrap::getObjectManager();
-        $this->graphql = $this->objectManager->get(\Magento\GraphQl\Controller\GraphQl::class);
         $this->jsonSerializer = $this->objectManager->get(SerializerInterface::class);
         $this->request = $this->objectManager->get(Http::class);
         $this->getMaskedQuoteIdByReservedOrderId = $this->objectManager->get(GetMaskedQuoteIdByReservedOrderId::class);
@@ -92,7 +88,7 @@ protected function setUp() : void
      * @magentoConfigFixture default_store payment/authorizenet_acceptjs/trans_signature_key abc
      * @magentoDataFixture Magento/Sales/_files/default_rollback.php
      * @magentoDataFixture Magento/Customer/_files/customer.php
-     * @magentoDataFixture Magento/GraphQl/Catalog/_files/simple_product_authorizenet.php
+     * @magentoDataFixture Magento/AuthorizenetGraphQl/_files/simple_product_authorizenet.php
      * @magentoDataFixture Magento/GraphQl/Quote/_files/customer/create_empty_cart.php
      * @magentoDataFixture Magento/AuthorizenetGraphQl/_files/set_new_shipping_address_authorizenet.php
      * @magentoDataFixture Magento/AuthorizenetGraphQl/_files/set_new_billing_address_authorizenet.php
@@ -140,13 +136,11 @@ public function testDispatchToPlaceOrderWithRegisteredCustomer(): void
         $this->request->setContent($this->jsonSerializer->serialize($postData));
         $customerToken = $this->customerTokenService->createCustomerAccessToken('[email protected]', 'password');
         $bearerCustomerToken = 'Bearer ' . $customerToken;
-        $contentType ='application/json';
         $webApiRequest = $this->objectManager->get(Request::class);
-        $webApiRequest->getHeaders()->addHeaderLine('Content-Type', $contentType)
-            ->addHeaderLine('Accept', $contentType)
+        $webApiRequest->getHeaders()->addHeaderLine('Content-Type', 'application/json')
+            ->addHeaderLine('Accept', 'application/json')
             ->addHeaderLine('Authorization', $bearerCustomerToken);
         $this->request->setHeaders($webApiRequest->getHeaders());
-
         $graphql = $this->objectManager->get(\Magento\GraphQl\Controller\GraphQl::class);
 
         $expectedRequest = include __DIR__ . '/../../../_files/request_authorize_customer.php';
@@ -160,7 +154,7 @@ public function testDispatchToPlaceOrderWithRegisteredCustomer(): void
         $response = $graphql->dispatch($this->request);
         $responseData = $this->jsonSerializer->unserialize($response->getContent());
 
-       $this->assertArrayNotHasKey('errors', $responseData, 'Response has errors');
+        $this->assertArrayNotHasKey('errors', $responseData, 'Response has errors');
         $this->assertTrue(
             isset($responseData['data']['setPaymentMethodOnCart']['cart']['selected_payment_method']['code'])
         );
@@ -182,7 +176,6 @@ public function testDispatchToPlaceOrderWithRegisteredCustomer(): void
     protected function tearDown()
     {
         $this->objectManager->removeSharedInstance(ZendClientFactory::class);
-        include __DIR__ . '/../../../../../Magento/Customer/_files/customer_rollback.php';
         parent::tearDown();
     }
 }

dev/tests/integration/testsuite/Magento/AuthorizenetGraphQl/Model/Resolver/Customer/SetAuthorizeNetPaymentMethodOnCartTest.php

@@ -38,10 +38,6 @@ class SetAuthorizenetPaymentMethodOnCartTest extends TestCase
     /** @var  CustomerTokenServiceInterface */
     private $customerTokenService;
 
-    /**
-     * @var \Magento\Framework\App\Cache */
-    private $appCache;
-
     /** @var Http */
     private $request;
 

dev/tests/integration/testsuite/Magento/AuthorizenetGraphQl/Model/Resolver/Guest/PlaceOrderWithAuthorizeNetTest.php

@@ -85,7 +85,7 @@ protected function setUp() : void
      * @magentoConfigFixture default_store payment/authorizenet_acceptjs/trans_key somepassword
      * @magentoConfigFixture default_store payment/authorizenet_acceptjs/trans_signature_key abc
      * @magentoDataFixture Magento/Sales/_files/default_rollback.php
-     * @magentoDataFixture Magento/GraphQl/Catalog/_files/simple_product_authorizenet.php
+     * @magentoDataFixture Magento/AuthorizenetGraphQl/_files/simple_product_authorizenet.php
      * @magentoDataFixture Magento/GraphQl/Quote/_files/guest/create_empty_cart.php
      * @magentoDataFixture Magento/GraphQl/Quote/_files/guest/set_guest_email.php
      * @magentoDataFixture Magento/AuthorizenetGraphQl/_files/set_new_shipping_address_authorizenet.php
@@ -169,7 +169,6 @@ public function testDispatchToPlaceAnOrderWithAuthorizenet(): void
     protected function tearDown()
     {
         $this->objectManager->removeSharedInstance(ZendClientFactory::class);
-        include __DIR__ . '/../../../../../Magento/Customer/_files/not_logged_in_customer_rollback.php';
         parent::tearDown();
     }
 }

dev/tests/integration/testsuite/Magento/AuthorizenetGraphQl/_files/simple_product_authorizenet.php

@@ -0,0 +1,45 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+use Magento\Catalog\Api\Data\ProductInterface;
+use Magento\Catalog\Api\Data\ProductInterfaceFactory;
+use Magento\Catalog\Api\ProductRepositoryInterface;
+use Magento\Catalog\Model\Product\Attribute\Source\Status;
+use Magento\Catalog\Model\Product\Type;
+use Magento\Catalog\Model\Product\Visibility;
+use Magento\Framework\Api\DataObjectHelper;
+use Magento\TestFramework\Helper\Bootstrap;
+
+$objectManager = Bootstrap::getObjectManager();
+/** @var ProductInterfaceFactory $productFactory */
+$productFactory = $objectManager->get(ProductInterfaceFactory::class);
+/** @var DataObjectHelper $dataObjectHelper */
+$dataObjectHelper = Bootstrap::getObjectManager()->get(DataObjectHelper::class);
+/** @var ProductRepositoryInterface $productRepository */
+$productRepository = $objectManager->get(ProductRepositoryInterface::class);
+
+$product = $productFactory->create();
+$productData = [
+    ProductInterface::TYPE_ID => Type::TYPE_SIMPLE,
+    ProductInterface::ATTRIBUTE_SET_ID => 4,
+    ProductInterface::SKU => 'simple_product',
+    ProductInterface::NAME => 'Simple Product',
+    ProductInterface::PRICE => 20,
+    ProductInterface::VISIBILITY => Visibility::VISIBILITY_BOTH,
+    ProductInterface::STATUS => Status::STATUS_ENABLED,
+];
+$dataObjectHelper->populateWithArray($product, $productData, ProductInterface::class);
+/** Out of interface */
+$product
+    ->setWebsiteIds([1])
+    ->setStockData([
+        'qty' => 85.5,
+        'is_in_stock' => true,
+        'manage_stock' => true,
+        'is_qty_decimal' => true
+    ]);
+$productRepository->save($product);

dev/tests/integration/testsuite/Magento/AuthorizenetGraphQl/_files/simple_product_authorizenet_rollback.php

@@ -0,0 +1,7 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+require __DIR__ . '/../../GraphQl/Catalog/_files/simple_product_rollback.php';