AC-10634: setMethods replaced with onlyMethods() or addMethods()

Author: nishant04412

app/code/Magento/Catalog/Test/Unit/Model/Entity/AttributeTest.php

@@ -156,7 +156,7 @@ class AttributeTest extends TestCase
     protected function setUp(): void
     {
         $this->contextMock = $this->getMockBuilder(Context::class)
-            ->setMethods(['getCacheManager', 'getEventDispatcher'])
+            ->onlyMethods(['getCacheManager', 'getEventDispatcher'])
             ->disableOriginalConstructor()
             ->getMock();
         $this->registryMock = $this->getMockBuilder(Registry::class)
@@ -174,7 +174,7 @@ protected function setUp(): void
             ->disableOriginalConstructor()
             ->getMock();
         $this->typeFactoryMock = $this->getMockBuilder(TypeFactory::class)
-            ->setMethods(['create'])
+            ->onlyMethods(['create'])
             ->disableOriginalConstructor()
             ->getMock();
         $this->storeManagerMock = $this->getMockBuilder(StoreManagerInterface::class)
@@ -187,7 +187,7 @@ protected function setUp(): void
             ->getMock();
         $this->attributeOptionFactoryMock =
             $this->getMockBuilder(AttributeOptionInterfaceFactory::class)
-                ->setMethods(['create'])
+                ->onlyMethods(['create'])
                 ->disableOriginalConstructor()
                 ->getMock();
         $this->dataObjectProcessorMock = $this->getMockBuilder(DataObjectProcessor::class)
@@ -211,7 +211,8 @@ protected function setUp(): void
         );
 
         $this->resourceMock = $this->getMockBuilder(AbstractResource::class)
-            ->setMethods(['_construct', 'getConnection', 'getIdFieldName', 'saveInSetIncluding'])
+            ->addMethods(['getIdFieldName', 'saveInSetIncluding'])
+            ->onlyMethods(['_construct', 'getConnection'])
             ->getMockForAbstractClass();
         $this->cacheManager = $this->getMockBuilder(CacheInterface::class)
             ->getMock();
@@ -226,6 +227,7 @@ protected function setUp(): void
             ->method('getEventDispatcher')
             ->willReturn($this->eventDispatcher);
         $objectManagerHelper = new ObjectManagerHelper($this);
+        $objectManagerHelper->prepareObjectManager();
         $this->attribute = $objectManagerHelper->getObject(
             Attribute::class,
             [

app/code/Magento/Catalog/Test/Unit/Model/Product/Type/AbstractTypeTest.php

@@ -48,18 +48,19 @@ protected function setUp(): void
         $this->model = $this->objectManagerHelper->getObject(Simple::class);
 
         $this->product = $this->getMockBuilder(Product::class)
-            ->setMethods(['getHasOptions', '__sleep', 'getResource', 'getStatus'])
+            ->addMethods(['getHasOptions'])
+            ->onlyMethods(['__sleep', 'getResource', 'getStatus'])
             ->disableOriginalConstructor()
             ->getMock();
         $this->productResource = $this->getMockBuilder(\Magento\Catalog\Model\ResourceModel\Product::class)
-            ->setMethods(['getSortedAttributes', 'loadAllAttributes'])
+            ->onlyMethods(['getSortedAttributes', 'loadAllAttributes'])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
 
         $this->product->expects($this->any())->method('getResource')->willReturn($this->productResource);
 
         $this->attribute = $this->getMockBuilder(Attribute::class)
-            ->setMethods(['getGroupSortPath', 'getSortPath'])
+            ->addMethods(['getGroupSortPath', 'getSortPath'])
             ->disableOriginalConstructor()
             ->getMock();
     }
@@ -106,7 +107,7 @@ public function testAttributesCompare($attr1, $attr2, $expectedResult)
     /**
      * @return array
      */
-    public function attributeCompareProvider()
+    public static function attributeCompareProvider()
     {
         return [
             [2, 2, 0],

app/code/Magento/Catalog/Test/Unit/Model/Product/Website/ReadHandlerTest.php

@@ -32,7 +32,7 @@ protected function setUp(): void
             ->disableOriginalConstructor()
             ->getMock();
         $this->extensionAttributesMock = $this->getMockBuilder(ProductExtensionInterface::class)
-            ->setMethods(['setWebsiteIds', 'getWebsiteIds'])
+            ->addMethods(['setWebsiteIds', 'getWebsiteIds'])
             ->disableArgumentCloning()
             ->getMockForAbstractClass();
         $this->readHandler = new ReadHandler($this->websiteLinkMock);

app/code/Magento/Catalog/Test/Unit/Model/ProductRender/FormattedPriceInfoBuilderTest.php

@@ -53,11 +53,11 @@ public function testBuild()
 
         $formattedPriceInfoInterfaceMock = $this->getMockBuilder(FormattedPriceInfoInterface::class)
             ->disableOriginalConstructor()
-            ->setMethods(['setData'])
+            ->addMethods(['setData'])
             ->getMockForAbstractClass();
         $priceInfoMock = $this->getMockBuilder(PriceInfoInterface::class)
             ->disableOriginalConstructor()
-            ->setMethods(['getData'])
+            ->addMethods(['getData'])
             ->getMockForAbstractClass();
         $priceInfoMock->expects($this->any())
             ->method('getData')

app/code/Magento/Catalog/Test/Unit/Model/ProductRepository/MediaGalleryProcessorTest.php

@@ -147,7 +147,7 @@ public function testProcessMediaGallery(): void
         //verify new entries
         $contentDataObject = $this->getMockBuilder(ImageContent::class)
             ->disableOriginalConstructor()
-            ->setMethods(null)
+            ->onlyMethods([])
             ->getMock();
         $this->contentFactoryMock->expects($this->once())->method('create')->willReturn($contentDataObject);
         $this->imageProcessorMock->expects($this->once())->method('processImageContent')->willReturn($absolutePath);

app/code/Magento/Catalog/Test/Unit/Model/ProductRepositoryTest.php

@@ -1404,7 +1404,7 @@ public function testSaveExistingWithNewMediaGalleryEntries(): void
         //verify new entries
         $contentDataObject = $this->getMockBuilder(ImageContent::class)
             ->disableOriginalConstructor()
-            ->setMethods(null)
+            ->onlyMethods([])
             ->getMock();
         $this->contentFactory->expects($this->once())
             ->method('create')

app/code/Magento/Catalog/Test/Unit/Model/ResourceModel/MediaImageDeleteProcessorTest.php

@@ -70,27 +70,27 @@ protected function setUp(): void
 
         $this->productMock = $this->getMockBuilder(Product::class)
             ->disableOriginalConstructor()
-            ->setMethods(['getId', 'getMediaGalleryImages'])
+            ->onlyMethods(['getId', 'getMediaGalleryImages'])
             ->getMock();
 
         $this->imageConfig = $this->getMockBuilder(MediaConfig::class)
             ->disableOriginalConstructor()
-            ->setMethods(['getBaseMediaUrl', 'getMediaUrl', 'getBaseMediaPath', 'getMediaPath'])
+            ->onlyMethods(['getBaseMediaUrl', 'getMediaUrl', 'getBaseMediaPath', 'getMediaPath'])
             ->getMock();
 
         $this->mediaDirectory = $this->getMockBuilder(Filesystem::class)
             ->disableOriginalConstructor()
-            ->setMethods(['getRelativePath', 'isFile', 'delete'])
+            ->addMethods(['getRelativePath', 'isFile', 'delete'])
             ->getMock();
 
         $this->imageProcessor = $this->getMockBuilder(Processor::class)
             ->disableOriginalConstructor()
-            ->setMethods(['removeImage'])
+            ->onlyMethods(['removeImage'])
             ->getMock();
 
         $this->productGallery = $this->getMockBuilder(Gallery::class)
             ->disableOriginalConstructor()
-            ->setMethods(['deleteGallery', 'countImageUses'])
+            ->onlyMethods(['deleteGallery', 'countImageUses'])
             ->getMock();
 
         $this->mediaImageDeleteProcessor = $this->objectManager->getObject(
@@ -133,8 +133,10 @@ public function testExecuteCategoryProductMediaDelete(
 
         $this->mediaDirectory->expects($this->any())
             ->method('getRelativePath')
-            ->withConsecutive([$productImages[0]->getFile()], [$productImages[1]->getFile()])
-            ->willReturnOnConsecutiveCalls($productImages[0]->getPath(), $productImages[1]->getPath());
+            ->willReturnCallback(fn($param) => match ([$param]) {
+                [$productImages[0]->getFile()] => $productImages[0]->getPath(),
+                [$productImages[1]->getFile()] => $productImages[1]->getPath()
+            });
 
         $this->productGallery->expects($this->any())
             ->method('countImageUses')
@@ -154,7 +156,7 @@ public function testExecuteCategoryProductMediaDelete(
     /**
      * @return array
      */
-    public function executeCategoryProductMediaDeleteDataProvider(): array
+    public static function executeCategoryProductMediaDeleteDataProvider(): array
     {
         $imageDirectoryPath = '/media/dir1/dir2/catalog/product/';
         $image1FilePath = '/test/test1.jpg';

app/code/Magento/Catalog/Test/Unit/Observer/SetSpecialPriceStartDateTest.php

@@ -71,12 +71,12 @@ protected function setUp(): void
 
         $this->eventMock = $this->getMockBuilder(Event::class)
             ->disableOriginalConstructor()
-            ->setMethods(['getProduct'])
+            ->addMethods(['getProduct'])
             ->getMock();
 
         $this->productMock = $this->getMockBuilder(Product::class)
             ->disableOriginalConstructor()
-            ->setMethods(['getSpecialPrice', 'getSpecialFromDate', 'setData'])
+            ->onlyMethods(['getSpecialPrice', 'getSpecialFromDate', 'setData'])
             ->getMock();
 
         $this->observer = $this->objectManager->getObject(

app/code/Magento/Catalog/Test/Unit/Plugin/Model/AttributeSetRepository/RemoveProductsTest.php

@@ -39,7 +39,7 @@ protected function setUp(): void
         $objectManager = new ObjectManager($this);
         $this->collectionFactory = $this->getMockBuilder(CollectionFactory::class)
             ->disableOriginalConstructor()
-            ->setMethods(['create'])
+            ->onlyMethods(['create'])
             ->getMock();
         $this->testSubject = $objectManager->getObject(
             RemoveProducts::class,
@@ -77,7 +77,7 @@ public function testAfterDelete()
 
         /** @var AttributeSetInterface|MockObject $attributeSet */
         $attributeSet = $this->getMockBuilder(AttributeSetInterface::class)
-            ->setMethods(['getId'])
+            ->addMethods(['getId'])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $attributeSet->expects(self::once())

app/code/Magento/Catalog/Test/Unit/Ui/Component/FilterFactoryTest.php

@@ -73,7 +73,7 @@ public function testCreateWithUseSourceAttribute()
     {
         $contextMock = $this->getMockForAbstractClass(ContextInterface::class);
         $attributeMock = $this->getMockBuilder(ProductAttributeInterface::class)
-            ->setMethods(['usesSource', 'getSource'])
+            ->addMethods(['usesSource', 'getSource'])
             ->getMockForAbstractClass();
         $attributeMock->method('getAttributeCode')->willReturn(self::STUB_ATTRIBUTE['attribute_code']);
         $attributeMock->method('getDefaultFrontendLabel')