MFTF Stability control

 - last round

Author: okolesnyk

app/code/Magento/CheckoutAgreements/Test/Mftf/ActionGroup/AdminOpenEditPageTermsConditionsByNameActionGroup.xml

@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AdminOpenEditPageTermsConditionsByNameActionGroup">
+        <annotations>
+            <description>Opens Edit Page of Terms and Conditions By Provided Name</description>
+        </annotations>
+        <arguments>
+            <argument name="termName" type="string"/>
+        </arguments>
+
+        <fillField selector="{{AdminTermGridSection.filterByTermName}}" userInput="{{termName}}" stepKey="fillTermNameFilter"/>
+        <click selector="{{AdminTermGridSection.searchButton}}" stepKey="clickSearchButton"/>
+        <waitForPageLoad stepKey="waitForPageLoad" />
+        <grabAttributeFrom selector="{{AdminTermGridSection.firstRow}}" userInput="title" stepKey="termsEditUrl" />
+        <amOnUrl url="{$termsEditUrl}" stepKey="openTermsEditPage" />
+        <waitForPageLoad stepKey="waitForEditTermPageLoad"/>
+    </actionGroup>
+</actionGroups>

app/code/Magento/CheckoutAgreements/Test/Mftf/Section/AdminTermGridSection.xml

@@ -11,6 +11,7 @@
         <element name="searchButton" type="button" selector="//div[contains(@class,'admin__data-grid-header')]//div[contains(@class,'admin__filter-actions')]/button[1]"/>
         <element name="resetButton" type="button" selector="//div[contains(@class,'admin__data-grid-header')]//div[contains(@class,'admin__filter-actions')]/button[2]"/>
         <element name="filterByTermName" type="input" selector="#agreementGrid_filter_name"/>
+        <element name="firstRow" type="block" selector=".data-grid>tbody>tr"/>
         <element name="firstRowConditionName" type="text" selector=".data-grid>tbody>tr>td.col-name"/>
         <element name="firstRowConditionId" type="text" selector=".data-grid>tbody>tr>td.col-id.col-agreement_id"/>
         <element name="successMessage" type="text" selector=".message-success"/>

app/code/Magento/CheckoutAgreements/Test/Mftf/Test/AdminUpdateDisabledHtmlTermEntityTest.xml

@@ -32,7 +32,7 @@
             <deleteData createDataKey="createProduct" stepKey="deletedProduct"/>
 
             <actionGroup ref="AdminTermsConditionsOpenGridActionGroup" stepKey="openTermsGridToDelete"/>
-            <actionGroup ref="AdminTermsConditionsEditTermByNameActionGroup" stepKey="openTermToDelete">
+            <actionGroup ref="AdminOpenEditPageTermsConditionsByNameActionGroup" stepKey="openTermToDelete">
                 <argument name="termName" value="{{activeTextTerm.name}}"/>
             </actionGroup>
             <actionGroup ref="AdminTermsConditionsDeleteTermByNameActionGroup" stepKey="deleteOpenedTerm"/>

app/code/Magento/Sales/Test/Mftf/ActionGroup/NavigateToNewOrderPageNewCustomerActionGroup.xml

@@ -23,6 +23,12 @@
         <click selector="{{AdminOrdersGridSection.createNewOrder}}" stepKey="clickCreateNewOrder"/>
         <click selector="{{AdminOrderFormActionSection.CreateNewCustomer}}" stepKey="clickCreateCustomer"/>
         <waitForPageLoad stepKey="waitForPageLoaded" />
+        <!--
+            Adding wait for 5 seconds to make sure AdminOrderStoreScopeTreeSection.storeForOrder(storeView.name)
+            renders properly. Unfortunately can not add waitForElement because in some scenarios where this action group
+            is used the step with Store selection is absent. That is why click is conditional.
+        -->
+        <wait time="5" stepKey="wait" />
         <conditionalClick selector="{{AdminOrderStoreScopeTreeSection.storeForOrder(storeView.name)}}" dependentSelector="{{AdminOrderStoreScopeTreeSection.storeForOrder(storeView.name)}}" visible="true" stepKey="selectStoreViewIfAppears"/>
         <waitForPageLoad stepKey="waitForCreateOrderPageLoadAfterStoreSelect"/>
         <see selector="{{AdminHeaderSection.pageTitle}}" userInput="Create New Order" stepKey="seeNewOrderPageTitle"/>