Skip to content

Commit 859bb70

Browse files
committed
MAGETWO-96406: [2.3.x] Swatch Attribute is not displayed in the Widget CMS
- Added fixes based on comments
1 parent f50d5ce commit 859bb70

File tree

5 files changed

+8
-5
lines changed

5 files changed

+8
-5
lines changed

app/code/Magento/Cms/Test/Mftf/ActionGroup/CreateNewPageWithWidgetActionGroup.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
<click selector="{{WidgetSection.RuleParam}}" stepKey="clickToAddRuleParam"/>
3131
<click selector="{{WidgetSection.Chooser}}" stepKey="clickToSelectFromList"/>
3232
<waitForPageLoad stepKey="waitForPageLoad2"/>
33+
<click selector="{{WidgetSection.RuleParamListExpander('1')}}" stepKey="expandRootCategory"/>
3334
<click selector="{{WidgetSection.PreCreateCategory(category)}}" stepKey="selectPreCategory" />
3435
<click selector="{{WidgetSection.InsertWidget}}" stepKey="clickToSaveInsertedWidget"/>
3536
<waitForPageLoad stepKey="waitForPageLoad3"/>

app/code/Magento/Cms/Test/Mftf/Section/TinyMCESection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@
101101
<element name="RuleParamSelect" type="select" selector="//ul[contains(@class,'rule-param-children')]/li[{{arg1}}]//*[contains(@class,'rule-param')][{{arg2}}]//select" parameterized="true"/>
102102
<element name="RuleParamInput" type="input" selector="//ul[contains(@class,'rule-param-children')]/li[{{arg1}}]//*[contains(@class,'rule-param')][{{arg2}}]//input" parameterized="true"/>
103103
<element name="RuleParamLabel" type="input" selector="//ul[contains(@class,'rule-param-children')]/li[{{arg1}}]//*[contains(@class,'rule-param')][{{arg2}}]//a" parameterized="true"/>
104+
<element name="RuleParamListExpander" selector="//div[@class='rule-chooser']//ul[contains(@class,'x-tree-root')]//li[{{arg3}}]//img[contains(@class,'x-tree-elbow-end-plus')]" parameterized="true"/>
104105
<element name="Chooser" type="button" selector="//img[@title='Open Chooser']"/>
105106
<element name="PageSize" type="input" selector="input[name='parameters[page_size]']"/>
106107
<element name="ProductAttribute" type="multiselect" selector="select[name='parameters[show_attributes][]']" />

app/code/Magento/ConfigurableProduct/Test/Mftf/Section/AdminNewAttributePanelSection.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
<element name="visibleOnCatalogPagesOnStorefront" type="select" selector="#is_visible_on_front"/>
1717
<element name="useInProductListing" type="select" selector="#used_in_product_listing"/>
1818
<element name="usedForStoringInProductListing" type="select" selector="#used_for_sort_by"/>
19+
<element name="storefrontPropertiesTab" selector="#front_fieldset-wrapper"/>
20+
<element name="storefrontPropertiesTitle" selector="//span[text()='Storefront Properties']"/>
1921
<element name="container" type="text" selector="#create_new_attribute"/>
2022
<element name="saveAttribute" type="button" selector="#save"/>
2123
<element name="newAttributeIFrame" type="iframe" selector="create_new_attribute_container"/>

app/code/Magento/Swatches/Test/Mftf/ActionGroup/AddSwatchToProductActionGroup.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,8 @@
7070
</arguments>
7171

7272
<!-- Go to Storefront Properties tab -->
73-
<scrollToTopOfPage stepKey="scrollToTop" after="fillDefaultStoreLabel2"/>
74-
<click selector="#front_fieldset-wrapper" stepKey="goToStorefrontPropertiesTab" after="scrollToTop"/>
75-
<waitForElementVisible selector="//span[text()='Storefront Properties']" stepKey="waitTabLoad" after="goToStorefrontPropertiesTab"/>
73+
<click selector="{{AdminNewAttributePanel.storefrontPropertiesTab}}" stepKey="goToStorefrontPropertiesTab" after="fillDefaultStoreLabel2"/>
74+
<waitForElementVisible selector="{{AdminNewAttributePanel.storefrontPropertiesTitle}}" stepKey="waitTabLoad" after="goToStorefrontPropertiesTab"/>
7675
<selectOption selector="{{AdminNewAttributePanel.useInSearch}}" stepKey="switchOnUsInSearch" userInput="Yes" after="waitTabLoad"/>
7776
<selectOption selector="{{AdminNewAttributePanel.visibleInAdvancedSearch}}" stepKey="switchOnVisibleInAdvancedSearch" userInput="Yes" after="switchOnUsInSearch"/>
7877
<selectOption selector="{{AdminNewAttributePanel.comparableOnStorefront}}" stepKey="switchOnComparableOnStorefront" userInput="Yes" after="switchOnVisibleInAdvancedSearch"/>

app/code/Magento/Swatches/Test/Mftf/Test/StorefrontSwatchAttributesDisplayInWidgetCMSTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232
<argument name="ProductAttribute" value="visualSwatchAttribute"/>
3333
</actionGroup>
3434
<!--delete root category-->
35-
<amOnPage url="{{AdminCategoryPage.url}}" stepKey="navigateToCategoryPageAfterCLIReindexCommand"/>
36-
<waitForPageLoad time="30" stepKey="waitForPageCategoryLoadAfterCLIReindexCommand"/>
35+
<amOnPage url="{{AdminCategoryPage.url}}" stepKey="navigateToCategoryPage"/>
36+
<waitForPageLoad time="30" stepKey="waitForPageCategoryLoad"/>
3737
<click selector="{{AdminCategorySidebarTreeSection.categoryInTree('$$createRootCategory.name$$')}}" stepKey="clickOnDefaultRootCategory"/>
3838
<waitForPageLoad stepKey="waitForPageDefaultCategoryEditLoad" />
3939
<seeElement selector="{{AdminCategoryMainActionsSection.DeleteButton}}" stepKey="assertDeleteButtonIsPresent1"/>

0 commit comments

Comments
 (0)