added logic if placeholder is overridden, unblock test.

Author: VoronoyAlexandr

app/code/Magento/CatalogGraphQl/Model/Resolver/Product/ProductImage/Url.php

@@ -9,11 +9,11 @@
 
 use Magento\Catalog\Model\Product;
 use Magento\Catalog\Model\Product\ImageFactory;
+use Magento\CatalogGraphQl\Model\Resolver\Products\DataProvider\Image\Placeholder as PlaceholderProvider;
 use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\GraphQl\Config\Element\Field;
 use Magento\Framework\GraphQl\Query\ResolverInterface;
 use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
-use Magento\Framework\View\Asset\Repository as AssetRepository;
 
 /**
  * Returns product's image url
@@ -25,21 +25,22 @@ class Url implements ResolverInterface
      */
     private $productImageFactory;
     /**
-     * @var AssetRepository
+     * @var PlaceholderProvider
      */
-    private $assetRepository;
+    private $_placeholderProvider;
 
     /**
      * Url constructor.
      * @param ImageFactory $productImageFactory
-     * @param AssetRepository $assetRepository
+     * @param PlaceholderProvider $placeholderProvider
      */
     public function __construct(
         ImageFactory $productImageFactory,
-        AssetRepository $assetRepository
+        PlaceholderProvider $placeholderProvider
+
     ) {
         $this->productImageFactory = $productImageFactory;
-        $this->assetRepository = $assetRepository;
+        $this->_placeholderProvider = $placeholderProvider;
     }
 
     /**
@@ -68,26 +69,23 @@ public function resolve(
     }
 
     /**
-     * Get image url
+     * Get image URL
      *
      * @param string $imageType
-     * @param string|null $imagePath Null if image is not set
+     * @param string|null $imagePath
      * @return string
+     * @throws \Exception
      */
     private function getImageUrl(string $imageType, ?string $imagePath): string
     {
         $image = $this->productImageFactory->create();
         $image->setDestinationSubdir($imageType)
             ->setBaseFile($imagePath);
 
-        $imageUrl = $image->isBaseFilePlaceholder()
-            ? $this->assetRepository->createAsset(
-                "Magento_Catalog::images/product/placeholder/{$imageType}.jpg",
-                ['area' => \Magento\Framework\App\Area::AREA_FRONTEND]
-            )
-                ->getUrl()
-            : $image->getUrl();
+        if ($image->isBaseFilePlaceholder()) {
+            return $this->_placeholderProvider->getPlaceholder($imageType);
+        }
 
-        return $imageUrl;
+        return $image->getUrl();
     }
 }

app/code/Magento/CatalogGraphQl/Model/Resolver/Products/DataProvider/Image/Placeholder.php

@@ -0,0 +1,109 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\CatalogGraphQl\Model\Resolver\Products\DataProvider\Image;
+
+use Magento\Catalog\Model\View\Asset\PlaceholderFactory;
+use Magento\Framework\App\Config\ScopeConfigInterface;
+use Magento\Framework\View\Asset\Repository as AssetRepository;
+use Magento\Framework\View\Design\Theme\ThemeProviderInterface;
+use Magento\Store\Model\StoreManagerInterface;
+
+/**
+ * Class Placeholder
+ * @package Magento\CatalogGraphQl\Model\Resolver\Products\DataProvider\Image
+ */
+class Placeholder
+{
+    /**
+     * @var PlaceholderFactory
+     */
+    private $_placeholderFactory;
+    /**
+     * @var AssetRepository
+     */
+    private $_assetRepository;
+    /**
+     * @var ScopeConfigInterface
+     */
+    private $_scopeConfig;
+    /**
+     * @var StoreManagerInterface
+     */
+    private $_storeManager;
+    /**
+     * @var ThemeProviderInterface
+     */
+    private $_themeProvider;
+
+    /**
+     * Placeholder constructor.
+     * @param PlaceholderFactory $placeholderFactory
+     * @param AssetRepository $assetRepository
+     * @param ScopeConfigInterface $scopeConfig
+     * @param StoreManagerInterface $storeManager
+     * @param ThemeProviderInterface $themeProvider
+     */
+    public function __construct(
+        PlaceholderFactory $placeholderFactory,
+        AssetRepository $assetRepository,
+        ScopeConfigInterface $scopeConfig,
+        StoreManagerInterface $storeManager,
+        ThemeProviderInterface $themeProvider
+    ) {
+        $this->_placeholderFactory = $placeholderFactory;
+        $this->_assetRepository = $assetRepository;
+        $this->_scopeConfig = $scopeConfig;
+        $this->_storeManager = $storeManager;
+        $this->_themeProvider = $themeProvider;
+    }
+
+    /**
+     * Get placeholder
+     *
+     * @param $imageType
+     * @return string
+     * @throws \Magento\Framework\Exception\NoSuchEntityException
+     */
+    public function getPlaceholder($imageType): string
+    {
+        $imageAsset = $this->_placeholderFactory->create(['type' => $imageType]);
+
+        // check if placeholder defined in config
+        if ($imageAsset->getFilePath()) {
+            return $imageAsset->getUrl();
+        }
+
+        return $this->_assetRepository->createAsset(
+            "Magento_Catalog::images/product/placeholder/{$imageType}.jpg",
+            $this->getThemeData()
+        )->getUrl();
+    }
+
+    /**
+     * Get theme model
+     *
+     * @return mixed
+     * @throws \Magento\Framework\Exception\NoSuchEntityException
+     */
+    public function getThemeData()
+    {
+        $themeId = $this->_scopeConfig->getValue(
+            \Magento\Framework\View\DesignInterface::XML_PATH_THEME_ID,
+            \Magento\Store\Model\ScopeInterface::SCOPE_STORE,
+            $this->_storeManager->getStore()->getId()
+        );
+
+        /** @var $theme \Magento\Framework\View\Design\ThemeInterface */
+        $theme = $this->_themeProvider->getThemeById($themeId);
+
+        $data = $theme->getData();
+        $data['themeModel'] = $theme;
+
+        return $data;
+    }
+}

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductImageTest.php

@@ -51,7 +51,6 @@ public function testProductWithBaseImage()
      */
     public function testProductWithoutBaseImage()
     {
-        $this->markTestIncomplete('https://github.com/magento/graphql-ce/issues/239');
         $productSku = 'simple';
         $query = <<<QUERY
 {