magento-partners/magento2ce#2543: Fixed static test failures

Author: Stanislav Idolov

app/code/Magento/Customer/Model/Config/Backend/Address/Street.php

@@ -97,8 +97,8 @@ public function afterDelete()
                 break;
 
             case ScopeConfigInterface::SCOPE_TYPE_DEFAULT:
-                 $attribute->setData('multiline_count', 2);
-                 break;
+                $attribute->setData('multiline_count', 2);
+                break;
         }
         $attribute->save();
         return $result;

app/code/Magento/Translation/Block/Js.php

@@ -10,6 +10,8 @@
 use Magento\Translation\Model\Js\Config;
 
 /**
+ * JS translation block
+ *
  * @api
  * @since 100.0.2
  */
@@ -53,7 +55,7 @@ public function dictionaryEnabled()
     }
 
     /**
-     * gets current js-translation.json timestamp
+     * Gets current js-translation.json timestamp
      *
      * @return string
      */
@@ -63,6 +65,8 @@ public function getTranslationFileTimestamp()
     }
 
     /**
+     * Get translation file path
+     *
      * @return string
      */
     public function getTranslationFilePath()

dev/tests/integration/framework/Magento/TestFramework/Helper/Amqp.php

@@ -58,8 +58,7 @@ public function __construct(
     }
 
     /**
-     * Check that the RabbitMQ instance has the management plugin installed and the api
-     * is available.
+     * Check that the RabbitMQ instance has the management plugin installed and the api is available.
      *
      * @return bool
      */
@@ -92,6 +91,7 @@ public function getExchanges()
     /**
      * Get declared exchange bindings.
      *
+     * @param string $name
      * @return array
      */
     public function getExchangeBindings($name)
@@ -119,6 +119,8 @@ public function getConnections()
     }
 
     /**
+     * Clear Queue
+     *
      * @param string $name
      * @param int $numMessages
      * @return string
@@ -138,7 +140,7 @@ public function clearQueue(string $name, int $numMessages = 50)
     /**
      * Delete connection
      *
-     * @param $name
+     * @param string $name
      * @return string $data
      */
     public function deleteConnection($name)

dev/tests/integration/framework/Magento/TestFramework/MessageQueue/PublisherConsumerController.php

@@ -12,6 +12,9 @@
 use Magento\Framework\OsInfo;
 use Magento\TestFramework\Helper\Amqp;
 
+/**
+ * Publisher Consumer Controller
+ */
 class PublisherConsumerController
 {
     /**
@@ -49,6 +52,16 @@ class PublisherConsumerController
      */
     private $amqpHelper;
 
+    /**
+     * PublisherConsumerController constructor.
+     * @param PublisherInterface $publisher
+     * @param OsInfo $osInfo
+     * @param Amqp $amqpHelper
+     * @param string $logFilePath
+     * @param array $consumers
+     * @param array $appInitParams
+     * @param null|int $maxMessages
+     */
     public function __construct(
         PublisherInterface $publisher,
         OsInfo $osInfo,
@@ -75,17 +88,7 @@ public function __construct(
      */
     public function initialize()
     {
-        if ($this->osInfo->isWindows()) {
-            throw new EnvironmentPreconditionException(
-                "This test relies on *nix shell and should be skipped in Windows environment."
-            );
-        }
-
-        if (!$this->amqpHelper->isAvailable()) {
-            throw new PreconditionFailedException(
-                'This test relies on RabbitMQ Management Plugin.'
-            );
-        }
+        $this->validateEnvironmentPreconditions();
 
         $connections = $this->amqpHelper->getConnections();
         foreach (array_keys($connections) as $connectionName) {
@@ -115,6 +118,27 @@ public function initialize()
         }
     }
 
+    /**
+     * Validate environment preconditions
+     *
+     * @throws EnvironmentPreconditionException
+     * @throws PreconditionFailedException
+     */
+    private function validateEnvironmentPreconditions()
+    {
+        if ($this->osInfo->isWindows()) {
+            throw new EnvironmentPreconditionException(
+                "This test relies on *nix shell and should be skipped in Windows environment."
+            );
+        }
+
+        if (!$this->amqpHelper->isAvailable()) {
+            throw new PreconditionFailedException(
+                'This test relies on RabbitMQ Management Plugin.'
+            );
+        }
+    }
+
     /**
      * Stop Consumers
      */
@@ -128,6 +152,8 @@ public function stopConsumers()
     }
 
     /**
+     * Get Consumers ProcessIds
+     *
      * @return array
      */
     public function getConsumersProcessIds()
@@ -140,6 +166,8 @@ public function getConsumersProcessIds()
     }
 
     /**
+     * Get Consumer ProcessIds
+     *
      * @param string $consumer
      * @return string[]
      */
@@ -174,8 +202,10 @@ private function getConsumerStartCommand($consumer, $withEnvVariables = false)
     }
 
     /**
+     * Wait for asynchronous result
+     *
      * @param callable $condition
-     * @param $params
+     * @param array $params
      * @throws PreconditionFailedException
      */
     public function waitForAsynchronousResult(callable $condition, $params)
@@ -192,6 +222,8 @@ public function waitForAsynchronousResult(callable $condition, $params)
     }
 
     /**
+     * Get publisher
+     *
      * @return PublisherInterface
      */
     public function getPublisher()

lib/internal/Magento/Framework/Reflection/TypeProcessor.php

@@ -562,7 +562,7 @@ public function getAliasMapping(ClassReflection $sourceClass): array
     /**
      * Return true if the passed type is a simple type
      *
-     * eg.:
+     * Eg.:
      * Return true with; array, string, ...
      * Return false with: SomeClassName
      *
@@ -577,7 +577,7 @@ public function isSimpleType(string $typeName): bool
     /**
      * Get basic type for a class name
      *
-     * eg.:
+     * Eg.:
      * SomeClassName[] => SomeClassName
      *
      * @param string $className
@@ -592,7 +592,7 @@ public function getBasicClassName(string $className): string
     /**
      * Return true if it is a FQ class name
      *
-     * eg.:
+     * Eg.:
      * SomeClassName => false
      * \My\NameSpace\SomeClassName => true
      *