🔃 [Magento Community Engineering] Community Contributions - 2.3-develop daily delivery

Accepted Community Pull Requests:
 - #24559: Added newline to the end of var/report reports output (by @aepod)
 - #24549: Add digits validation for cron system configuration (by @ravi-chandra3197)
 - #24534: Refactor isSubscribed method to return the output of the expression (by @will-in-wi)
 - #24279: Update Magento_Authorizenet ReadMe (by @diazwatson)


Fixed GitHub Issues:
 - #24558: Newline Missing from Reports in var/reports (reported by @aepod) has been fixed in #24559 by @aepod in 2.3-develop branch
   Related commits:
     1. fec58c2
     2. cbbdee7

Author: magento-engcom-team

app/code/Magento/Authorizenet/README.md

@@ -1 +1,42 @@
+# Magento_Authorizenet module
+
 The Magento_Authorizenet module implements the integration with the Authorize.Net payment gateway and makes the latter available as a payment method in Magento.
+
+## Extensibility
+
+Extension developers can interact with the Magento_Authorizenet module. For more information about the Magento extension mechanism, see [Magento plug-ins](https://devdocs.magento.com/guides/v2.3/extension-dev-guide/plugins.html).
+
+[The Magento dependency injection mechanism](https://devdocs.magento.com/guides/v2.3/extension-dev-guide/depend-inj.html) enables you to override the functionality of the Magento_Authorizenet module.
+
+### Events
+
+This module dispatches the following events:
+
+ - `checkout_directpost_placeOrder` event in the `\Magento\Authorizenet\Controller\Directpost\Payment\Place::placeCheckoutOrder()` method. Parameters:
+   - `result` is a data object (`\Magento\Framework\DataObject` class).
+   - `action` is a controller object (`\Magento\Authorizenet\Controller\Directpost\Payment\Place`).
+ 
+ - `order_cancel_after` event in the `\Magento\Authorizenet\Model\Directpost::declineOrder()` method. Parameters:
+   - `order` is an order object (`\Magento\Sales\Model\Order` class).
+   
+
+This module observes the following events:
+
+ - `checkout_submit_all_after` event in the `Magento\Authorizenet\Observer\SaveOrderAfterSubmitObserver` file.
+ - `checkout_directpost_placeOrder` event in the `Magento\Authorizenet\Observer\AddFieldsToResponseObserver` file.
+
+For information about events in Magento 2, see [Events and observers](http://devdocs.magento.com/guides/v2.3/extension-dev-guide/events-and-observers.html#events).
+
+### Layouts
+
+This module introduces the following layouts and layout handles in the `view/adminhtml/layout` directory:
+
+- `adminhtml_authorizenet_directpost_payment_redirect`
+
+This module introduces the following layouts and layout handles in the `view/frontend/layout` directory:
+
+- `authorizenet_directpost_payment_backendresponse`
+- `authorizenet_directpost_payment_redirect`
+- `authorizenet_directpost_payment_response`
+
+For more information about layouts in Magento 2, see the [Layout documentation](https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/layouts/layout-overview.html).

app/code/Magento/Cron/etc/adminhtml/system.xml

@@ -15,21 +15,27 @@
                     <label>Cron configuration options for group: </label>
                     <field id="schedule_generate_every" translate="label" type="text" sortOrder="10" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
                         <label>Generate Schedules Every</label>
+                        <validate>validate-zero-or-greater validate-digits</validate>
                     </field>
                     <field id="schedule_ahead_for" translate="label" type="text" sortOrder="20" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
                         <label>Schedule Ahead for</label>
+                        <validate>validate-zero-or-greater validate-digits</validate>
                     </field>
                     <field id="schedule_lifetime" translate="label" type="text" sortOrder="30" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
                         <label>Missed if Not Run Within</label>
+                        <validate>validate-zero-or-greater validate-digits</validate>
                     </field>
                     <field id="history_cleanup_every" translate="label" type="text" sortOrder="40" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
                         <label>History Cleanup Every</label>
+                        <validate>validate-zero-or-greater validate-digits</validate>
                     </field>
                     <field id="history_success_lifetime" translate="label" type="text" sortOrder="50" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
                         <label>Success History Lifetime</label>
+                        <validate>validate-zero-or-greater validate-digits</validate>
                     </field>
                     <field id="history_failure_lifetime" translate="label" type="text" sortOrder="60" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
                         <label>Failure History Lifetime</label>
+                        <validate>validate-zero-or-greater validate-digits</validate>
                     </field>
                     <field id="use_separate_process" translate="label" type="select" sortOrder="70" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1">
                         <label>Use Separate Process</label>

app/code/Magento/Newsletter/Model/Subscriber.php

@@ -353,11 +353,7 @@ public function isStatusChanged()
      */
     public function isSubscribed()
     {
-        if ($this->getId() && $this->getStatus() == self::STATUS_SUBSCRIBED) {
-            return true;
-        }
-
-        return false;
+        return $this->getId() && (int)$this->getStatus() === self::STATUS_SUBSCRIBED;
     }
 
     /**

pub/errors/processor.php

@@ -489,7 +489,7 @@ public function saveReport($reportData)
             @mkdir($this->_reportDir, 0777, true);
         }
 
-        @file_put_contents($this->_reportFile, $this->serializer->serialize($reportData));
+        @file_put_contents($this->_reportFile, $this->serializer->serialize($reportData). PHP_EOL);
 
         if (isset($reportData['skin']) && self::DEFAULT_SKIN != $reportData['skin']) {
             $this->_setSkin($reportData['skin']);