MAGETWO-95809: Item row total display incorrect value in API response

- Stabilize for working webapi test

Author: YuliyaLabudova

app/code/Magento/Sales/Plugin/DataObjectProcessor.php renamed to app/code/Magento/Sales/Model/Order/Webapi/ChangeOutputArray.php

@@ -5,17 +5,15 @@
  */
 declare(strict_types=1);
 
-namespace Magento\Sales\Plugin;
+namespace Magento\Sales\Model\Order\Webapi;
 
-use Magento\Framework\Reflection\DataObjectProcessor as Subject;
 use Magento\Sales\Api\Data\OrderItemInterface;
-use Magento\Sales\Model\Order\Item as OrderItem;
 use Magento\Sales\Block\Adminhtml\Items\Column\DefaultColumn;
 
 /**
  * Class for changing row total in response.
  */
-class DataObjectProcessor
+class ChangeOutputArray
 {
     /**
      * @var DefaultColumn
@@ -34,21 +32,16 @@ public function __construct(
     /**
      * Changing row total for webapi order item response.
      *
-     * @param Subject $subject
+     * @param OrderItemInterface $dataObject
      * @param array $result
-     * @param mixed $dataObject
      * @return array
-     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function afterBuildOutputDataArray(
-        Subject $subject,
-        $result,
-        $dataObject
-    ) {
-        if ($dataObject instanceof OrderItem) {
-            $result[OrderItemInterface::ROW_TOTAL] = $this->priceRenderer->getTotalAmount($dataObject);
-            $result[OrderItemInterface::BASE_ROW_TOTAL] = $this->priceRenderer->getBaseTotalAmount($dataObject);
-        }
+    public function execute(
+        OrderItemInterface $dataObject,
+        array $result
+    ): array {
+        $result[OrderItemInterface::ROW_TOTAL] = $this->priceRenderer->getTotalAmount($dataObject);
+        $result[OrderItemInterface::BASE_ROW_TOTAL] = $this->priceRenderer->getBaseTotalAmount($dataObject);
 
         return $result;
     }

app/code/Magento/Sales/etc/webapi_rest/di.xml

@@ -16,6 +16,10 @@
         <plugin name="convert_blob_to_string" type="Magento\Sales\Plugin\ShippingLabelConverter" />
     </type>
     <type name="Magento\Framework\Reflection\DataObjectProcessor">
-        <plugin name="change_row_total" type="Magento\Sales\Plugin\DataObjectProcessor" />
+        <arguments>
+            <argument name="processors" xsi:type="array">
+                <item name="\Magento\Sales\Model\Order\Item" xsi:type="object">Magento\Sales\Model\Order\Webapi\ChangeOutputArray\Proxy</item>
+            </argument>
+        </arguments>
     </type>
 </config>

app/code/Magento/Sales/etc/webapi_soap/di.xml

@@ -16,6 +16,10 @@
         <plugin name="convert_blob_to_string" type="Magento\Sales\Plugin\ShippingLabelConverter" />
     </type>
     <type name="Magento\Framework\Reflection\DataObjectProcessor">
-        <plugin name="change_row_total" type="Magento\Sales\Plugin\DataObjectProcessor" />
+        <arguments>
+            <argument name="processors" xsi:type="array">
+                <item name="\Magento\Sales\Model\Order\Item" xsi:type="object">Magento\Sales\Model\Order\Webapi\ChangeOutputArray\Proxy</item>
+            </argument>
+        </arguments>
     </type>
 </config>

lib/internal/Magento/Framework/Reflection/DataObjectProcessor.php

@@ -40,25 +40,33 @@ class DataObjectProcessor
      */
     private $customAttributesProcessor;
 
+    /**
+     * @var array
+     */
+    private $processors;
+
     /**
      * @param MethodsMap $methodsMapProcessor
      * @param TypeCaster $typeCaster
      * @param FieldNamer $fieldNamer
      * @param CustomAttributesProcessor $customAttributesProcessor
      * @param ExtensionAttributesProcessor $extensionAttributesProcessor
+     * @param array $processors
      */
     public function __construct(
         MethodsMap $methodsMapProcessor,
         TypeCaster $typeCaster,
         FieldNamer $fieldNamer,
         CustomAttributesProcessor $customAttributesProcessor,
-        ExtensionAttributesProcessor $extensionAttributesProcessor
+        ExtensionAttributesProcessor $extensionAttributesProcessor,
+        array $processors = []
     ) {
         $this->methodsMapProcessor = $methodsMapProcessor;
         $this->typeCaster = $typeCaster;
         $this->fieldNamer = $fieldNamer;
         $this->extensionAttributesProcessor = $extensionAttributesProcessor;
         $this->customAttributesProcessor = $customAttributesProcessor;
+        $this->processors = $processors;
     }
 
     /**
@@ -121,6 +129,27 @@ public function buildOutputDataArray($dataObject, $dataObjectType)
 
             $outputData[$key] = $value;
         }
+
+        $outputData = $this->changeOutputArray($dataObject, $outputData);
+
+        return $outputData;
+    }
+
+    /**
+     * Change output array if needed.
+     *
+     * @param mixed $dataObject
+     * @param array $outputData
+     * @return array
+     */
+    private function changeOutputArray($dataObject, array $outputData): array
+    {
+        foreach ($this->processors as $dataObjectClassName => $processor) {
+            if ($dataObject instanceof $dataObjectClassName) {
+                $outputData = $processor->execute($dataObject, $outputData);
+            }
+        }
+
         return $outputData;
     }
 }