Fixed Static and Unit Test failures

Author: engcom-Echo

app/code/Magento/Catalog/Ui/Component/Listing/Columns/Thumbnail.php

@@ -9,16 +9,16 @@
 use Magento\Framework\View\Element\UiComponent\ContextInterface;
 
 /**
- * Class Thumbnail
+ * Class prepares Thumbnail
  *
  * @api
  * @since 100.0.2
  */
 class Thumbnail extends \Magento\Ui\Component\Listing\Columns\Column
 {
-    const NAME = 'thumbnail';
+    public const NAME = 'thumbnail';
 
-    const ALT_FIELD = 'name';
+    public const ALT_FIELD = 'name';
 
     /**
      * @var \Magento\Catalog\Helper\Image
@@ -87,8 +87,6 @@ public function prepareDataSource(array $dataSource)
     protected function getAlt($row)
     {
         $altField = $this->getData('config/altField') ?: self::ALT_FIELD;
-        return html_entity_decode($row[$altField],ENT_QUOTES, "UTF-8") ?? null;
-
+        return html_entity_decode($row[$altField], ENT_QUOTES, "UTF-8") ?? null;
     }
 }
-

app/code/Magento/ConfigurableProduct/Model/LinkManagement.php

@@ -9,11 +9,8 @@
 use Magento\Catalog\Api\Data\ProductAttributeMediaGalleryEntryInterfaceFactory;
 use Magento\Catalog\Model\ProductRepository;
 use Magento\Framework\Exception\InputException;
-use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Framework\Exception\StateException;
-use Magento\Catalog\Api\Data\ProductInterface;
-
 
 /**
  * Configurable product link management.
@@ -76,7 +73,7 @@ class LinkManagement implements \Magento\ConfigurableProduct\Api\LinkManagementI
      * @param \Magento\Framework\Api\DataObjectHelper $dataObjectHelper
      * @param \Magento\Catalog\Model\ResourceModel\Eav\AttributeFactory $attributeFactory
      * @param \Magento\Catalog\Model\ProductRepository $mediaGalleryProcessor
-     * @param \Magento\Catalog\Api\Data\ProductInterface $productInterface
+     * @param \Magento\Catalog\Api\Data\ProductAttributeMediaGalleryEntryInterfaceFactory $myModelFactory
      */
     public function __construct(
         \Magento\Catalog\Api\ProductRepositoryInterface $productRepository,
@@ -96,26 +93,11 @@ public function __construct(
         $this->mediaGallery = $mediaGalleryProcessor ?: \Magento\Framework\App\ObjectManager::getInstance()
             ->get(\Magento\Catalog\Model\ProductRepository::class);
         $this->myModelFactory = $myModelFactory ?: \Magento\Framework\App\ObjectManager::getInstance()
-            ->get(\Magento\Catalog\Api\Data\ProductAttributeMediaGalleryEntryInterfaceFactory::class);;
+            ->get(\Magento\Catalog\Api\Data\ProductAttributeMediaGalleryEntryInterfaceFactory::class);
     }
 
-    /**
-     * Process Media gallery data before save product.
-     *
-     * Compare Media Gallery Entries Data with existing Media Gallery
-     * * If Media entry has not value_id set it as new
-     * * If Existing entry 'value_id' absent in Media Gallery set 'removed' flag
-     * * Merge Existing and new media gallery
-     *
-     * @param ProductInterface $product contains only existing media gallery items
-     * @param array $mediaGalleryEntries array which contains all media gallery items
-     * @throws InputException
-     * @throws StateException
-     * @throws LocalizedException
-     */
     /**
      * @inheritdoc
-     * @throws LocalizedException
      */
     public function getChildren($sku)
     {
@@ -152,6 +134,13 @@ public function getChildren($sku)
         }
         return $childrenList;
     }
+
+    /**
+     * Get media entries
+     *
+     * @param array $images
+     * @return array
+     */
     public function getMediaEntries($images)
     {
         $media = $this->myModelFactory->create();
@@ -161,8 +150,8 @@ public function getMediaEntries($images)
             $media->setMediaType($image["media_type"]);
             $media->setLabel($image["label"]);
             $media->setPosition($image["position"]);
-           $media->setDisabled($image["disabled"]);
-           $media->setFile($image["file"]);
+            $media->setDisabled($image["disabled"]);
+            $media->setFile($image["file"]);
             $mediaGalleryEntries[]=$media->getData();
         }
         return $mediaGalleryEntries;
@@ -258,10 +247,12 @@ public function removeChild($sku, $childSku)
      * @return \Magento\ConfigurableProduct\Helper\Product\Options\Factory
      *
      * @deprecated 100.2.0
+     * @see Nothing
      */
     private function getOptionsFactory()
     {
         if (!$this->optionsFactory) {
+            // phpcs:ignore Magento2.PHP.AutogeneratedClassNotInConstructor
             $this->optionsFactory = \Magento\Framework\App\ObjectManager::getInstance()
                 ->get(\Magento\ConfigurableProduct\Helper\Product\Options\Factory::class);
         }

app/code/Magento/ConfigurableProduct/Test/Unit/Model/LinkManagementTest.php

@@ -135,8 +135,11 @@ public function testGetChildren(): void
 
         $this->dataObjectHelperMock->expects($this->once())
             ->method('populateWithArray')
-            ->with($productMock, ['store_id' => 1, 'code' => 10], ProductInterface::class)
-            ->willReturnSelf();
+            ->with(
+                $productMock,
+                ['store_id' => 1, 'code' => 10, 'media_gallery_entries' => []],
+                ProductInterface::class
+            )->willReturnSelf();
 
         $this->productFactory->expects($this->once())
             ->method('create')