Skip to content

Commit 8bb3b5e

Browse files
ScopeConfigInterface can be more than a string
Reverts parts of a5a98df as it restricts @magentoConfigFixture unnecessarily to strings. Neither `Magento\Framework\App\Config\ScopeConfigInterface` nor `Magento\Framework\App\Config` have this limitation. ``` /** * Retrieve config value by path and scope * * @param string $path * @param string $scope * @param null|int|string $scopeCode * @return mixed */ public function getValue( $path = null, $scope = ScopeConfigInterface::SCOPE_TYPE_DEFAULT, $scopeCode = null ) { ```
1 parent 3008324 commit 8bb3b5e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

dev/tests/integration/framework/Magento/TestFramework/Annotation/ConfigFixture.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ protected function _getConfigValue($configPath, $scopeCode = null)
7171
* @param string|null $scopeCode
7272
* @return string|null
7373
*/
74-
protected function getScopeConfigValue(string $configPath, string $scopeType, string $scopeCode = null): ?string
74+
protected function getScopeConfigValue(string $configPath, string $scopeType, string $scopeCode = null)
7575
{
7676
$result = null;
7777
if ($scopeCode !== false) {

0 commit comments

Comments
 (0)