Skip to content

Commit 8c92a5c

Browse files
author
Krishna Kumar
committed
Changes as per the test-cases failed comments
1 parent 5957630 commit 8c92a5c

File tree

5 files changed

+9
-8
lines changed

5 files changed

+9
-8
lines changed

app/code/Magento/LoginAsCustomerGraphQl/composer.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,5 @@
2222
"psr-4": {
2323
"Magento\\LoginAsCustomerGraphQl\\": ""
2424
}
25-
},
26-
"version": "1.0.1"
25+
}
2726
}

app/code/Magento/LoginAsCustomerGraphQl/etc/module.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
99
<module name="Magento_LoginAsCustomerGraphQl">
1010
<sequence>
11+
<module name="Magento_LoginAsCustomer"/>
1112
<module name="Magento_Customer"/>
1213
<module name="Magento_Authorization"/>
1314
<module name="Magento_GraphQl"/>

composer.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@
192192
"magento/module-integration": "*",
193193
"magento/module-layered-navigation": "*",
194194
"magento/module-login-as-customer": "*",
195+
"magento/module-login-as-customer-graph-ql": "*",
195196
"magento/module-login-as-customer-admin-ui": "*",
196197
"magento/module-login-as-customer-api": "*",
197198
"magento/module-login-as-customer-assistance": "*",

dev/tests/api-functional/testsuite/Magento/GraphQl/LoginAsCustomer/GenerateLoginCustomerTokenTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public function testGenerateCustomerValidTokenLoginAsCustomerEnabled()
5656
$mutation,
5757
[],
5858
'',
59-
$this->getAdminHeaderAuthentication('TestAdmin1', 'Zilker777')
59+
$this->getAdminHeaderAuthentication('TestAdmin1', 'Magento777')
6060
);
6161
$this->assertArrayHasKey('generateCustomerTokenAsAdmin', $response);
6262
$this->assertIsArray($response['generateCustomerTokenAsAdmin']);
@@ -73,7 +73,7 @@ public function testGenerateCustomerValidTokenLoginAsCustomerEnabled()
7373
public function testGenerateCustomerValidTokenLoginAsCustomerDisabled()
7474
{
7575
$this->expectException(Exception::class);
76-
$this->expectExceptionMessage("Login as Customer is disabled..");
76+
$this->expectExceptionMessage("Login as Customer is disabled.");
7777

7878
$customerEmail = '[email protected]';
7979

@@ -82,7 +82,7 @@ public function testGenerateCustomerValidTokenLoginAsCustomerDisabled()
8282
$mutation,
8383
[],
8484
'',
85-
$this->getAdminHeaderAuthentication('TestAdmin1', 'Zilker777')
85+
$this->getAdminHeaderAuthentication('TestAdmin1', 'Magento777')
8686
);
8787
}
8888

@@ -151,7 +151,7 @@ public function dataProviderInvalidInfo(): array
151151
return [
152152
'invalid_admin_user_name' => [
153153
'TestAdmin(^%',
154-
'Zilker777',
154+
'Magento777',
155155
156156
'The account sign-in was incorrect or your account is disabled temporarily. ' .
157157
'Please wait and try again later.'
@@ -195,7 +195,7 @@ private function getQuery(string $customerEmail) : string
195195
*/
196196
public function getCustomerHeaderAuthentication(
197197
string $username = '[email protected]',
198-
string $password = 'Zilker777'
198+
string $password = 'Magento777'
199199
): array {
200200
$customerToken = $this->customerTokenService->createCustomerAccessToken($username, $password);
201201

dev/tests/integration/testsuite/Magento/LoginAsCustomer/_files/admin.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
'firstname' => 'test',
1919
'lastname' => 'test',
2020
'email' => '[email protected]',
21-
'password' =>'Zilker777',
21+
'password' =>'Magento777',
2222
'interface_locale' => 'en_US',
2323
'is_active' => 1
2424
];

0 commit comments

Comments
 (0)