Implement updates all properties in updateCustomer mutation

The current schema defines properties that were ignored when processing user
input.

Fixes magento/graphql-ce#388

Author: pmclain

app/code/Magento/CustomerGraphQl/Model/Customer/UpdateCustomerData.php

@@ -19,6 +19,8 @@
  */
 class UpdateCustomerData
 {
+    private const RESTRICTED_DATA_KEYS = ['email', 'password'];
+
     /**
      * @var CustomerRepositoryInterface
      */
@@ -62,13 +64,14 @@ public function __construct(
     public function execute(int $customerId, array $data): void
     {
         $customer = $this->customerRepository->getById($customerId);
+        $newCustomerData = array_diff_key($data, array_flip(static::RESTRICTED_DATA_KEYS));
 
-        if (isset($data['firstname'])) {
-            $customer->setFirstname($data['firstname']);
-        }
-
-        if (isset($data['lastname'])) {
-            $customer->setLastname($data['lastname']);
+        foreach ($newCustomerData as $key => $value) {
+            $setterMethod = 'set' . ucwords($key, '_');
+            if (!method_exists($customer, $setterMethod)) {
+                continue;
+            }
+            $customer->{$setterMethod}($value);
         }
 
         if (isset($data['email']) && $customer->getEmail() !== $data['email']) {

dev/tests/api-functional/testsuite/Magento/GraphQl/Customer/UpdateCustomerTest.php

@@ -47,32 +47,54 @@ public function testUpdateCustomer()
         $currentEmail = '[email protected]';
         $currentPassword = 'password';
 
+        $newPrefix = 'Dr';
         $newFirstname = 'Richard';
+        $newMiddlename = 'Riley';
         $newLastname = 'Rowe';
+        $newSuffix = 'III';
+        $newDob = '3/11/1972';
+        $newTaxVat = 'GQL1234567';
+        $newGender = 2;
         $newEmail = '[email protected]';
 
         $query = <<<QUERY
 mutation {
     updateCustomer(
         input: {
+            prefix: "{$newPrefix}"
             firstname: "{$newFirstname}"
+            middlename: "{$newMiddlename}"
             lastname: "{$newLastname}"
+            suffix: "{$newSuffix}"
+            dob: "{$newDob}"
+            taxvat: "{$newTaxVat}"
             email: "{$newEmail}"
             password: "{$currentPassword}"
         }
     ) {
         customer {
+            prefix
             firstname
+            middlename
             lastname
+            suffix
+            dob
+            taxvat
             email
         }
     }
 }
 QUERY;
         $response = $this->graphQlQuery($query, [], '', $this->getCustomerAuthHeaders($currentEmail, $currentPassword));
 
+        $this->assertEquals($newPrefix, $response['updateCustomer']['customer']['prefix']);
         $this->assertEquals($newFirstname, $response['updateCustomer']['customer']['firstname']);
+        $this->assertEquals($newMiddlename, $response['updateCustomer']['customer']['middlename']);
         $this->assertEquals($newLastname, $response['updateCustomer']['customer']['lastname']);
+        $this->assertEquals($newSuffix, $response['updateCustomer']['customer']['suffix']);
+        $newDobDate = new \DateTime($newDob);
+        $this->assertEquals($newDobDate->format('Y-m-d'), $response['updateCustomer']['customer']['dob']);
+        $this->assertEquals($newTaxVat, $response['updateCustomer']['customer']['taxvat']);
         $this->assertEquals($newEmail, $response['updateCustomer']['customer']['email']);
     }