Skip to content

Commit 90cb13e

Browse files
committed
AC-1271: Add rate limiting for payment information endpoint and mutation
1 parent 247ea40 commit 90cb13e

File tree

5 files changed

+12
-6
lines changed

5 files changed

+12
-6
lines changed

app/code/Magento/Quote/Model/Backpressure/OrderLimitConfigManager.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ class OrderLimitConfigManager implements LimitConfigManagerInterface
3030
/**
3131
* @param ScopeConfigInterface $config
3232
*/
33-
public function __construct(ScopeConfigInterface $config) {
33+
public function __construct(ScopeConfigInterface $config)
34+
{
3435
$this->config = $config;
3536
}
3637

lib/internal/Magento/Framework/App/Backpressure/SlidingWindow/RedisRequestLogger.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,8 @@ private function getPrefixId(): string
103103
try {
104104
return (string)$this->deploymentConfig->get(
105105
self::CONFIG_PATH_BACKPRESSURE_LOGGER_ID_PREFIX,
106-
self::DEFAULT_PREFIX_ID);
106+
self::DEFAULT_PREFIX_ID
107+
);
107108
} catch (RuntimeException | FileSystemException $e) {
108109
return self::DEFAULT_PREFIX_ID;
109110
}

lib/internal/Magento/Framework/App/Backpressure/SlidingWindow/RedisRequestLogger/RedisClient.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
use Magento\Framework\Exception\RuntimeException;
1414

1515
/**
16-
* Redis client
16+
* Redis client for request logger
1717
*/
1818
class RedisClient
1919
{
@@ -71,6 +71,7 @@ class RedisClient
7171
private Credis_Client $pipeline;
7272

7373
/**
74+
* @param DeploymentConfig $config
7475
* @throws FileSystemException
7576
* @throws RuntimeException
7677
*/

setup/src/Magento/Setup/Model/ConfigOptionsList/BackpressureLogger.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ public function createConfig(array $options, DeploymentConfig $deploymentConfig)
166166
default:
167167
if (isset($options[$inputKey])) {
168168
$configData->set($configPath, $options[$inputKey]);
169-
}elseif ($deploymentConfig->get($configPath)) {
169+
} elseif ($deploymentConfig->get($configPath)) {
170170
$configData->set($configPath, $deploymentConfig->get($configPath));
171171
}
172172
}

setup/src/Magento/Setup/Test/Unit/Model/ConfigOptionsList/BackpressureLoggerTest.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,11 @@ public function testGetOptions()
8787
* testCreateConfigCacheRedis
8888
* @dataProvider dataProviderCreateConfigCacheRedis
8989
*/
90-
public function testCreateConfigCacheRedis(array $options, array $deploymentConfigReturnMap, array $expectedConfigData)
91-
{
90+
public function testCreateConfigCacheRedis(
91+
array $options,
92+
array $deploymentConfigReturnMap,
93+
array $expectedConfigData
94+
) {
9295
$this->deploymentConfigMock->method('get')->willReturnMap($deploymentConfigReturnMap);
9396
$configData = $this->configList->createConfig($options, $this->deploymentConfigMock);
9497
$this->assertEquals($expectedConfigData, $configData->getData());

0 commit comments

Comments
 (0)