GraphQl-198: Products: access to related/up-sell/cross-sell product fields

Author: naydav

app/code/Magento/CatalogGraphQl/Model/Resolver/Product.php

@@ -9,10 +9,8 @@
 
 use Magento\CatalogGraphQl\Model\Resolver\Product\ProductFieldsSelector;
 use Magento\CatalogGraphQl\Model\Resolver\Products\DataProvider\Deferred\Product as ProductDataProvider;
-use Magento\Framework\App\ObjectManager;
 use Magento\Framework\GraphQl\Config\Element\Field;
 use Magento\Framework\GraphQl\Exception\GraphQlInputException;
-use Magento\Framework\GraphQl\Query\FieldTranslator;
 use Magento\Framework\GraphQl\Query\Resolver\ValueFactory;
 use Magento\Framework\GraphQl\Query\ResolverInterface;
 use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
@@ -32,12 +30,6 @@ class Product implements ResolverInterface
      */
     private $valueFactory;
 
-    /**
-     * @deprecated
-     * @var FieldTranslator
-     */
-    private $fieldTranslator;
-
     /**
      * @var ProductFieldsSelector
      */
@@ -46,20 +38,16 @@ class Product implements ResolverInterface
     /**
      * @param ProductDataProvider $productDataProvider
      * @param ValueFactory $valueFactory
-     * @param FieldTranslator $fieldTranslator
      * @param ProductFieldsSelector $productFieldsSelector
      */
     public function __construct(
         ProductDataProvider $productDataProvider,
         ValueFactory $valueFactory,
-        FieldTranslator $fieldTranslator,
         ProductFieldsSelector $productFieldsSelector
     ) {
         $this->productDataProvider = $productDataProvider;
         $this->valueFactory = $valueFactory;
-        $this->fieldTranslator = $fieldTranslator;
-        $this->productFieldsSelector = $productFieldsSelector
-            ?? ObjectManager::getInstance()->get(ProductFieldsSelector::class);
+        $this->productFieldsSelector = $productFieldsSelector;
     }
 
     /**

app/code/Magento/RelatedProductGraphQl/Model/DataProvider/RelatedProductDataProvider.php

@@ -42,12 +42,13 @@ public function getData(Product $product, array $fields, int $linkType): array
     {
         $relatedProducts = $this->getRelatedProducts($product, $fields, $linkType);
 
-        $data = [];
+        $productsData = [];
         foreach ($relatedProducts as $relatedProduct) {
-            $relatedProductData = $relatedProduct->getData();
-            $relatedProductData['model'] = $relatedProduct;
+            $productData = $relatedProduct->getData();
+            $productData['model'] = $relatedProduct;
+            $productsData[] = $productData;
         }
-        return $data;
+        return $productsData;
     }
 
     /**

app/code/Magento/RelatedProductGraphQl/README.md

@@ -0,0 +1,3 @@
+# RelatedProductGraphQl
+
+**RelatedProductGraphQl** provides endpoints for getting  Cross Sell / Related/ Up Sell products data.

dev/tests/api-functional/testsuite/Magento/GraphQl/RelatedProduct/GetRelatedProductsTest.php

@@ -31,7 +31,6 @@ public function testQueryRelatedProducts()
                 sku
                 name
                 url_key
-                id
                 created_at
             }
         }
@@ -67,7 +66,6 @@ public function testQueryCrossSellProducts()
                 sku
                 name
                 url_key
-                id
                 created_at
             }
         }
@@ -87,13 +85,11 @@ public function testQueryCrossSellProducts()
         self::assertArrayHasKey('sku', $crossSellProduct);
         self::assertArrayHasKey('name', $crossSellProduct);
         self::assertArrayHasKey('url_key', $crossSellProduct);
-        self::assertArrayHasKey('id', $crossSellProduct);
         self::assertArrayHasKey('created_at', $crossSellProduct);
         self::assertEquals($crossSellProduct['sku'], 'simple');
         self::assertEquals($crossSellProduct['name'], 'Simple Cross Sell');
         self::assertEquals($crossSellProduct['url_key'], 'simple-cross-sell');
         self::assertNotEmpty($crossSellProduct['created_at']);
-        self::assertNotEmpty($crossSellProduct['id']);
     }
 
     /**
@@ -113,7 +109,6 @@ public function testQueryUpSellProducts()
                 sku
                 name
                 url_key
-                id
                 created_at
             }
         }
@@ -133,13 +128,11 @@ public function testQueryUpSellProducts()
         self::assertArrayHasKey('sku', $upSellProduct);
         self::assertArrayHasKey('name', $upSellProduct);
         self::assertArrayHasKey('url_key', $upSellProduct);
-        self::assertArrayHasKey('id', $upSellProduct);
         self::assertArrayHasKey('created_at', $upSellProduct);
         self::assertEquals($upSellProduct['sku'], 'simple');
         self::assertEquals($upSellProduct['name'], 'Simple Up Sell');
         self::assertEquals($upSellProduct['url_key'], 'simple-up-sell');
         self::assertNotEmpty($upSellProduct['created_at']);
-        self::assertNotEmpty($upSellProduct['id']);
     }
 
     /**
@@ -163,7 +156,6 @@ private function assertRelatedProducts(array $relatedProducts): void
             self::assertArrayHasKey('sku', $product);
             self::assertArrayHasKey('name', $product);
             self::assertArrayHasKey('url_key', $product);
-            self::assertArrayHasKey('id', $product);
             self::assertArrayHasKey('created_at', $product);
 
             self::assertArrayHasKey($product['sku'], $expectedData);
@@ -172,7 +164,6 @@ private function assertRelatedProducts(array $relatedProducts): void
             self::assertEquals($product['name'], $productExpectedData['name']);
             self::assertEquals($product['url_key'], $productExpectedData['url_key']);
             self::assertNotEmpty($product['created_at']);
-            self::assertNotEmpty($product['id']);
         }
     }
 }