B2B-2424: Optimize permissions read in addProductsToCart mutation

Author: Roman Hanin

app/code/Magento/QuoteGraphQl/Model/CartItem/PrecursorComposite.php

@@ -0,0 +1,60 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\QuoteGraphQl\Model\CartItem;
+
+use Magento\GraphQl\Model\Query\ContextInterface;
+
+/**
+ * Chained precursor composite.
+ */
+class PrecursorComposite implements PrecursorInterface
+{
+    /**
+     * @var PrecursorInterface[]
+     */
+    private $precursors = [];
+
+    /**
+     * @var array
+     */
+    private $errors = [];
+
+    /**
+     * @param array $precursors
+     */
+    public function __construct(array $precursors)
+    {
+        $this->precursors = $precursors;
+    }
+
+    /**
+     * @inheirtdoc
+     */
+    public function process(array $cartItemData, ContextInterface $context): array
+    {
+        foreach ($this->precursors as $precursor) {
+            $cartItemData = $precursor->process($cartItemData, $context);
+            array_merge($this->errors, $precursor->getErrors());
+        }
+        return $cartItemData;
+    }
+
+    /**
+     * @inheirtdoc
+     */
+    public function getErrors(): array
+    {
+        $errors = [];
+        foreach ($this->precursors as $precursor) {
+            foreach ($precursor->getErrors() as $error) {
+                $errors[] = $error;
+            }
+        }
+        return $errors;
+    }
+}

app/code/Magento/QuoteGraphQl/Model/CartItem/PrecursorInterface.php

@@ -0,0 +1,34 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\QuoteGraphQl\Model\CartItem;
+
+use Magento\GraphQl\Model\Query\ContextInterface;
+use Magento\Quote\Model\Cart\Data\CartItem;
+use Magento\QuoteGraphQl\Model\CartItem\DataProvider\Processor\ItemDataProcessorInterface;
+
+/**
+ * Cart items preparator for cart operations.
+ */
+interface PrecursorInterface extends ItemDataProcessorInterface
+{
+    /**
+     * Preprocess cart items for Graphql request.
+     *
+     * @param ContextInterface $context
+     * @param array $cartItemData
+     * @return array
+     */
+    public function process(array $cartItemData, ContextInterface $context): array;
+
+    /**
+     * Get precursor errors.
+     *
+     * @return array
+     */
+    public function getErrors(): array;
+}

app/code/Magento/QuoteGraphQl/Model/Resolver/AddProductsToCart.php

@@ -7,6 +7,7 @@
 
 namespace Magento\QuoteGraphQl\Model\Resolver;
 
+use Magento\Framework\App\ObjectManager;
 use Magento\Framework\GraphQl\Config\Element\Field;
 use Magento\Framework\GraphQl\Exception\GraphQlInputException;
 use Magento\Framework\GraphQl\Query\ResolverInterface;
@@ -19,6 +20,7 @@
 use Magento\QuoteGraphQl\Model\Cart\GetCartForUser;
 use Magento\Quote\Model\Cart\Data\Error;
 use Magento\QuoteGraphQl\Model\CartItem\DataProvider\Processor\ItemDataProcessorInterface;
+use Magento\QuoteGraphQl\Model\CartItem\PrecursorInterface;
 
 /**
  * Resolver for addProductsToCart mutation
@@ -38,31 +40,35 @@ class AddProductsToCart implements ResolverInterface
     private $addProductsToCartService;
 
     /**
-     * @var ItemDataProcessorInterface
+     * @var QuoteMutexInterface
      */
-    private $itemDataProcessor;
+    private $quoteMutex;
 
     /**
-     * @var QuoteMutexInterface
+     * @var PrecursorInterface|null
      */
-    private $quoteMutex;
+    private $cartItemPrecursor;
 
     /**
      * @param GetCartForUser $getCartForUser
      * @param AddProductsToCartService $addProductsToCart
      * @param ItemDataProcessorInterface $itemDataProcessor
      * @param QuoteMutexInterface $quoteMutex
+     * @param PrecursorInterface|null $cartItemPrecursor
+     *
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function __construct(
         GetCartForUser $getCartForUser,
         AddProductsToCartService $addProductsToCart,
         ItemDataProcessorInterface $itemDataProcessor,
-        QuoteMutexInterface $quoteMutex
+        QuoteMutexInterface $quoteMutex,
+        PrecursorInterface $cartItemPrecursor = null
     ) {
         $this->getCartForUser = $getCartForUser;
         $this->addProductsToCartService = $addProductsToCart;
-        $this->itemDataProcessor = $itemDataProcessor;
         $this->quoteMutex = $quoteMutex;
+        $this->cartItemPrecursor = $cartItemPrecursor ?: ObjectManager::getInstance()->get(PrecursorInterface::class);
     }
 
     /**
@@ -102,11 +108,9 @@ private function run($context, ?array $args): array
 
         // Shopping Cart validation
         $this->getCartForUser->execute($maskedCartId, $context->getUserId(), $storeId);
+        $cartItemsData = $this->cartItemPrecursor->process($cartItemsData, $context);
         $cartItems = [];
         foreach ($cartItemsData as $cartItemData) {
-            if (!$this->itemIsAllowedToCart($cartItemData, $context)) {
-                continue;
-            }
             $cartItems[] = (new CartItemFactory())->create($cartItemData);
         }
 
@@ -125,25 +129,8 @@ function (Error $error) {
                         'path' => [$error->getCartItemPosition()]
                     ];
                 },
-                $addProductsToCartOutput->getErrors()
+                array_merge($addProductsToCartOutput->getErrors(), $this->cartItemPrecursor->getErrors())
             )
         ];
     }
-
-    /**
-     * Check if the item can be added to cart
-     *
-     * @param array $cartItemData
-     * @param ContextInterface $context
-     * @return bool
-     */
-    private function itemIsAllowedToCart(array $cartItemData, ContextInterface $context): bool
-    {
-        $cartItemData = $this->itemDataProcessor->process($cartItemData, $context);
-        if (isset($cartItemData['grant_checkout']) && $cartItemData['grant_checkout'] === false) {
-            return false;
-        }
-
-        return true;
-    }
 }

app/code/Magento/QuoteGraphQl/etc/di.xml

@@ -8,6 +8,7 @@
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
     <preference for="Magento\QuoteGraphQl\Model\CartItem\DataProvider\CustomizableOptionValueInterface" type="Magento\QuoteGraphQl\Model\CartItem\DataProvider\CustomizableOptionValue\Composite" />
     <preference for="Magento\QuoteGraphQl\Model\CartItem\DataProvider\Processor\ItemDataProcessorInterface" type="Magento\QuoteGraphQl\Model\CartItem\DataProvider\Processor\ItemDataCompositeProcessor" />
+    <preference for="Magento\QuoteGraphQl\Model\CartItem\PrecursorInterface" type="Magento\QuoteGraphQl\Model\CartItem\PrecursorComposite" />
     <type name="Magento\QuoteGraphQl\Model\Resolver\CartItemTypeResolver">
         <arguments>
             <argument name="supportedTypes" xsi:type="array">