MC-41284: Catalog product grid filter works incorrectly

Author: vzabaznov

app/code/Magento/Backend/etc/adminhtml/system.xml

@@ -448,14 +448,6 @@
                     <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
                 </field>
             </group>
-            <group id="grid" translate="grid" type="text" sortOrder="45" showInDefault="1">
-                <label>Admin Grids</label>
-                <field id="show_approximate_products_amount_grid" translate="label"
-                       type="select" sortOrder="1" showInDefault="1" canRestore="1">
-                    <label>Show approximate products amount in a product grid</label>
-                    <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
-                </field>
-            </group>
         </section>
         <section id="web" translate="label" type="text" sortOrder="20" showInDefault="1" showInWebsite="1" showInStore="1">
             <label>Web</label>

app/code/Magento/Backend/etc/config.xml

@@ -31,11 +31,6 @@
                 <max_height>1200</max_height>
             </upload_configuration>
         </system>
-        <admin>
-            <grid>
-                <show_approximate_products_amount_grid>0</show_approximate_products_amount_grid>
-            </grid>
-        </admin>
         <general>
             <validator_data>
                 <input_types>

app/code/Magento/Catalog/Ui/DataProvider/Product/ProductCollection.php

@@ -25,56 +25,4 @@ protected function _productLimitationJoinPrice()
         $this->_productLimitationFilters->setUsePriceIndex(false);
         return $this->_productLimitationPrice(true);
     }
-
-    /**
-     * Return approximately amount if too much entities.
-     *
-     * @return int|mixed
-     */
-    public function getSize()
-    {
-        if ($this->_scopeConfig->getValue('admin/grid/show_approximate_products_amount_grid')) {
-            $sql = $this->getSelectCountSql();
-            return $this->analyzeCount($sql);
-        }
-
-        return parent::getSize();
-    }
-
-    /**
-     * Analyze amount of entities in DB.
-     *
-     * @param $sql
-     * @return int|mixed
-     * @throws \Zend_Db_Statement_Exception
-     */
-    private function analyzeCount($sql)
-    {
-        $results = $this->getConnection()->query('EXPLAIN ' . $sql)->fetchAll();
-        $alias = $this->getMainTableAlias();
-
-        foreach ($results as $result) {
-            if ($result['table'] == $alias) {
-                return $result['rows'];
-            }
-        }
-
-        return 0;
-    }
-
-    /**
-     * Identify main table alias or its name if alias is not defined.
-     *
-     * @return string
-     * @throws \LogicException
-     */
-    private function getMainTableAlias()
-    {
-        foreach ($this->getSelect()->getPart(\Magento\Framework\DB\Select::FROM) as $tableAlias => $tableMetadata) {
-            if ($tableMetadata['joinType'] == 'from') {
-                return $tableAlias;
-            }
-        }
-        throw new \LogicException("Main table cannot be identified.");
-    }
 }

app/code/Magento/Sales/etc/adminhtml/di.xml

@@ -48,9 +48,4 @@
             </argument>
         </arguments>
     </type>
-    <type name="Magento\Sales\Block\Adminhtml\Order\Create\Search\Grid\DataProvider\ProductCollection">
-        <arguments>
-            <argument name="collectionFactory" xsi:type="object">\Magento\Catalog\Ui\DataProvider\Product\ProductCollectionFactory</argument>
-        </arguments>
-    </type>
 </config>