ENGCOM-6839: Code hygeine in bundle option graphql resolver #26781

magento-engcom-team · magento-engcom-team · commit 955c4baf348b · 2020-02-09T11:42:17.000-06:00
- Merge Pull Request #26781 from moloughlin/magento2:fix/bundle_option_graphql_return_type - Merged commits: 1. 9e789ca 2. 4238f7b
diff --git a/app/code/Magento/BundleGraphQl/Model/Resolver/Options/Collection.php b/app/code/Magento/BundleGraphQl/Model/Resolver/Options/Collection.php
@@ -78,11 +78,7 @@ public function addParentFilterData(int $parentId, int $parentEntityId, string $
     public function getOptionsByParentId(int $parentId) : array
     {
         $options = $this->fetch();
-        if (!isset($options[$parentId])) {
-            return [];
-        }
-
-        return $options[$parentId];
+        return $options[$parentId] ?? [];
     }
 
     /**
@@ -115,7 +111,7 @@ private function fetch() : array
 
         $this->extensionAttributesJoinProcessor->process($optionsCollection);
         if (empty($optionsCollection->getData())) {
-            return null;
+            return [];
         }
 
         /** @var \Magento\Bundle\Model\Option $option */

Original file line number	Diff line number	Diff line change
`@@ -78,11 +78,7 @@ public function addParentFilterData(int $parentId, int $parentEntityId, string $`
`78`	`78`	`public function getOptionsByParentId(int $parentId) : array`
`79`	`79`	`{`
`80`	`80`	`$options = $this->fetch();`
`81`		`- if (!isset($options[$parentId])) {`
`82`		`- return [];`
`83`		`- }`
`84`		`-`
`85`		`- return $options[$parentId];`
	`81`	`+ return $options[$parentId] ?? [];`
`86`	`82`	`}`
`87`	`83`
`88`	`84`	`/**`
`@@ -115,7 +111,7 @@ private function fetch() : array`
`115`	`111`
`116`	`112`	`$this->extensionAttributesJoinProcessor->process($optionsCollection);`
`117`	`113`	`if (empty($optionsCollection->getData())) {`
`118`		`- return null;`
	`114`	`+ return [];`
`119`	`115`	`}`
`120`	`116`
`121`	`117`	`/** @var \Magento\Bundle\Model\Option $option */`