Skip to content

Commit 97e3277

Browse files
committed
MC-17003: Update Totals button is missing from Credit Memo page
1 parent 1c8d692 commit 97e3277

File tree

3 files changed

+6
-12
lines changed

3 files changed

+6
-12
lines changed

app/code/Magento/Sales/Test/Mftf/Test/AdminCheckingCreditMemoUpdateTotalsTest.xml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,20 +20,14 @@
2020
<group value="sales"/>
2121
</annotations>
2222
<before>
23-
<!--Create category-->
24-
<createData entity="_defaultCategory" stepKey="createCategory"/>
25-
<!--Create simple product-->
26-
<createData entity="_defaultProduct" stepKey="createSimpleProduct">
27-
<requiredEntity createDataKey="createCategory"/>
28-
</createData>
23+
<!--Create product-->
24+
<createData entity="SimpleProduct2" stepKey="createSimpleProduct"/>
2925
<!--Create customer-->
3026
<createData entity="Simple_US_CA_Customer" stepKey="createCustomer"/>
3127
<!--Login to admin page-->
3228
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
3329
</before>
3430
<after>
35-
<!--Delete category-->
36-
<deleteData createDataKey="createCategory" stepKey="deleteCategory"/>
3731
<!--Delete simple product-->
3832
<deleteData createDataKey="createSimpleProduct" stepKey="deleteSimpleProduct"/>
3933
<!--Delete customer-->

dev/tests/functional/tests/app/Magento/Sales/Test/Block/Adminhtml/Order/Creditmemo/Totals.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,21 +32,21 @@ class Totals extends \Magento\Sales\Test\Block\Adminhtml\Order\Totals
3232
*
3333
* @var string
3434
*/
35-
private $refundShippingSelector = '//input[@id=\'shipping_amount\']';
35+
private $refundShippingSelector = '#shipping_amount';
3636

3737
/**
3838
* Adjustment Refund css selector.
3939
*
4040
* @var string
4141
*/
42-
private $adjustmentRefundSelector = '//input[@id=\'adjustment_positive\']';
42+
private $adjustmentRefundSelector = '#adjustment_positive';
4343

4444
/**
4545
* Adjustment Fee css selector.
4646
*
4747
* @var string
4848
*/
49-
private $adjustmentFeeSelector = '//input[@id=\'adjustment_negative\']';
49+
private $adjustmentFeeSelector = '#adjustment_negative';
5050

5151
/**
5252
* 'Update Totals button css selector.

dev/tests/functional/tests/app/Magento/Sales/Test/TestStep/CreateCreditMemoStep.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ protected function getCreditMemoIds()
127127
* @param array $data
128128
* @return int
129129
*/
130-
private function compareRefundTotalsData($data)
130+
private function compareRefundTotalsData($data): int
131131
{
132132
$compareData = [
133133
'shipping_amount' =>

0 commit comments

Comments
 (0)