Skip to content

Commit 9884e1e

Browse files
committed
ACP2E-104: [Magento Cloud] Customizable options Drag and drop issue
- Fixed the functional and static test failure.
1 parent 9111120 commit 9884e1e

File tree

2 files changed

+37
-38
lines changed

2 files changed

+37
-38
lines changed

app/code/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/CustomOptions.php

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -38,61 +38,61 @@ class CustomOptions extends AbstractModifier
3838
/**#@+
3939
* Group values
4040
*/
41-
const GROUP_CUSTOM_OPTIONS_NAME = 'custom_options';
42-
const GROUP_CUSTOM_OPTIONS_SCOPE = 'data.product';
43-
const GROUP_CUSTOM_OPTIONS_PREVIOUS_NAME = 'search-engine-optimization';
44-
const GROUP_CUSTOM_OPTIONS_DEFAULT_SORT_ORDER = 31;
41+
public const GROUP_CUSTOM_OPTIONS_NAME = 'custom_options';
42+
public const GROUP_CUSTOM_OPTIONS_SCOPE = 'data.product';
43+
public const GROUP_CUSTOM_OPTIONS_PREVIOUS_NAME = 'search-engine-optimization';
44+
public const GROUP_CUSTOM_OPTIONS_DEFAULT_SORT_ORDER = 31;
4545
/**#@-*/
4646

4747
/**#@+
4848
* Button values
4949
*/
50-
const BUTTON_ADD = 'button_add';
51-
const BUTTON_IMPORT = 'button_import';
50+
public const BUTTON_ADD = 'button_add';
51+
public const BUTTON_IMPORT = 'button_import';
5252
/**#@-*/
5353

5454
/**#@+
5555
* Container values
5656
*/
57-
const CONTAINER_HEADER_NAME = 'container_header';
58-
const CONTAINER_OPTION = 'container_option';
59-
const CONTAINER_COMMON_NAME = 'container_common';
60-
const CONTAINER_TYPE_STATIC_NAME = 'container_type_static';
57+
public const CONTAINER_HEADER_NAME = 'container_header';
58+
public const CONTAINER_OPTION = 'container_option';
59+
public const CONTAINER_COMMON_NAME = 'container_common';
60+
public const CONTAINER_TYPE_STATIC_NAME = 'container_type_static';
6161
/**#@-*/
6262

6363
/**#@+
6464
* Grid values
6565
*/
66-
const GRID_OPTIONS_NAME = 'options';
67-
const GRID_TYPE_SELECT_NAME = 'values';
66+
public const GRID_OPTIONS_NAME = 'options';
67+
public const GRID_TYPE_SELECT_NAME = 'values';
6868
/**#@-*/
6969

7070
/**#@+
7171
* Field values
7272
*/
73-
const FIELD_ENABLE = 'affect_product_custom_options';
74-
const FIELD_OPTION_ID = 'option_id';
75-
const FIELD_TITLE_NAME = 'title';
76-
const FIELD_STORE_TITLE_NAME = 'store_title';
77-
const FIELD_TYPE_NAME = 'type';
78-
const FIELD_IS_REQUIRE_NAME = 'is_require';
79-
const FIELD_SORT_ORDER_NAME = 'sort_order';
80-
const FIELD_PRICE_NAME = 'price';
81-
const FIELD_PRICE_TYPE_NAME = 'price_type';
82-
const FIELD_SKU_NAME = 'sku';
83-
const FIELD_MAX_CHARACTERS_NAME = 'max_characters';
84-
const FIELD_FILE_EXTENSION_NAME = 'file_extension';
85-
const FIELD_IMAGE_SIZE_X_NAME = 'image_size_x';
86-
const FIELD_IMAGE_SIZE_Y_NAME = 'image_size_y';
87-
const FIELD_IS_DELETE = 'is_delete';
88-
const FIELD_IS_USE_DEFAULT = 'is_use_default';
73+
public const FIELD_ENABLE = 'affect_product_custom_options';
74+
public const FIELD_OPTION_ID = 'option_id';
75+
public const FIELD_TITLE_NAME = 'title';
76+
public const FIELD_STORE_TITLE_NAME = 'store_title';
77+
public const FIELD_TYPE_NAME = 'type';
78+
public const FIELD_IS_REQUIRE_NAME = 'is_require';
79+
public const FIELD_SORT_ORDER_NAME = 'sort_order';
80+
public const FIELD_PRICE_NAME = 'price';
81+
public const FIELD_PRICE_TYPE_NAME = 'price_type';
82+
public const FIELD_SKU_NAME = 'sku';
83+
public const FIELD_MAX_CHARACTERS_NAME = 'max_characters';
84+
public const FIELD_FILE_EXTENSION_NAME = 'file_extension';
85+
public const FIELD_IMAGE_SIZE_X_NAME = 'image_size_x';
86+
public const FIELD_IMAGE_SIZE_Y_NAME = 'image_size_y';
87+
public const FIELD_IS_DELETE = 'is_delete';
88+
public const FIELD_IS_USE_DEFAULT = 'is_use_default';
8989
/**#@-*/
9090

9191
/**#@+
9292
* Import options values
9393
*/
94-
const IMPORT_OPTIONS_MODAL = 'import_options_modal';
95-
const CUSTOM_OPTIONS_LISTING = 'product_custom_options_listing';
94+
public const IMPORT_OPTIONS_MODAL = 'import_options_modal';
95+
public const CUSTOM_OPTIONS_LISTING = 'product_custom_options_listing';
9696
/**#@-*/
9797

9898
/**

app/code/Magento/Catalog/view/adminhtml/web/js/components/dynamic-rows-per-page.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -102,14 +102,13 @@ define([
102102
* Handles changes of the page size.
103103
*/
104104
onPageSizeChange: function () {
105-
if(!this.containers.length) {
106-
return;
107-
}
108-
if(this.perPageSize !== undefined) {
109-
this.pageSize = this.perPageSize;
110-
this.reload();
111-
} else {
112-
this.perPageSize = this.pageSize;
105+
if (!!this.getRecordCount()) {
106+
if (this.perPageSize !== undefined) {
107+
this.pageSize = this.perPageSize;
108+
this.reload();
109+
} else {
110+
this.perPageSize = this.pageSize;
111+
}
113112
}
114113
},
115114
});

0 commit comments

Comments
 (0)