ACP2E-1066: Credit memo not genrated if order configrable product with decimal quantity

devarul · devarul · commit 9988b2140f1c · 2022-08-09T18:13:45.000+05:30
- Fixed the issue.
diff --git a/app/code/Magento/Sales/Model/Order/CreditmemoFactory.php b/app/code/Magento/Sales/Model/Order/CreditmemoFactory.php
@@ -231,10 +231,10 @@ protected function initData($creditmemo, $data)
      * Calculate product options.
      *
      * @param Item $orderItem
-     * @param int|float $parentQty
-     * @return int|float
+     * @param float $parentQty
+     * @return float
      */
-    private function calculateProductOptions(Item $orderItem, $parentQty)
+    private function calculateProductOptions(Item $orderItem, float $parentQty): float
     {
         $qty = $parentQty;
         $productOptions = $orderItem->getProductOptions();

Original file line number	Diff line number	Diff line change
`@@ -231,10 +231,10 @@ protected function initData($creditmemo, $data)`
`231`	`231`	`* Calculate product options.`
`232`	`232`	`*`
`233`	`233`	`* @param Item $orderItem`
`234`		`- * @param int\|float $parentQty`
`235`		`- * @return int\|float`
	`234`	`+ * @param float $parentQty`
	`235`	`+ * @return float`
`236`	`236`	`*/`
`237`		`- private function calculateProductOptions(Item $orderItem, $parentQty)`
	`237`	`+ private function calculateProductOptions(Item $orderItem, float $parentQty): float`
`238`	`238`	`{`
`239`	`239`	`$qty = $parentQty;`
`240`	`240`	`$productOptions = $orderItem->getProductOptions();`