MC-37306: Sitemap generated by cron have wrong image URL (cache path)

Roman Lytvynenko · Roman Lytvynenko · commit 99c59a2a703b · 2020-09-04T15:10:22.000-05:00
diff --git a/app/code/Magento/Sitemap/Model/Observer.php b/app/code/Magento/Sitemap/Model/Observer.php
@@ -123,9 +123,10 @@ public function scheduledGenerateSitemaps()
                     true
                 );
                 $sitemap->generateXml();
-                $this->appEmulation->stopEnvironmentEmulation();
             } catch (\Exception $e) {
                 $errors[] = $e->getMessage();
+            } finally {
+                $this->appEmulation->stopEnvironmentEmulation();
             }
         }
         if ($errors && $recipient) {

Original file line number	Diff line number	Diff line change
`@@ -123,9 +123,10 @@ public function scheduledGenerateSitemaps()`
`123`	`123`	`true`
`124`	`124`	`);`
`125`	`125`	`$sitemap->generateXml();`
`126`		`- $this->appEmulation->stopEnvironmentEmulation();`
`127`	`126`	`} catch (\Exception $e) {`
`128`	`127`	`$errors[] = $e->getMessage();`
	`128`	`+ } finally {`
	`129`	`+ $this->appEmulation->stopEnvironmentEmulation();`
`129`	`130`	`}`
`130`	`131`	`}`
`131`	`132`	`if ($errors && $recipient) {`