Skip to content

Commit 99d58ef

Browse files
Chhandak.BaruaChhandak.Barua
authored andcommitted
ACP2E-992 Allow Multiple Boxes for Shipping attribute is not saving value - Product Edit
1 parent 9b58b62 commit 99d58ef

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/StockDataFilter.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public function filter(array $stockData)
6666
$stockData['min_qty'] = 0;
6767
}
6868

69-
if($stockData['is_qty_decimal'] == 0 && $stockData['is_decimal_divided'] == 1){
69+
if((isset($stockData['is_decimal_divided']) && isset($stockData['is_qty_decimal'])) && $stockData['is_qty_decimal'] == 0 && $stockData['is_decimal_divided'] == 1){
7070
throw new Exception(__('Please select Advanced Inventory -> Qty Uses Decimals as YES.'));
7171
}
7272
else if (!isset($stockData['is_decimal_divided']) || $stockData['is_qty_decimal'] == 0) {

app/code/Magento/Catalog/Test/Unit/Controller/Adminhtml/Product/Initialization/StockDataFilterTest.php

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,17 @@ public function testFilter(array $inputStockData, array $outputStockData)
6565
$this->assertEquals($outputStockData, $this->stockDataFilter->filter($inputStockData));
6666
}
6767

68+
/**
69+
* Verify update handle with exception.
70+
*/
71+
public function testExecuteWithException(): void
72+
{
73+
$this->expectException('\Exception');
74+
$this->expectExceptionMessage('Please select Advanced Inventory -> Qty Uses Decimals as YES.');
75+
76+
$this->stockDataFilter->filter(['is_qty_decimal' => 0, 'is_decimal_divided' => 1]);
77+
}
78+
6879
/**
6980
* Data provider for testFilter
7081
*
@@ -106,14 +117,6 @@ public function filterDataProvider()
106117
'is_decimal_divided' => 0,
107118
'use_config_manage_stock' => 0,
108119
],
109-
],
110-
'case6' => [
111-
'inputStockData' => ['is_qty_decimal' => 0, 'is_decimal_divided' => 1],
112-
'outputStockData' => [
113-
'is_qty_decimal' => 0,
114-
'is_decimal_divided' => 1,
115-
'use_config_manage_stock' => 0,
116-
],
117120
]
118121
];
119122
}

0 commit comments

Comments
 (0)