Skip to content

Commit 9b746fa

Browse files
author
Karpenko, Oleksandr
committed
Merge remote-tracking branch 'origin/MAGETWO-55393' into pr-develop
# Conflicts: # app/design/adminhtml/Magento/backend/web/css/source/forms/fields/_control-table.less
2 parents c84ef0f + 509d5fa commit 9b746fa

File tree

5 files changed

+36
-27
lines changed

5 files changed

+36
-27
lines changed

app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/labels.phtml

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -16,26 +16,28 @@
1616
</strong>
1717
</div>
1818
<div class="fieldset-wrapper-content in collapse" id="manage-titles-content">
19-
<fieldset class="fieldset">
20-
<table class="admin__control-table" id="attribute-labels-table">
21-
<thead>
22-
<tr>
23-
<?php foreach ($block->getStores() as $_store): ?>
24-
<th class="col-store-view"><?php /* @escapeNotVerified */ echo $_store->getName() ?></th>
25-
<?php endforeach; ?>
26-
</tr>
27-
</thead>
28-
<tbody>
29-
<tr>
30-
<?php $_labels = $block->getLabelValues() ?>
31-
<?php foreach ($block->getStores() as $_store): ?>
32-
<td class="col-store-view">
33-
<input class="input-text<?php if ($_store->getId() == \Magento\Store\Model\Store::DEFAULT_STORE_ID): ?> required-option<?php endif; ?>" type="text" name="frontend_label[<?php /* @escapeNotVerified */ echo $_store->getId() ?>]" value="<?php echo $block->escapeHtml($_labels[$_store->getId()]) ?>"<?php if ($block->getReadOnly()):?> disabled="disabled"<?php endif;?>/>
34-
</td>
35-
<?php endforeach; ?>
36-
</tr>
37-
</tbody>
38-
</table>
19+
<fieldset class="admin__fieldset fieldset">
20+
<div class="admin__control-table-wrapper">
21+
<table class="admin__control-table" id="attribute-labels-table">
22+
<thead>
23+
<tr>
24+
<?php foreach ($block->getStores() as $_store): ?>
25+
<th class="col-store-view"><?php /* @escapeNotVerified */ echo $_store->getName() ?></th>
26+
<?php endforeach; ?>
27+
</tr>
28+
</thead>
29+
<tbody>
30+
<tr>
31+
<?php $_labels = $block->getLabelValues() ?>
32+
<?php foreach ($block->getStores() as $_store): ?>
33+
<td class="col-store-view">
34+
<input class="input-text<?php if ($_store->getId() == \Magento\Store\Model\Store::DEFAULT_STORE_ID): ?> required-option<?php endif; ?>" type="text" name="frontend_label[<?php /* @escapeNotVerified */ echo $_store->getId() ?>]" value="<?php echo $block->escapeHtml($_labels[$_store->getId()]) ?>"<?php if ($block->getReadOnly()):?> disabled="disabled"<?php endif;?>/>
35+
</td>
36+
<?php endforeach; ?>
37+
</tr>
38+
</tbody>
39+
</table>
40+
</div>
3941
</fieldset>
4042
</div>
4143
</div>

app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/options.phtml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010

1111
$stores = $block->getStoresSortedBySortOrder();
1212
?>
13-
<fieldset class="fieldset">
13+
<fieldset class="admin__fieldset fieldset">
1414
<legend class="legend">
1515
<span><?php echo $block->escapeHtml(__('Manage Options (Values of Your Attribute)')); ?></span>
16-
</legend>
17-
<div id="manage-options-panel" data-index="attribute_options_select_container">
16+
</legend><br />
17+
<div class="admin__control-table-wrapper" id="manage-options-panel" data-index="attribute_options_select_container">
1818
<table class="admin__control-table" data-index="attribute_options_select">
1919
<thead>
2020
<tr id="attribute-options-table">

app/code/Magento/Swatches/view/adminhtml/templates/catalog/product/attribute/visual.phtml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,11 @@
1010

1111
$stores = $block->getStoresSortedBySortOrder();
1212
?>
13-
<fieldset class="fieldset">
14-
<legend class="legend"><span><?php echo $block->escapeHtml( __('Manage Swatch (Values of Your Attribute)')); ?></span></legend>
15-
<div id="swatch-visual-options-panel">
13+
<fieldset class="admin__fieldset fieldset">
14+
<legend class="legend">
15+
<span><?php echo $block->escapeHtml( __('Manage Swatch (Values of Your Attribute)')); ?></span>
16+
</legend><br />
17+
<div class="admin__control-table-wrapper" id="swatch-visual-options-panel">
1618
<table class="data-table clearfix" cellspacing="0">
1719
<thead>
1820
<tr id="swatch-visual-options-table">
@@ -116,5 +118,4 @@ $stores = $block->getStoresSortedBySortOrder();
116118
}
117119
}
118120
</script>
119-
120121
</fieldset>

app/design/adminhtml/Magento/backend/web/css/source/forms/fields/_control-table.less

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@
131131
&._required {
132132
span {
133133
&:after {
134+
.lib-css(margin, @form-field-label-asterisk__margin);
134135
color: @validation__color;
135136
content: '*';
136137
}

app/design/adminhtml/Magento/backend/web/css/styles-old.less

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -744,6 +744,7 @@
744744
// --------------------------------------
745745

746746
fieldset {
747+
min-width: 0;
747748
padding: 20px;
748749
}
749750

@@ -5049,6 +5050,10 @@
50495050
}
50505051
}
50515052
}
5053+
5054+
.admin__control-table-wrapper {
5055+
clear: both;
5056+
}
50525057
}
50535058

50545059
.catalog-product-set-index {

0 commit comments

Comments
 (0)