ENGCOM-3729: Refactoring magento sales sequence #19930

 - Merge Pull Request #19930 from agorbulin/magento2:Refactoring-Magento_SalesSequence
 - Merged commits:
   1. 606e31c
   2. bc2001f

Author: magento-engcom-team

app/code/Magento/SalesRule/Model/Coupon.php

@@ -39,10 +39,10 @@ protected function _construct()
     /**
      * Set rule instance
      *
-     * @param \Magento\SalesRule\Model\Rule $rule
+     * @param Rule $rule
      * @return $this
      */
-    public function setRule(\Magento\SalesRule\Model\Rule $rule)
+    public function setRule(Rule $rule)
     {
         $this->setRuleId($rule->getId());
         return $this;
@@ -51,7 +51,7 @@ public function setRule(\Magento\SalesRule\Model\Rule $rule)
     /**
      * Load primary coupon for specified rule
      *
-     * @param \Magento\SalesRule\Model\Rule|int $rule
+     * @param Rule|int $rule
      * @return $this
      */
     public function loadPrimaryByRule($rule)

app/code/Magento/SalesSequence/Model/Manager.php

@@ -41,7 +41,9 @@ public function __construct(
      *
      * @param string $entityType
      * @param int $storeId
+     *
      * @return \Magento\Framework\DB\Sequence\SequenceInterface
+     * @throws \Magento\Framework\Exception\LocalizedException
      */
     public function getSequence($entityType, $storeId)
     {

app/code/Magento/SalesSequence/Model/ResourceModel/Meta.php

@@ -96,7 +96,9 @@ public function loadByEntityTypeAndStore($entityType, $storeId)
      * Using for load sequence profile and setting it into metadata
      *
      * @param \Magento\Framework\Model\AbstractModel $object
-     * @return $this
+     *
+     * @return $this|\Magento\Framework\Model\ResourceModel\Db\AbstractDb
+     * @throws \Magento\Framework\Exception\LocalizedException
      */
     protected function _afterLoad(\Magento\Framework\Model\AbstractModel $object)
     {
@@ -137,7 +139,12 @@ protected function _beforeSave(\Magento\Framework\Model\AbstractModel $object)
     }
 
     /**
-     * @inheritdoc
+     * Perform actions after object save
+     *
+     * @param \Magento\Framework\Model\AbstractModel $object
+     *
+     * @return $this|\Magento\Framework\Model\ResourceModel\Db\AbstractDb
+     * @throws \Magento\Framework\Exception\AlreadyExistsException
      */
     protected function _afterSave(\Magento\Framework\Model\AbstractModel $object)
     {

app/code/Magento/SalesSequence/Model/ResourceModel/Profile.php

@@ -5,7 +5,6 @@
  */
 namespace Magento\SalesSequence\Model\ResourceModel;
 
-use Magento\SalesSequence\Model\Meta as ModelMeta;
 use Magento\Framework\Model\ResourceModel\Db\Context as DatabaseContext;
 use Magento\SalesSequence\Model\ProfileFactory;
 

app/code/Magento/SalesSequence/Observer/SequenceCreatorObserver.php

@@ -49,8 +49,12 @@ public function __construct(
     }
 
     /**
+     * Observer triggered during adding new store
+     *
      * @param EventObserver $observer
-     * @return $this
+     *
+     * @return $this|void
+     * @throws \Magento\Framework\Exception\AlreadyExistsException
      */
     public function execute(EventObserver $observer)
     {

app/code/Magento/SalesSequence/Setup/SequenceCreator.php

@@ -49,6 +49,8 @@ public function __construct(
 
     /**
      * Creates sales sequences.
+     *
+     * @throws \Magento\Framework\Exception\AlreadyExistsException
      */
     public function create()
     {