MC-19247: Broken translations with advanced bundling

- Add escape url to layout;

Author: adifucan

app/code/Magento/Translation/ViewModel/Dictionary.php

@@ -6,6 +6,7 @@
 
 namespace Magento\Translation\ViewModel;
 
+use Magento\Framework\Escaper;
 use Magento\Framework\Exception\FileSystemException;
 use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\View\Asset\Repository as AssetRepository;
@@ -28,16 +29,24 @@ class Dictionary implements ArgumentInterface
      */
     private $appState;
 
+    /**
+     * @var Escaper
+     */
+    private $escaper;
+
     /**
      * @param AssetRepository $assetRepo
      * @param AppState $appState
+     * @param Escaper $escaper
      */
     public function __construct(
         AssetRepository $assetRepo,
-        AppState $appState
+        AppState $appState,
+        Escaper $escaper
     ) {
         $this->assetRepo = $assetRepo;
         $this->appState = $appState;
+        $this->escaper = $escaper;
     }
 
     /**
@@ -76,4 +85,15 @@ public function isAppStateProduction(): bool
     {
         return $this->appState->getMode() === AppState::MODE_PRODUCTION;
     }
+
+    /**
+     * Escape URL.
+     *
+     * @param string $url
+     * @return string
+     */
+    public function escapeUrl(string $url): string
+    {
+        return $this->escaper->escapeUrl($url);
+    }
 }

app/code/Magento/Translation/view/base/templates/dictionary.phtml

@@ -20,10 +20,10 @@ if (!$viewModel->isAppStateProduction()) {
 } else {
     ?>
     <script>
-        define('mageTranslationDictionary', ['text!<?= /* @noEscape */ $viewModel->getTranslationDictionaryUrl() ?>'], function (dict) {
+        define('mageTranslationDictionary', ['text!<?= $viewModel->escapeUrl($viewModel->getTranslationDictionaryUrl()) ?>'], function (dict) {
             return JSON.parse(dict);
         });
     </script>
-<?php
+    <?php
 }
 ?>

dev/tests/js/jasmine/tests/lib/mage/fake-dictionary.js

@@ -2,7 +2,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-// Fake translation dictionary for js unit tests as real dictionary is defined in template and cannot be initialized by requirejs
+// Fake translation dictionary as real dictionary is defined in template and cannot be initialized by requirejs
 define([], function () {
     'use strict';