Skip to content

Commit a1c9912

Browse files
committed
update code
1 parent 5b77b2c commit a1c9912

File tree

4 files changed

+12
-2
lines changed

4 files changed

+12
-2
lines changed

app/code/Magento/PageCache/Model/App/Request/Http/IdentifierForSave.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public function getValue()
5757
* @param string $url
5858
* @return array
5959
*/
60-
private function reconstructUrl($url)
60+
private function reconstructUrl(string $url): array
6161
{
6262
if (empty($url)) {
6363
return [$url, ''];

app/code/Magento/PageCache/Test/Unit/Model/App/Request/Http/IdentifierForSaveTest.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,11 @@ function ($value) {
143143
);
144144
}
145145

146+
/**
147+
* Test get identifier for save value with query parameters.
148+
*
149+
* @return void
150+
*/
146151
public function testGetValueWithQuery(): void
147152
{
148153
$this->requestMock->expects($this->any())

lib/internal/Magento/Framework/App/PageCache/Identifier.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public function getValue()
6868
* @param string $url
6969
* @return array
7070
*/
71-
private function reconstructUrl($url)
71+
private function reconstructUrl(string $url): array
7272
{
7373
if (empty($url)) {
7474
return [$url, ''];

lib/internal/Magento/Framework/App/Test/Unit/PageCache/IdentifierTest.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -249,6 +249,11 @@ public function testGetValue(): void
249249
);
250250
}
251251

252+
/**
253+
* Test get identifier for save value.
254+
*
255+
* @return void
256+
*/
252257
public function testGetValueWithQuery(): void
253258
{
254259
$this->requestMock->expects($this->any())

0 commit comments

Comments
 (0)