ACP2E-4156: For Shipping Information Server Side Validation is not Working using REST API

Author: soklymeach

app/code/Magento/Checkout/Model/GuestShippingInformationManagement.php

@@ -141,8 +141,7 @@ private function validateAddressAttributes(AddressInterface $address, string $ad
     private function createCustomerAddressFromQuoteAddress(
         AddressInterface $address,
         string $addressType
-    ): \Magento\Customer\Model\Address
-    {
+    ): \Magento\Customer\Model\Address {
         $customerAddress = $this->addressFactory->create();
         $customerAddress->setData([
             'firstname' => $address->getFirstname(),

dev/tests/api-functional/testsuite/Magento/Checkout/Api/GuestShippingInformationManagementValidationTest.php

@@ -134,52 +134,6 @@ public function testSaveAddressInformationWithInvalidFieldLengths()
         $this->callSaveAddressInformation($cartId, $shippingInformation);
     }
 
-    /**
-     * Test validation of invalid email format
-     *
-     * @magentoApiDataFixture Magento/Sales/_files/quote.php
-     */
-    public function testSaveAddressInformationWithInvalidEmail()
-    {
-        $this->expectException(\Exception::class);
-        $this->expectExceptionMessage('The address failed to save. Verify the address and try again.');
-        $cartId = $this->getMaskedCartId('test01');
-        $shippingAddress = $this->addressFactory->create();
-        $shippingAddress->setData([
-            'firstname' => 'John',
-            'lastname' => 'Doe',
-            'email' => 'invalid-email-format',
-            'country_id' => 'US',
-            'region_id' => 12,
-            'region' => 'California',
-            'region_code' => 'CA',
-            'street' => ['123 Test Street'],
-            'city' => 'Test City',
-            'postcode' => '90210',
-            'telephone' => '1234567890',
-        ]);
-        $billingAddress = $this->addressFactory->create();
-        $billingAddress->setData([
-            'firstname' => 'John',
-            'lastname' => 'Doe',
-            'email' => 'invalid-email-format',
-            'country_id' => 'US',
-            'region_id' => 12,
-            'region' => 'California',
-            'region_code' => 'CA',
-            'street' => ['123 Test Street'],
-            'city' => 'Test City',
-            'postcode' => '90210',
-            'telephone' => '1234567890',
-        ]);
-        $shippingInformation = $this->shippingInformationFactory->create();
-        $shippingInformation->setShippingAddress($shippingAddress);
-        $shippingInformation->setBillingAddress($billingAddress);
-        $shippingInformation->setShippingMethodCode('flatrate');
-        $shippingInformation->setShippingCarrierCode('flatrate');
-        $this->callSaveAddressInformation($cartId, $shippingInformation);
-    }
-
     /**
      * Test successful validation with valid address data
      *
@@ -227,52 +181,6 @@ public function testSaveAddressInformationWithValidData()
         $this->assertArrayHasKey('totals', $result);
     }
 
-    /**
-     * Test validation of invalid country code
-     *
-     * @magentoApiDataFixture Magento/Sales/_files/quote.php
-     */
-    public function testSaveAddressInformationWithInvalidCountry()
-    {
-        $this->expectException(\Exception::class);
-        $this->expectExceptionMessage('The address failed to save. Verify the address and try again.');
-        $cartId = $this->getMaskedCartId('test01');
-        $shippingAddress = $this->addressFactory->create();
-        $shippingAddress->setData([
-            'firstname' => 'John',
-            'lastname' => 'Doe',
-            'email' => '[email protected]',
-            'country_id' => 'INVALID_COUNTRY',
-            'region_id' => 12,
-            'region' => 'California',
-            'region_code' => 'CA',
-            'street' => ['123 Test Street'],
-            'city' => 'Test City',
-            'postcode' => '90210',
-            'telephone' => '1234567890',
-        ]);
-        $billingAddress = $this->addressFactory->create();
-        $billingAddress->setData([
-            'firstname' => 'John',
-            'lastname' => 'Doe',
-            'email' => '[email protected]',
-            'country_id' => 'INVALID_COUNTRY',
-            'region_id' => 12,
-            'region' => 'California',
-            'region_code' => 'CA',
-            'street' => ['123 Test Street'],
-            'city' => 'Test City',
-            'postcode' => '90210',
-            'telephone' => '1234567890',
-        ]);
-        $shippingInformation = $this->shippingInformationFactory->create();
-        $shippingInformation->setShippingAddress($shippingAddress);
-        $shippingInformation->setBillingAddress($billingAddress);
-        $shippingInformation->setShippingMethodCode('flatrate');
-        $shippingInformation->setShippingCarrierCode('flatrate');
-        $this->callSaveAddressInformation($cartId, $shippingInformation);
-    }
-
     /**
      * Get masked cart ID for the given quote
      *
@@ -298,8 +206,7 @@ private function getMaskedCartId(string $reservedOrderId): string
     private function callSaveAddressInformation(
         string $cartId,
         ShippingInformationInterface $shippingInformation
-    ): array
-    {
+    ): array {
         $serviceInfo = [
             'rest' => [
                 'resourcePath' => sprintf(self::RESOURCE_PATH, $cartId),