MAGETWO-63945: Add extension point to sales grid indexer

- Getting rid of redundant query in UpdatedIdList provider

Author: viktym

app/code/Magento/Sales/Model/ResourceModel/Grid.php

@@ -43,7 +43,7 @@ class Grid extends AbstractGrid
     /**
      * @var NotSyncedDataProviderInterface
      */
-    private $idListProvider;
+    private $notSyncedDataProvider;
 
     /**
      * @param Context $context
@@ -53,7 +53,7 @@ class Grid extends AbstractGrid
      * @param array $joins
      * @param array $columns
      * @param string $connectionName
-     * @param NotSyncedDataProviderInterface $idListProvider
+     * @param NotSyncedDataProviderInterface $notSyncedDataProvider
      */
     public function __construct(
         Context $context,
@@ -63,15 +63,15 @@ public function __construct(
         array $joins = [],
         array $columns = [],
         $connectionName = null,
-        NotSyncedDataProviderInterface $idListProvider = null
+        NotSyncedDataProviderInterface $notSyncedDataProvider = null
     ) {
         $this->mainTableName = $mainTableName;
         $this->gridTableName = $gridTableName;
         $this->orderIdField = $orderIdField;
         $this->joins = $joins;
         $this->columns = $columns;
-        $this->idListProvider =
-            $idListProvider ?: ObjectManager::getInstance()->get(NotSyncedDataProviderInterface::class);
+        $this->notSyncedDataProvider =
+            $notSyncedDataProvider ?: ObjectManager::getInstance()->get(NotSyncedDataProviderInterface::class);
         parent::__construct($context, $connectionName);
     }
 
@@ -111,7 +111,7 @@ public function refreshBySchedule()
         $select = $this->getGridOriginSelect()
             ->where(
                 $this->mainTableName . '.entity_id IN (?)',
-                $this->idListProvider->get($this->mainTableName, $this->gridTableName)
+                $this->notSyncedDataProvider->getIds($this->mainTableName, $this->gridTableName)
             );
 
         return $this->getConnection()->query(

app/code/Magento/Sales/Model/ResourceModel/Provider/UpdatedIdListProvider.php

@@ -38,31 +38,24 @@ public function __construct(
      */
     public function getIds($mainTableName, $gridTableName)
     {
-        $lastUpdatedAt = $this->getLastUpdatedAtValue($gridTableName);
         $select = $this->getConnection()->select()
-            ->from($this->getConnection()->getTableName($mainTableName), ['entity_id'])
-            ->where('updated_at >= ?', $lastUpdatedAt);
+            ->from($this->getConnection()->getTableName($mainTableName), [$mainTableName.'.entity_id'])
+            ->joinLeft(
+                [$gridTableName => $this->getConnection()->getTableName($gridTableName)],
+                sprintf(
+                    '%s.%s = %s.%s',
+                    $mainTableName,
+                    'entity_id',
+                    $gridTableName,
+                    'entity_id'
+                ),
+                []
+            )
+            ->where($gridTableName.'.entity_id IS NULL');
 
         return $this->getConnection()->fetchAll($select, [], \Zend_Db::FETCH_COLUMN);
     }
 
-    /**
-     * Returns update time of the last row in the grid.
-     *
-     * @param string $gridTableName
-     * @return string
-     */
-    private function getLastUpdatedAtValue($gridTableName)
-    {
-        $select = $this->getConnection()->select()
-            ->from($this->getConnection()->getTableName($gridTableName), ['updated_at'])
-            ->order('updated_at DESC')
-            ->limit(1);
-        $row = $this->getConnection()->fetchRow($select);
-
-        return isset($row['updated_at']) ? $row['updated_at'] : '0000-00-00 00:00:00';
-    }
-
     /**
      * Returns connection.
      *