AC-1271: Add rate limiting for payment information endpoint and mutation

Author: arhiopterecs

lib/internal/Magento/Framework/Cache/Backend/Redis.php

@@ -6,20 +6,22 @@
 
 namespace Magento\Framework\Cache\Backend;
 
+use InvalidArgumentException;
+
 /**
- * Redis wrapper to extend current implementation behaviour.
+ * Redis wrapper to extend current implementation behaviour
  */
 class Redis extends \Cm_Cache_Backend_Redis
 {
     /**
-     * Local state of preloaded keys.
+     * Local state of preloaded keys
      *
      * @var array
      */
     private $preloadedData = [];
 
     /**
-     * Array of keys to be preloaded.
+     * Array of keys to be preloaded
      *
      * @var array
      */
@@ -62,7 +64,7 @@ public function load($id, $doNotTestCacheValidity = false)
     }
 
     /**
-     * Cover errors on save operations, which may occurs when Redis cannot evict keys, which is expected in some cases.
+     * Cover errors on save operations, which may occurs when Redis cannot evict keys, which is expected in some cases
      *
      * @param string $data
      * @param string $id
@@ -96,28 +98,31 @@ public function remove($id)
     }
 
     /**
-     * Increment/decrement an item by given number (positive or negative for decrement).
+     * Increment/decrement an item by given number (positive or negative for decrement)
      *
      * @param string $id
      * @param int $update
-     * @param int|null $expireAt Expire item at ts.
+     * @param int|null $expireAt Expire item at ts
      * @return void
-     * @throws \InvalidArgumentException When increment is incorrect or the item is not a number.
+     * @throws InvalidArgumentException When increment is incorrect or the item is not a number
      */
     public function updateByAndGet(string $id, int $update, ?int $expireAt): int
     {
         if ($update === 0) {
-            throw new \InvalidArgumentException('Update must be != 0');
+            throw new InvalidArgumentException('Update must be != 0');
         }
+
         $method = 'incrBy';
         if ($update < 0) {
             $method = 'decrBy';
         }
+
         $redis = $this->_redis->pipeline();
         $redis->$method($id, abs($update));
         if ($expireAt) {
             $redis->expireAt($id, $expireAt);
         }
+
         $response = $redis->exec();
 
         return (int)$response[0];

lib/internal/Magento/Framework/Webapi/Backpressure/BackpressureContextFactory.php

@@ -10,10 +10,11 @@
 
 use Magento\Framework\App\Backpressure\ContextInterface;
 use Magento\Framework\App\Backpressure\IdentityProviderInterface;
+use Magento\Framework\App\ObjectManager;
 use Magento\Framework\App\RequestInterface;
 
 /**
- * Creates backpressure context for a request.
+ * Creates backpressure context for a request
  */
 class BackpressureContextFactory
 {
@@ -48,7 +49,7 @@ public function __construct(
     }
 
     /**
-     * Create context if possible for current request.
+     * Create context if possible for current request
      *
      * @param string $service Service class
      * @param string $method Service method
@@ -62,14 +63,17 @@ public function create(string $service, string $method, string $endpoint): ?Cont
             return null;
         }
 
-        return new RestContext(
-            $this->request,
-            $this->identityProvider->fetchIdentity(),
-            $this->identityProvider->fetchIdentityType(),
-            $typeId,
-            $service,
-            $method,
-            $endpoint
+        return ObjectManager::getInstance()->create(
+            RestContext::class,
+            [
+                $this->request,
+                $this->identityProvider->fetchIdentity(),
+                $this->identityProvider->fetchIdentityType(),
+                $typeId,
+                $service,
+                $method,
+                $endpoint
+            ]
         );
     }
 }

lib/internal/Magento/Framework/Webapi/Backpressure/BackpressureRequestTypeExtractorInterface.php

@@ -9,7 +9,7 @@
 namespace Magento\Framework\Webapi\Backpressure;
 
 /**
- * Extracts request type ID from endpoints.
+ * Extracts request type ID from endpoints
  */
 interface BackpressureRequestTypeExtractorInterface
 {

lib/internal/Magento/Framework/Webapi/Backpressure/CompositeRequestTypeExtractor.php

@@ -9,7 +9,7 @@
 namespace Magento\Framework\Webapi\Backpressure;
 
 /**
- * Uses other extractors.
+ * Uses other extractors
  */
 class CompositeRequestTypeExtractor implements BackpressureRequestTypeExtractorInterface
 {

lib/internal/Magento/Framework/Webapi/Backpressure/RestContext.php

@@ -11,6 +11,9 @@
 use Magento\Framework\App\Backpressure\ContextInterface;
 use Magento\Framework\App\RequestInterface;
 
+/**
+ * REST request context
+ */
 class RestContext implements ContextInterface
 {
     /**
@@ -108,7 +111,7 @@ public function getTypeId(): string
     }
 
     /**
-     * Service class name.
+     * Service class name
      *
      * @return string
      */
@@ -118,7 +121,7 @@ public function getService(): string
     }
 
     /**
-     * Service method.
+     * Service method
      *
      * @return string
      */
@@ -128,7 +131,7 @@ public function getMethod(): string
     }
 
     /**
-     * Endpoint route.
+     * Endpoint route
      *
      * @return string
      */